Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Takashi Iwai
At Tue, 9 Jul 2013 23:06:05 +0800, Ming Lei wrote: > > On Tue, Jul 9, 2013 at 10:45 PM, Takashi Iwai wrote: > > At Tue, 9 Jul 2013 22:39:36 +0800, > > Ming Lei wrote: > >> > >> On Tue, Jul 9, 2013 at 9:32 PM, Takashi Iwai wrote: > >> > At Tue, 9 Jul 2013 16:43:30 +0800, > >> >> Actually from vie

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Takashi Iwai
At Tue, 9 Jul 2013 23:22:33 +0800, Ming Lei wrote: > > On Tue, Jul 9, 2013 at 11:13 PM, Takashi Iwai wrote: > >> > >> The only cost of built-in user helper code is ~6Kbytes code on my armv7 > >> box. > >> > >> If the 6KB memory does mater for this non-distro kernel, we can introduce > >> more opt

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Ming Lei
On Tue, Jul 9, 2013 at 11:13 PM, Takashi Iwai wrote: >> >> The only cost of built-in user helper code is ~6Kbytes code on my armv7 >> box. >> >> If the 6KB memory does mater for this non-distro kernel, we can introduce >> more options. > > Well, if it doesn't matter, we don't need CONFIG_FW_LOADER

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Ming Lei
On Tue, Jul 9, 2013 at 10:45 PM, Takashi Iwai wrote: > At Tue, 9 Jul 2013 22:39:36 +0800, > Ming Lei wrote: >> >> On Tue, Jul 9, 2013 at 9:32 PM, Takashi Iwai wrote: >> > At Tue, 9 Jul 2013 16:43:30 +0800, >> >> Actually from view of distribution, dell rbu has to be compiled in, then >> >> no cod

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Takashi Iwai
At Tue, 9 Jul 2013 22:39:36 +0800, Ming Lei wrote: > > On Tue, Jul 9, 2013 at 9:32 PM, Takashi Iwai wrote: > > At Tue, 9 Jul 2013 16:43:30 +0800, > >> Actually from view of distribution, dell rbu has to be compiled in, then > >> no code size can be saved any more, which means looks the introduced

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Ming Lei
On Tue, Jul 9, 2013 at 9:32 PM, Takashi Iwai wrote: > At Tue, 9 Jul 2013 16:43:30 +0800, >> Actually from view of distribution, dell rbu has to be compiled in, then >> no code size can be saved any more, which means looks the introduced >> option in this patch isn't necessary. > > Well, but it mea

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Takashi Iwai
>> >> > > Author: Takashi Iwai > >> >> > > AuthorDate: Wed May 22 18:28:37 2013 +0200 > >> >> > > Committer: Greg Kroah-Hartman > >> >> > > CommitDate: Mon Jun 3 13:57:29 2013 -0700 >

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Ming Lei
6a549ac9d672d2951992b658c6 >> >> > > Commit: d05c39ea67f5786a549ac9d672d2951992b658c6 >> >> > > Parent: a3b2c8c7aa1ca860edcf0b0afa371d9eb2269c3c >> >> > > Author: Takashi Iwai >> >> > > AuthorDate: Wed May 22 18:28:37 2013 +020

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-08 Thread Takashi Iwai
t;> > > Parent: a3b2c8c7aa1ca860edcf0b0afa371d9eb2269c3c > >> > > Author: Takashi Iwai > >> > > AuthorDate: Wed May 22 18:28:37 2013 +0200 > >> > > Committer: Greg Kroah-Hartman > >> > > CommitDate: Mon Jun 3 13:57:29

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-08 Thread Ming Lei
gt; > > AuthorDate: Wed May 22 18:28:37 2013 +0200 >> > > Committer: Greg Kroah-Hartman >> > > CommitDate: Mon Jun 3 13:57:29 2013 -0700 >> > > >> > > dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly >> > >

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-08 Thread Takashi Iwai
At Mon, 8 Jul 2013 09:49:33 -0700, Greg KH wrote: > > On Mon, Jul 08, 2013 at 11:05:20AM +0200, Takashi Iwai wrote: > > The reason is that dell_rbu driver requires it. Without the kconfig > > option, this driver won't work at all. So, it's a right fix for > > dell_rbu. > > > > AFAIK, the consen

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-08 Thread Greg KH
On Mon, Jul 08, 2013 at 11:05:20AM +0200, Takashi Iwai wrote: > The reason is that dell_rbu driver requires it. Without the kconfig > option, this driver won't work at all. So, it's a right fix for > dell_rbu. > > AFAIK, the consensus in the kernel side is that this too long fw > loading time is

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-08 Thread Takashi Iwai
r: Greg Kroah-Hartman > > > CommitDate: Mon Jun 3 13:57:29 2013 -0700 > > > > > > dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly > > > > > > The usermode helper is mandatory for this driver. > > > > > > Signed-o

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-06 Thread Greg KH
b658c6 > > Parent: a3b2c8c7aa1ca860edcf0b0afa371d9eb2269c3c > > Author: Takashi Iwai > > AuthorDate: Wed May 22 18:28:37 2013 +0200 > > Committer: Greg Kroah-Hartman > > CommitDate: Mon Jun 3 13:57:29 2013 -0700 > > > > dell_rbu: Select CO

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-06 Thread Dave Jones
or: Takashi Iwai > AuthorDate: Wed May 22 18:28:37 2013 +0200 > Committer: Greg Kroah-Hartman > CommitDate: Mon Jun 3 13:57:29 2013 -0700 > > dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly > > The usermode helper is mandatory for this

[PATCH v2 1/2] dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-05-22 Thread Takashi Iwai
The usermode helper is mandatory for this driver. Signed-off-by: Takashi Iwai --- drivers/firmware/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index 9387630..0747872 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/K

[PATCH 3/3] dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-05-07 Thread Takashi Iwai
The usermode helper is mandatory for this driver. Signed-off-by: Takashi Iwai --- drivers/firmware/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index 9387630..0747872 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/K