Re: crypto: caam/qi - simplify error path for context allocation

On Thu, Nov 12, 2020 at 11:21:46AM +0200, Horia Geantă wrote: > > Wang Qing reports that IS_ERR_OR_NULL() should be matched with > PTR_ERR_OR_ZERO(), not PTR_ERR(). > > As it turns out, the error path always returns an error code, > i.e. NULL is never returned. > Update the code accordingly - s/I

Re: crypto: caam/qi - simplify error path for context allocation

On Fri, Nov 13, 2020 at 02:39:24PM +1100, Herbert Xu wrote: > Horia Geantă wrote: > > > > -- >8 -- > > > > Subject: [PATCH] crypto: caam/qi - simplify error path for context > > allocation > > You can't do this. Patchwork takes any replies with

Re: crypto: caam/qi - simplify error path for context allocation

Horia Geantă wrote: > > -- >8 -- > > Subject: [PATCH] crypto: caam/qi - simplify error path for context allocation You can't do this. Patchwork takes any replies with the same Subject line as a comment. You need to resend this patch with a different subject. Thanks, -

crypto: caam/qi - simplify error path for context allocation

riptor */ > edesc = aead_edesc_alloc(req, encrypt); > if (IS_ERR_OR_NULL(edesc)) > - return PTR_ERR(edesc); > + return PTR_ERR_OR_ZERO(edesc); > Digging a bit into the logic, it turns out aead_edesc_alloc() can't return a NULL pointer. -