Re: crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1

2007-02-04 Thread Miguel Ojeda
Ok, here it is the patch, just a draft. I have checked the Makefile to ensure that ks0108 was being called before than cfag12864b at boot, still, I'm not sure and I don't know if this will prevent the crash if ks0108 fails to init. Daniel, please test it. drivers-add-lcd-support-update10.patch

Re: crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1

2007-02-01 Thread Miguel Ojeda
On 2/1/07, Daniel Walker <[EMAIL PROTECTED]> wrote: On Thu, 2007-02-01 at 18:39 +0100, Miguel Ojeda wrote: > On 2/1/07, Daniel Walker <[EMAIL PROTECTED]> wrote: > > On Thu, 2007-02-01 at 18:13 +0100, Miguel Ojeda wrote: > > > > > > > > > > > > > > > > Well, I use the word "module" for both cases:

Re: crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1

2007-02-01 Thread Daniel Walker
On Thu, 2007-02-01 at 18:39 +0100, Miguel Ojeda wrote: > On 2/1/07, Daniel Walker <[EMAIL PROTECTED]> wrote: > > On Thu, 2007-02-01 at 18:13 +0100, Miguel Ojeda wrote: > > > > > > > > > > > > > > > > Well, I use the word "module" for both cases: When I modprobe > > > cfag12864b, if ks0108 fails, it

Re: crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1

2007-02-01 Thread Miguel Ojeda
On 2/1/07, Daniel Walker <[EMAIL PROTECTED]> wrote: On Thu, 2007-02-01 at 18:13 +0100, Miguel Ojeda wrote: > > > > > > Well, I use the word "module" for both cases: When I modprobe > cfag12864b, if ks0108 fails, it doesn't get linked. So I thought the > same happen for built-in drivers (in other

Re: crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1

2007-02-01 Thread Daniel Walker
On Thu, 2007-02-01 at 18:13 +0100, Miguel Ojeda wrote: > > > > > > Well, I use the word "module" for both cases: When I modprobe > cfag12864b, if ks0108 fails, it doesn't get linked. So I thought the > same happen for built-in drivers (in other words, I didn't think > cfag12864b would be linked i

Re: crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1

2007-02-01 Thread Miguel Ojeda
On 2/1/07, Daniel Walker <[EMAIL PROTECTED]> wrote: On Thu, 2007-02-01 at 16:16 +0100, Miguel Ojeda wrote: > The problem is easy: > > ks0108_init() prints the error message and exit with -EINVAL, so the > module isn't loaded properly. > > However, cfag12864b_init() is called, although ks0108 fail

Re: crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1

2007-02-01 Thread Daniel Walker
On Thu, 2007-02-01 at 16:16 +0100, Miguel Ojeda wrote: > The problem is easy: > > ks0108_init() prints the error message and exit with -EINVAL, so the > module isn't loaded properly. > > However, cfag12864b_init() is called, although ks0108 failed. It > returns 0 and after a while cfag12864b call

Re: crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1

2007-02-01 Thread Miguel Ojeda
The problem is easy: ks0108_init() prints the error message and exit with -EINVAL, so the module isn't loaded properly. However, cfag12864b_init() is called, although ks0108 failed. It returns 0 and after a while cfag12864b calls ks0108_writecontrol() which dereferences the uninitialized pointer

Re: crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1

2007-02-01 Thread Miguel Ojeda
On 1/7/07, Daniel Walker <[EMAIL PROTECTED]> wrote: (forgot to CC LKML) The options, CONFIG_CFAG12864B=y CONFIG_CFAG12864B_RATE=20 causes a crash at boot in 2.6.20-rc3-mm1. I don't have the hardware associated with the options. It looks like it just doesn't have guards to detect if the hardwar

crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1

2007-01-07 Thread Daniel Walker
(forgot to CC LKML) The options, CONFIG_CFAG12864B=y CONFIG_CFAG12864B_RATE=20 causes a crash at boot in 2.6.20-rc3-mm1. I don't have the hardware associated with the options. It looks like it just doesn't have guards to detect if the hardware doesn't exists. Here is the crash, ks0108: ERROR: