Re: cpufreq problem wrt suspend/resume on Athlon64 [update]

2005-02-07 Thread Rafael J. Wysocki
Hi, On Friday, 4 of February 2005 00:15, Rafael J. Wysocki wrote: > On Thursday, 3 of February 2005 15:22, Pavel Machek wrote: [-- snip --] > > > I'm currently thinking that the proper approach may be to add a > > > ->suspend() > > > routine to struct cpufreq_driver and call the driver-specific

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Rafael J. Wysocki
On Friday, 4 of February 2005 00:34, Nigel Cunningham wrote: > Hi. > > On Fri, 2005-02-04 at 10:15, Rafael J. Wysocki wrote: > > Instead of trying to blow up the battery I used the patch that forces the > > CPU > > to 800 MHz and it apparently survives resuming on batteries - at least 3 > > times

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Rafael J. Wysocki
Hi, On Thursday, 3 of February 2005 23:00, Pavel Machek wrote: > Hi! > > > > You may not run k8 notebook on max frequency on battery. Your system > > > will crash; and you might even damage battery. > > > > When I don't compile in cpufreq, it seems to run at 1,8 GHz (the max) > > all the time, o

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Nigel Cunningham
Hi. On Fri, 2005-02-04 at 10:15, Rafael J. Wysocki wrote: > Instead of trying to blow up the battery I used the patch that forces the CPU > to 800 MHz and it apparently survives resuming on batteries - at least 3 > times out of 3 attempts (I'll try some times more tomorrow). > > It seems to boot

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Rafael J. Wysocki
On Thursday, 3 of February 2005 15:22, Pavel Machek wrote: > Hi! > > > > > So, would it be acceptable to check in _suspend() if the state is S4 > > > > and drop the frequency in that case or do nothing otherwise? > > > > > > No. The point is that this is _very_ system-specific. Some systems resum

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Pavel Machek
Hi! > > You may not run k8 notebook on max frequency on battery. Your system > > will crash; and you might even damage battery. > > When I don't compile in cpufreq, it seems to run at 1,8 GHz (the max) > all the time, on AC power as well as on battery. Along with what you're > saying it leads to

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Pavel Machek
Hi! > > You may not run k8 notebook on max frequency on battery. Your system > > will crash; and you might even damage battery. > > When I don't compile in cpufreq, it seems to run at 1,8 GHz (the max) > all the time, on AC power as well as on battery. Along with what you're > saying it leads to

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Rafael J. Wysocki
On Thursday, 3 of February 2005 15:20, Pavel Machek wrote: > Hi! > > > > > > > On Thu, Feb 03, 2005 at 11:41:26AM +0100, Pavel Machek wrote: > > > > > > > Okay, you are right, restoring it unconditionaly would be bad > > > > > > > idea. Still it would be nice to tell cpufreq governor "please > >

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Pavel Machek
Hi! > > > So, would it be acceptable to check in _suspend() if the state is S4 > > > and drop the frequency in that case or do nothing otherwise? > > > > No. The point is that this is _very_ system-specific. Some systems resume > > always at full speed, some always at low speed; for S4 the behavi

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Pavel Machek
Hi! > > > > > On Thu, Feb 03, 2005 at 11:41:26AM +0100, Pavel Machek wrote: > > > > > > Okay, you are right, restoring it unconditionaly would be bad > > > > > > idea. Still it would be nice to tell cpufreq governor "please change > > > > > > the frequency ASAP" so it does not run at 800MHz for ha

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Rafael J. Wysocki
On Thursday, 3 of February 2005 13:40, Dominik Brodowski wrote: [-- snip --] > > So, would it be acceptable to check in _suspend() if the state is S4 > > and drop the frequency in that case or do nothing otherwise? > > No. The point is that this is _very_ system-specific. Some systems resume > alw

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Dominik Brodowski
On Thu, Feb 03, 2005 at 12:30:19PM +0100, Rafael J. Wysocki wrote: > On Thursday, 3 of February 2005 12:01, Dominik Brodowski wrote: > > On Thu, Feb 03, 2005 at 11:58:46AM +0100, Pavel Machek wrote: > > > Hi! > > > > > > > On Thu, Feb 03, 2005 at 11:41:26AM +0100, Pavel Machek wrote: > > > > > Oka

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Rafael J. Wysocki
On Thursday, 3 of February 2005 12:01, Dominik Brodowski wrote: > On Thu, Feb 03, 2005 at 11:58:46AM +0100, Pavel Machek wrote: > > Hi! > > > > > On Thu, Feb 03, 2005 at 11:41:26AM +0100, Pavel Machek wrote: > > > > Okay, you are right, restoring it unconditionaly would be bad > > > > idea. Still

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Dominik Brodowski
On Thu, Feb 03, 2005 at 11:58:46AM +0100, Pavel Machek wrote: > Hi! > > > On Thu, Feb 03, 2005 at 11:41:26AM +0100, Pavel Machek wrote: > > > Okay, you are right, restoring it unconditionaly would be bad > > > idea. Still it would be nice to tell cpufreq governor "please change > > > the frequency

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Pavel Machek
Hi! > On Thu, Feb 03, 2005 at 11:41:26AM +0100, Pavel Machek wrote: > > Okay, you are right, restoring it unconditionaly would be bad > > idea. Still it would be nice to tell cpufreq governor "please change > > the frequency ASAP" so it does not run at 800MHz for half an hour > > compiling kernels

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Dominik Brodowski
Hi, On Thu, Feb 03, 2005 at 11:41:26AM +0100, Pavel Machek wrote: > Okay, you are right, restoring it unconditionaly would be bad > idea. Still it would be nice to tell cpufreq governor "please change > the frequency ASAP" so it does not run at 800MHz for half an hour > compiling kernels on AC pow

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-03 Thread Pavel Machek
Hi! > > > I have noticed that the condition (cur_freq != cpu_policy->cur), which is > > > unlikely() according to cpufreq.c:cpufreq_resume(), occurs on every resume > > > on my box (Athlon64-based Asus). Every time the box resumes, I get a > > > message > > > like that: > > > > > > Warning: CPU

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-02 Thread Rafael J. Wysocki
On Wednesday, 2 of February 2005 14:31, Pavel Machek wrote: > Hi! > > > I have noticed that the condition (cur_freq != cpu_policy->cur), which is > > unlikely() according to cpufreq.c:cpufreq_resume(), occurs on every resume > > on my box (Athlon64-based Asus). Every time the box resumes, I get a

Re: cpufreq problem wrt suspend/resume on Athlon64

2005-02-02 Thread Pavel Machek
Hi! > I have noticed that the condition (cur_freq != cpu_policy->cur), which is > unlikely() according to cpufreq.c:cpufreq_resume(), occurs on every resume > on my box (Athlon64-based Asus). Every time the box resumes, I get a message > like that: > > Warning: CPU frequency out of sync: cpufreq

cpufreq problem wrt suspend/resume on Athlon64

2005-02-02 Thread Rafael J. Wysocki
Hi, I have noticed that the condition (cur_freq != cpu_policy->cur), which is unlikely() according to cpufreq.c:cpufreq_resume(), occurs on every resume on my box (Athlon64-based Asus). Every time the box resumes, I get a message like that: Warning: CPU frequency out of sync: cpufreq and timing