Re: convert #include "linux/..." to #include [PATCH]s follow

2007-08-19 Thread Joe Perches
On Mon, 2007-08-20 at 00:33 +0200, Jan Engelhardt wrote: > Not only that. All directories in include should be checked against > (e.g. ) Should any file in include/ have a line like: #include "[path/]file" Shouldn't these all be #include ? - To unsubscribe from this list: sen

Re: convert #include "linux/..." to #include [PATCH]s follow

2007-08-19 Thread Al Viro
On Sun, Aug 19, 2007 at 03:49:16PM -0700, Joe Perches wrote: > On Sun, 2007-08-19 at 23:44 +0100, Al Viro wrote: > > Except that some instances are legitimate (e.g. there was a bunch in > > arch/um, IIRC)... > > I guess it's a good thing that vger seems to have rejected > that 140KB patch I sent a

Re: convert #include "linux/..." to #include [PATCH]s follow

2007-08-19 Thread Joe Perches
On Sun, 2007-08-19 at 23:44 +0100, Al Viro wrote: > Except that some instances are legitimate (e.g. there was a bunch in > arch/um, IIRC)... I guess it's a good thing that vger seems to have rejected that 140KB patch I sent against arch/um and include/asm-um. cheers, Joe - To unsubscribe from th

Re: convert #include "linux/..." to #include [PATCH]s follow

2007-08-19 Thread Al Viro
On Mon, Aug 20, 2007 at 12:33:21AM +0200, Jan Engelhardt wrote: > > On Aug 19 2007 15:17, Joe Perches wrote: > >There are several files that: > > > >#include "linux/file" not #include > >#include "asm/file" not #include > > Not only that. All directories in include should be checked against > (

Re: convert #include "linux/..." to #include [PATCH]s follow

2007-08-19 Thread Jan Engelhardt
On Aug 19 2007 15:17, Joe Perches wrote: >There are several files that: > >#include "linux/file" not #include >#include "asm/file" not #include Not only that. All directories in include should be checked against (e.g. ) Jan -- - To unsubscribe from this list: send the line "unsubscri

Re: convert #include "linux/..." to #include [PATCH]s follow

2007-08-19 Thread Jesper Juhl
On 20/08/07, Joe Perches <[EMAIL PROTECTED]> wrote: > There are several files that: > > #include "linux/file" not #include > #include "asm/file" not #include > > Here's a little script that converts them: > If you've actually checked that such conversions are correct and work fine, how about a pa

convert #include "linux/..." to #include [PATCH]s follow

2007-08-19 Thread Joe Perches
There are several files that: #include "linux/file" not #include #include "asm/file" not #include Here's a little script that converts them: egrep -i -r -l --include=*.[ch] \ "^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \ | xargs sed -i -e 's/^[[:space:]]*#[[:space:]