Subject: [patch] workqueue: fix drivers/connector/connector.c
From: Ingo Molnar <[EMAIL PROTECTED]>
commit c4028958b6ecad064b1a6303a6a5906d4fe48d73 did an incorrect
conversion of the work-pending check in the connector device (which
device is enabled in the -rt kernel rpm) - fix this by
On 12/19/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
to: linux-kernel@vger.kernel.org
cc: [EMAIL PROTECTED]
2.6.20-rc1-git compilation error drivers/connector/connector.c:138:
error: ?struct work_struct? has no member named ?management?
$ date
Tue Dec 19 10:12:17 CST 2006
$ gi
to: linux-kernel@vger.kernel.org
cc: [EMAIL PROTECTED]
2.6.20-rc1-git compilation error drivers/connector/connector.c:138:
error: ?struct work_struct? has no member named ?management?
$ date
Tue Dec 19 10:12:17 CST 2006
$ git pull
Already up-to-date.
$ make -j 8
CHK include/linux
drivers/connector/connector.c: In function 'cn_call_callback':
> drivers/connector/connector.c:138: error: 'struct work_struct' has no
> member named 'management'
> drivers/connector/connector.c:138: error: 'struct work_struct' has no
> member named
CC [M] drivers/char/hangcheck-timer.o
CC drivers/clocksource/acpi_pm.o
LD drivers/clocksource/built-in.o
CC [M] drivers/connector/cn_queue.o
CC [M] drivers/connector/connector.o
drivers/connector/connector.c: In function 'cn_call_callback':
drivers/connector/conne
> I don't think it's entirely accidental that Python
Hmmm ... cutting off a brace-war at the pass
by escalating to a Python war -- good work ;).
Please suppress any urge to reply ...
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Hi, Tommy Reynolds schrub am Thu, 31 Mar 2005 20:41:35 -0600:
> Uttered Andrew Morton <[EMAIL PROTECTED]>, spake thus:
>
>> >if (uskb) {
>> >netlink_unicast(dev->nls, uskb, 0, 0);
>> >}
>>
>> Unneeded {}
>
> However, for maintainability (and best practices) they are essent
On Fri, 2005-04-01 at 00:02 -0800, Andrew Morton wrote:
> Evgeniy Polyakov <[EMAIL PROTECTED]> wrote:
> >
> > On Thu, 2005-03-31 at 23:42 -0800, Andrew Morton wrote:
> > > Evgeniy Polyakov <[EMAIL PROTECTED]> wrote:
> > > >
> > > > > What happens if we expect a reply to our message but userspace
Evgeniy Polyakov <[EMAIL PROTECTED]> wrote:
>
> On Thu, 2005-03-31 at 23:42 -0800, Andrew Morton wrote:
> > Evgeniy Polyakov <[EMAIL PROTECTED]> wrote:
> > >
> > > > What happens if we expect a reply to our message but userspace never
> sends
> > > > one? Does the kernel leak memory? Do othe
On Thu, 2005-03-31 at 23:42 -0800, Andrew Morton wrote:
> Evgeniy Polyakov <[EMAIL PROTECTED]> wrote:
> >
> > > What happens if we expect a reply to our message but userspace never sends
> > > one? Does the kernel leak memory? Do other processes hang?
> >
> > It is only advice, one may easily sk
Evgeniy Polyakov <[EMAIL PROTECTED]> wrote:
>
> > What happens if we expect a reply to our message but userspace never sends
> > one? Does the kernel leak memory? Do other processes hang?
>
> It is only advice, one may easily skip seq/ack initialization.
> I could remove it totally from the head
On Thu, 2005-03-31 at 17:30 -0800, Andrew Morton wrote:
> Some belated comments...
>
>
> >
> > module_param(unit, int, 0);
> > module_param(cn_idx, uint, 0);
> > module_param(cn_val, uint, 0);
>
> MODULE_PARM_DESC needed, please.
Yep.
> > static DEFINE_SPINLOCK(notify_lock);
> > static LIST_H
Uttered Andrew Morton <[EMAIL PROTECTED]>, spake thus:
> > if (uskb) {
> > netlink_unicast(dev->nls, uskb, 0, 0);
> > }
>
> Unneeded {}
Speaking strictly as a language lawyer, they are not needed.
However, for maintainability (and best practices) they are essential.
They mak
Some belated comments...
>
> module_param(unit, int, 0);
> module_param(cn_idx, uint, 0);
> module_param(cn_val, uint, 0);
MODULE_PARM_DESC needed, please.
> static DEFINE_SPINLOCK(notify_lock);
> static LIST_HEAD(notify_list);
>
> static struct cn_dev cdev;
>
> int cn_already_initialized =
On Mon, 2005-02-14 at 13:01 +0100, Guillaume Thouvenin wrote:
> This patch removes unreachable code in cn_netlink_send() function.
The code can be reach via
nlh = NLMSG_PUT(skb, 0, msg->seq, NLMSG_DONE, size - sizeof(*nlh));
So the patch is wrong
Sorry for that
Guillaume
-
To unsubscribe from
This patch removes unreachable code in cn_netlink_send() function.
Signed-off-by: Guillaume Thouvenin <[EMAIL PROTECTED]>
--- drivers/connector/connector.c.orig 2005-02-14 12:52:32.0 +0100
+++ drivers/connector/connector.c 2005-02-14 12:52:44.0 +0100
@@ -119,11
t can be made static.
> >
> > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
> >
> > --- linux-2.6.11-rc2-mm2-full/drivers/connector/connector.c.old 2005-01-31
> > 13:09:14.00000 +0100
> > +++ linux-2.6.11-rc2-mm2-full/drivers/connector/connector.c
t; --- linux-2.6.11-rc2-mm2-full/drivers/connector/connector.c.old 2005-01-31
> 13:09:14.0 +0100
> +++ linux-2.6.11-rc2-mm2-full/drivers/connector/connector.c 2005-01-31
> 13:09:28.0 +0100
> @@ -41,7 +41,7 @@
> module_param(cn_idx, uint, 0);
> module_param(cn_val, u
k <[EMAIL PROTECTED]>
> --- linux-2.6.11-rc2-mm2-full/drivers/connector/connector.c.old
> 2005-01-31 13:09:14.0 +0100
> +++ linux-2.6.11-rc2-mm2-full/drivers/connector/connector.c 2005-01-31
> 13:09:28.0 +0100
> @@ -41,7 +41,7 @@
> module_param(cn_idx
.11-rc2-mm2-full/drivers/connector/connector.c 2005-01-31
13:09:28.0 +0100
@@ -41,7 +41,7 @@
module_param(cn_idx, uint, 0);
module_param(cn_val, uint, 0);
-spinlock_t notify_lock = SPIN_LOCK_UNLOCKED;
+static spinlock_t notify_lock = SPIN_LOCK_UNLOCKED;
static LIST_HEAD(notify_
20 matches
Mail list logo
