Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Markus Elfring
> What are the additional effects? I suggest to take another look at the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 ("drivers: provide devm_platform_ioremap_resource()" from 2019-02-20) which triggered the discussed software evolution. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds

Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-17 Thread Marc Zyngier
On 2019-10-17 15:22, Alexandre Belloni wrote: While it is useful for new drivers to use devm_platform_ioremap_resource, this script is currently used to spam maintainers, often updating very old drivers. The net benefit is the removal of 2 lines of code in the driver but the review load for the

Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-17 Thread Julia Lawall
On Thu, 17 Oct 2019, Alexandre Belloni wrote: > While it is useful for new drivers to use devm_platform_ioremap_resource, > this script is currently used to spam maintainers, often updating very old > drivers. The net benefit is the removal of 2 lines of code in the driver > but the review load

[PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-17 Thread Alexandre Belloni
While it is useful for new drivers to use devm_platform_ioremap_resource, this script is currently used to spam maintainers, often updating very old drivers. The net benefit is the removal of 2 lines of code in the driver but the review load for the maintainers is huge. As of now, more that 560 pat