18 AM
To: Casey Leedom
Cc: Hariprasad S; James E.J. Bottomley; net...@vger.kernel.org;
linux-kernel@vger.kernel.org; linux-scsi; David Miller
Subject: Re: chelsio: Use a more common const struct pci_device_id foo[] style
On Mon, 2015-02-16 at 19:07 +, Casey Leedom wrote:
> I understand
On Mon, 2015-02-16 at 19:07 +, Casey Leedom wrote:
> I understand that OS-independence issues aren't something which are
> normally accommodated, but as long as definitions don't introduce
> unnecessary "foreign intrusion" I would hope that it would be okay.
> As I noted, our t4_regs.h file i
clarifying text to suggest?
cheers, Joe
> In conclusion:
>
> A. I like the use of "const" in the table.
>
> B. I like removing the redundant content inclusion check of
> CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN.
>
> C. I'm uncomfortable with all the other changes.
> Casey
>
> __
>
> B. I like removing the redundant content inclusion check of
> CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN.
>
> C. I'm uncomfortable with all the other changes.
> Casey
>
> ____________
> From: Joe Perches [j...@perches.co
ther changes.
Casey
From: Joe Perches [j...@perches.com]
Sent: Friday, February 13, 2015 6:05 PM
To: Hariprasad S; Casey Leedom; James E.J. Bottomley
Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-scsi
Subject: chelsio: Use a more common con
Chelsio code shares a pci_device_table from an #include file.
Make the include guard simpler and make the arrays const.
Reduces data by moving tables to text.
Removed unnecessary macros:
o CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN
o CH_PCI_DEVICE_ID_TABLE_DEFINE_END
o CH_PCI_ID_TABLE_ENTRY (moved to th
6 matches
Mail list logo
