Re: checkpatch.pl should suggest __section

2019-08-12 Thread Nick Desaulniers
On Mon, Aug 12, 2019 at 11:27 AM Joe Perches wrote: > > On Mon, 2019-08-12 at 11:20 -0700, Nick Desaulniers wrote: > > On Fri, Aug 9, 2019 at 4:17 PM Joe Perches wrote: > > > On Fri, 2019-08-09 at 16:04 -0700, Nick Desaulniers wrote: > > > > > how about: > > > > > --- > > > > > scripts/checkpatc

Re: checkpatch.pl should suggest __section

2019-08-12 Thread Joe Perches
On Mon, 2019-08-12 at 11:20 -0700, Nick Desaulniers wrote: > On Fri, Aug 9, 2019 at 4:17 PM Joe Perches wrote: > > On Fri, 2019-08-09 at 16:04 -0700, Nick Desaulniers wrote: > > > > how about: > > > > --- > > > > scripts/checkpatch.pl | 9 + > > > > 1 file changed, 9 insertions(+) > > > >

Re: checkpatch.pl should suggest __section

2019-08-12 Thread Nick Desaulniers
On Fri, Aug 9, 2019 at 4:17 PM Joe Perches wrote: > > On Fri, 2019-08-09 at 16:04 -0700, Nick Desaulniers wrote: > > > how about: > > > --- > > > scripts/checkpatch.pl | 9 + > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > >

Re: checkpatch.pl should suggest __section

2019-08-10 Thread Miguel Ojeda
On Sat, Aug 10, 2019 at 12:21 AM Nick Desaulniers wrote: > > Hi Joe, > While debugging: > https://github.com/ClangBuiltLinux/linux/issues/619 > we found a bunch of places where __section is not used but could be, > and uses a string literal when it probably should not be. > > Just a thought that m

Re: checkpatch.pl should suggest __section

2019-08-09 Thread Joe Perches
On Fri, 2019-08-09 at 16:04 -0700, Nick Desaulniers wrote: > > how about: > > --- > > scripts/checkpatch.pl | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index 1cdacb4fd207..8e6693ca772c 100755 > > --- a/scripts/checkpatc

Re: checkpatch.pl should suggest __section

2019-08-09 Thread Nick Desaulniers
On Fri, Aug 9, 2019 at 3:58 PM Joe Perches wrote: > > On Fri, 2019-08-09 at 15:21 -0700, Nick Desaulniers wrote: > > Hi Joe, > > While debugging: > > https://github.com/ClangBuiltLinux/linux/issues/619 > > we found a bunch of places where __section is not used but could be, > > and uses a string l

Re: checkpatch.pl should suggest __section

2019-08-09 Thread Joe Perches
On Fri, 2019-08-09 at 15:21 -0700, Nick Desaulniers wrote: > Hi Joe, > While debugging: > https://github.com/ClangBuiltLinux/linux/issues/619 > we found a bunch of places where __section is not used but could be, > and uses a string literal when it probably should not be. > > Just a thought that m

checkpatch.pl should suggest __section

2019-08-09 Thread Nick Desaulniers
Hi Joe, While debugging: https://github.com/ClangBuiltLinux/linux/issues/619 we found a bunch of places where __section is not used but could be, and uses a string literal when it probably should not be. Just a thought that maybe checkpatch.pl could warn if `__attribute__((section` appeared in the