Re: checkpatch false positon on EXPORT_SYMBOL

2016-04-12 Thread Andy Whitcroft
On Tue, Apr 12, 2016 at 10:49:17AM -0700, Joe Perches wrote: > > On Tue, 2016-04-12 at 13:59 +0100, Andy Whitcroft wrote: > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > [] > > @@ -3000,7 +3000,7 @@ sub process { > > > >   $realline_next = $line_nr_next; > >  

Re: checkpatch false positon on EXPORT_SYMBOL

2016-04-12 Thread Daniel Walker
On 04/12/2016 10:49 AM, Joe Perches wrote: On Tue, 2016-04-12 at 13:59 +0100, Andy Whitcroft wrote: diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] @@ -3000,7 +3000,7 @@ sub process { $realline_next = $line_nr_next; if (defined $rea

Re: checkpatch false positon on EXPORT_SYMBOL

2016-04-12 Thread Joe Perches
> On Tue, 2016-04-12 at 13:59 +0100, Andy Whitcroft wrote: > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -3000,7 +3000,7 @@ sub process { > >   $realline_next = $line_nr_next; >   if (defined $realline_next && >    

Re: checkpatch false positon on EXPORT_SYMBOL

2016-04-12 Thread Daniel Walker
On 04/12/2016 05:59 AM, Andy Whitcroft wrote: On Mon, Apr 11, 2016 at 03:09:42PM -0700, Joe Perches wrote: On Mon, 2016-04-11 at 14:51 -0700, Daniel Walker wrote: On 03/31/2016 12:21 PM, Joe Perches wrote: On Thu, 2016-03-31 at 08:01 -0700, Daniel Walker wrote: The below looks like normal cod

Re: checkpatch false positon on EXPORT_SYMBOL

2016-04-12 Thread Andy Whitcroft
On Mon, Apr 11, 2016 at 03:09:42PM -0700, Joe Perches wrote: > On Mon, 2016-04-11 at 14:51 -0700, Daniel Walker wrote: > > On 03/31/2016 12:21 PM, Joe Perches wrote: > > > > > > On Thu, 2016-03-31 at 08:01 -0700, Daniel Walker wrote: > > > > > > > > The below looks like normal code but the last e

Re: checkpatch false positon on EXPORT_SYMBOL

2016-04-11 Thread Joe Perches
On Mon, 2016-04-11 at 14:51 -0700, Daniel Walker wrote: > On 03/31/2016 12:21 PM, Joe Perches wrote: > > > > On Thu, 2016-03-31 at 08:01 -0700, Daniel Walker wrote: > > > > > > The below looks like normal code but the last export symbol gets the > > > warning, > > > > > > > > > WARNING:EXPORT_S

Re: checkpatch false positon on EXPORT_SYMBOL

2016-04-11 Thread Daniel Walker
On 03/31/2016 12:21 PM, Joe Perches wrote: On Thu, 2016-03-31 at 08:01 -0700, Daniel Walker wrote: The below looks like normal code but the last export symbol gets the warning, WARNING:EXPORT_SYMBOL: EXPORT_SYMBOL(foo); should immediately follw its function/variable #16: FILE: kernel/acct.c:70

Re: checkpatch false positon on EXPORT_SYMBOL

2016-03-31 Thread Joe Perches
On Thu, 2016-03-31 at 08:01 -0700, Daniel Walker wrote: > The below looks like normal code but the last export symbol gets the  > warning, > > > WARNING:EXPORT_SYMBOL: EXPORT_SYMBOL(foo); should immediately follw its  > function/variable > #16: FILE: kernel/acct.c:70: > +EXPORT_SYMBOL(test_export

checkpatch false positon on EXPORT_SYMBOL

2016-03-31 Thread Daniel Walker
The below looks like normal code but the last export symbol gets the warning, WARNING:EXPORT_SYMBOL: EXPORT_SYMBOL(foo); should immediately follw its function/variable #16: FILE: kernel/acct.c:70: +EXPORT_SYMBOL(test_export);/* Error ! */ It seems to have to do with the comments at the