Re: [B.A.T.M.A.N.] checkpatch: CHECK: No space is necessary after a cast

2015-02-20 Thread Marek Lindner
On Thursday, February 19, 2015 11:55:41 Joe Perches wrote: > > Can you make a suggestion / patch for checkpatch to better handle this > > case ? > The "sizeof" test in the current script doesn't work. > > I believe the patch below works with no false positives > but it's perl regexes against odd

Re: checkpatch: CHECK: No space is necessary after a cast

2015-02-19 Thread Joe Perches
On Thu, 2015-02-19 at 13:35 +0800, Marek Lindner wrote: > Hi Joe, Hi Marek > we have come across a checkpatch false-positive: [] > BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6); > CHECK: No space is necessary after a cast > #440: FILE: main.c:440: > + BUILD_BUG_ON(sizeof(stru

checkpatch: CHECK: No space is necessary after a cast

2015-02-18 Thread Marek Lindner
Hi Joe, we have come across a checkpatch false-positive: static void batadv_recv_handler_init(void) { int i; for (i = 0; i < ARRAY_SIZE(batadv_rx_handler); i++) batadv_rx_handler[i] = batadv_recv_unhandled_packet; for (i = BATADV_UNICAST_MIN; i <= B

Re: checkpatch: CHECK: No space is necessary after a cast

2014-09-29 Thread Kalle Valo
Joe Perches writes: > On Mon, 2014-09-29 at 14:49 +0300, Kalle Valo wrote: >> Hi Joe, >> >> I have a problem with checkpatch. On ath10k we have this function: >> >> static inline struct ath10k_skb_cb *ATH10K_SKB_CB(struct sk_buff *skb) >> { >> BUILD_BUG_ON(sizeof(struct ath10k_skb_cb) > >>

Re: checkpatch: CHECK: No space is necessary after a cast

2014-09-29 Thread Joe Perches
On Mon, 2014-09-29 at 14:49 +0300, Kalle Valo wrote: > Hi Joe, > > I have a problem with checkpatch. On ath10k we have this function: > > static inline struct ath10k_skb_cb *ATH10K_SKB_CB(struct sk_buff *skb) > { > BUILD_BUG_ON(sizeof(struct ath10k_skb_cb) > >IEEE80211_T