Re: bug in migrate page

2007-08-22 Thread Christoph Lameter
On Wed, 22 Aug 2007, Shaohua Li wrote: > commit dc386d4d1e98bb39fb967ee156cd456c802fc692 adds rcu_read_lock, but > some routines in the lock range might sleep (like lock_buffer, > aops->writepage), I saw a 'sleep in atomic' warning. It appears the > patch has several versions before. Doing rcu_rea

Re: bug in migrate page

2007-08-21 Thread KAMEZAWA Hiroyuki
On Wed, 22 Aug 2007 10:50:53 +0800 Shaohua Li <[EMAIL PROTECTED]> wrote: > > At quick glance, above path has no writepage() ops. > > just replace swap's radix tree entry. > I missed swap has .migratepage and thought fallback_migrate_page is > used, then I thought doing rcu lock in PageAnon case is

Re: bug in migrate page

2007-08-21 Thread Shaohua Li
On Wed, 2007-08-22 at 11:52 +0900, KAMEZAWA Hiroyuki wrote: > On Wed, 22 Aug 2007 10:08:09 +0800 > Shaohua Li <[EMAIL PROTECTED]> wrote: > > > commit dc386d4d1e98bb39fb967ee156cd456c802fc692 adds rcu_read_lock, but > > some routines in the lock range might sleep (like lock_buffer, > > aops->writep

Re: bug in migrate page

2007-08-21 Thread KAMEZAWA Hiroyuki
On Wed, 22 Aug 2007 10:08:09 +0800 Shaohua Li <[EMAIL PROTECTED]> wrote: > commit dc386d4d1e98bb39fb967ee156cd456c802fc692 adds rcu_read_lock, but > some routines in the lock range might sleep (like lock_buffer, > aops->writepage), I saw a 'sleep in atomic' warning. It appears the > patch has seve

bug in migrate page

2007-08-21 Thread Shaohua Li
commit dc386d4d1e98bb39fb967ee156cd456c802fc692 adds rcu_read_lock, but some routines in the lock range might sleep (like lock_buffer, aops->writepage), I saw a 'sleep in atomic' warning. It appears the patch has several versions before. Doing rcu_read_lock in PageAnon sounds break the case of Page