Re: [lm-sensors] broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-26 Thread Jiri Slaby
On 11/21/2007 01:00 AM, Rafael J. Wysocki wrote: > On Tuesday, 20 of November 2007, Mark M. Hoffman wrote: >> commit ce9c7b78c839a6304696d90083eac08baad524ce >> Author: Mark M. Hoffman <[EMAIL PROTECTED]> >> Date: Tue Nov 20 07:51:50 2007 -0500 >> >> hwmon: (coretemp) fix suspend/resume hang

Re: [lm-sensors] broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-21 Thread Rafael J. Wysocki
On Wednesday, 21 of November 2007, Alan Stern wrote: > On Wed, 21 Nov 2007, Rafael J. Wysocki wrote: > > > > Is it possible to unregister a driver on CPU_DOWN_PREPARE_FROZEN? > > > > No. In that case the suspend core is holding the device's mutex and your > > attempt to unregister it will deadlo

Re: [lm-sensors] broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-21 Thread Alan Stern
On Wed, 21 Nov 2007, Rafael J. Wysocki wrote: > > Is it possible to unregister a driver on CPU_DOWN_PREPARE_FROZEN? > > No. In that case the suspend core is holding the device's mutex and your > attempt to unregister it will deadlock with it. > > Do you _have_ _to_ unregister the device at all?

Re: [lm-sensors] broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-20 Thread Rafael J. Wysocki
On Tuesday, 20 of November 2007, Mark M. Hoffman wrote: > Hi all: > > * Alan Stern <[EMAIL PROTECTED]> [2007-11-19 15:27:14 -0500]: > > On Mon, 19 Nov 2007, Rudolf Marek wrote: > > > > > Hello all, > > > >>> gives coretemp_cpu_callback -> coretemp_device_remove -> > > > >>> platform_device_unregi

Re: [lm-sensors] broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-20 Thread Mark M. Hoffman
Hi all: * Alan Stern <[EMAIL PROTECTED]> [2007-11-19 15:27:14 -0500]: > On Mon, 19 Nov 2007, Rudolf Marek wrote: > > > Hello all, > > >>> gives coretemp_cpu_callback -> coretemp_device_remove -> > > >>> platform_device_unregister, so coretemp seems to be what I have and you > > >>> don't. > > >

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-19 Thread Rafael J. Wysocki
On Monday, 19 of November 2007, Rudolf Marek wrote: > Hello all, > >>> gives coretemp_cpu_callback -> coretemp_device_remove -> > >>> platform_device_unregister, so coretemp seems to be what I have and you > >>> don't. > > > > Yes. > > > > For the coretemp developers: coretemp_cpu_callback() nee

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-19 Thread Alan Stern
On Mon, 19 Nov 2007, Rudolf Marek wrote: > Hello all, > >>> gives coretemp_cpu_callback -> coretemp_device_remove -> > >>> platform_device_unregister, so coretemp seems to be what I have and you > >>> don't. > > > > Yes. > > > > For the coretemp developers: coretemp_cpu_callback() needs to be m

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-19 Thread Rudolf Marek
Hello all, gives coretemp_cpu_callback -> coretemp_device_remove -> platform_device_unregister, so coretemp seems to be what I have and you don't. Yes. For the coretemp developers: coretemp_cpu_callback() needs to be more careful about what it does. During a system sleep transition (suspend,

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Alan Stern
On Sun, 18 Nov 2007, Jiri Slaby wrote: > > gives coretemp_cpu_callback -> coretemp_device_remove -> > > platform_device_unregister, so coretemp seems to be what I have and you > > don't. Yes. For the coretemp developers: coretemp_cpu_callback() needs to be more careful about what it does. Dur

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Jiri Slaby
Aah, we probably should let coretemp people known. Whole thread: http://marc.info/?t=11950720581&r=1&w=2 On 11/18/2007 08:09 PM, Jiri Slaby wrote: > On 11/18/2007 06:07 PM, Alan Stern wrote: >> You'll get more useful results if you redo your changes to >> notifier_call_chain(). Have it prin

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Rafael J. Wysocki
On Sunday, 18 of November 2007, Jiri Slaby wrote: > On 11/18/2007 11:27 PM, Rafael J. Wysocki wrote: > > You can use a global variable to switch the logging only before the CPU > > hotunplug done by the suspend code. You just need to hack > > disable_nonboot_cpus() for that. > > If I understand y

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Jiri Slaby
On 11/18/2007 11:27 PM, Rafael J. Wysocki wrote: > You can use a global variable to switch the logging only before the CPU > hotunplug done by the suspend code. You just need to hack > disable_nonboot_cpus() for that. If I understand you correctly, that's what BUBAK variable is there for. But it

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Rafael J. Wysocki
On Sunday, 18 of November 2007, Jiri Slaby wrote: > On 11/18/2007 06:07 PM, Alan Stern wrote: > > You'll get more useful results if you redo your changes to > > notifier_call_chain(). Have it print out the address of the routine > > _before_ making the call, and don't limit it to 20. That way y

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Jiri Slaby
On 11/18/2007 06:07 PM, Alan Stern wrote: > You'll get more useful results if you redo your changes to > notifier_call_chain(). Have it print out the address of the routine > _before_ making the call, and don't limit it to 20. That way you'll > know exactly which notifier routine ends up hangi

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Alan Stern
On Sun, 18 Nov 2007, Jiri Slaby wrote: > On 11/18/2007 04:23 PM, Rafał J. Wysocki wrote: > > On Sunday, 18 of November 2007, Jiri Slaby wrote: > >> On 11/18/2007 04:03 PM, Rafael J. Wysocki wrote: > >>> Can you also make the new System-map available, please? > >> Sure: > >> http://www.fi.muni.cz/

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Jiri Slaby
On 11/18/2007 04:23 PM, Rafał J. Wysocki wrote: > On Sunday, 18 of November 2007, Jiri Slaby wrote: >> On 11/18/2007 04:03 PM, Rafael J. Wysocki wrote: >>> Can you also make the new System-map available, please? >> Sure: >> http://www.fi.muni.cz/~xslaby/sklad/System.map1 > > The last notifier call

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Rafał J. Wysocki
On Sunday, 18 of November 2007, Jiri Slaby wrote: > On 11/18/2007 04:03 PM, Rafael J. Wysocki wrote: > > Can you also make the new System-map available, please? > > Sure: > http://www.fi.muni.cz/~xslaby/sklad/System.map1 The last notifier called in http://www.fi.muni.cz/~xslaby/sklad/susp_hang2.p

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Jiri Slaby
On 11/18/2007 04:03 PM, Rafael J. Wysocki wrote: > Can you also make the new System-map available, please? Sure: http://www.fi.muni.cz/~xslaby/sklad/System.map1 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo in

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Rafael J. Wysocki
On Sunday, 18 of November 2007, Jiri Slaby wrote: > On 11/18/2007 02:42 PM, Rafael J. Wysocki wrote: > > On Sunday, 18 of November 2007, Jiri Slaby wrote: > >> On 11/18/2007 01:42 PM, Jiri Slaby wrote: > >>> See shot of prints here: > >>> http://www.fi.muni.cz/~xslaby/sklad/susp_hang1.png > >> BTW

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Jiri Slaby
On 11/18/2007 02:42 PM, Rafael J. Wysocki wrote: > On Sunday, 18 of November 2007, Jiri Slaby wrote: >> On 11/18/2007 01:42 PM, Jiri Slaby wrote: >>> See shot of prints here: >>> http://www.fi.muni.cz/~xslaby/sklad/susp_hang1.png >> BTW output from that tree minus the patch: > > Hm, it looks like

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Rafael J. Wysocki
On Sunday, 18 of November 2007, Jiri Slaby wrote: > On 11/18/2007 01:42 PM, Jiri Slaby wrote: > > See shot of prints here: > > http://www.fi.muni.cz/~xslaby/sklad/susp_hang1.png > > BTW output from that tree minus the patch: Hm, it looks like one of the CPU hotplug notifiers is doing something wr

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Jiri Slaby
On 11/18/2007 01:42 PM, Jiri Slaby wrote: > See shot of prints here: > http://www.fi.muni.cz/~xslaby/sklad/susp_hang1.png BTW output from that tree minus the patch: _cpu_down: s _cpu_down: t CPU 1 is now offline SMP alternatives: switching to UP code _cpu_down: u notifier_call_chain: c 802

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-18 Thread Jiri Slaby
Alan Stern napsal(a): > On Sat, 17 Nov 2007, Rafael J. Wysocki wrote: >> On Saturday, 17 of November 2007, Jiri Slaby wrote: >>> On 11/16/2007 05:10 PM, Alan Stern wrote: The thing to do is figure out which driver is causing the problem. Jiri, try enabling CONFIG_DEBUG_DRIVER. >>> Sadly

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-17 Thread Alan Stern
On Sat, 17 Nov 2007, Rafael J. Wysocki wrote: > On Saturday, 17 of November 2007, Jiri Slaby wrote: > > On 11/16/2007 05:10 PM, Alan Stern wrote: > > > On Thu, 15 Nov 2007, Greg KH wrote: > > > > > >>> The offending -mm patch is > > >>> gregkh-driver-pm-acquire-device-locks-prior-to-suspending.pa

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-17 Thread Rafael J. Wysocki
On Saturday, 17 of November 2007, Jiri Slaby wrote: > On 11/16/2007 05:10 PM, Alan Stern wrote: > > On Thu, 15 Nov 2007, Greg KH wrote: > > > >>> The offending -mm patch is > >>> gregkh-driver-pm-acquire-device-locks-prior-to-suspending.patch > >>> > >>> 2.6.24-rc2-mm1 minus it works just fine; PR

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-17 Thread Alan Stern
On Sat, 17 Nov 2007, Jiri Slaby wrote: > > The thing to do is figure out which driver is causing the problem. > > Jiri, try enabling CONFIG_DEBUG_DRIVER. > > Sadly no output. Guess I'll have to try running 2.6.24-rc2-mm1 on my own system. In the meantime, you can try adding some printk state

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-17 Thread Jiri Slaby
On 11/17/2007 04:08 PM, Jiri Slaby wrote: > On 11/16/2007 05:10 PM, Alan Stern wrote: >> If there's also a config >> option to prevent the console from being suspended, set it as well. > > no_suspend_console kernel parameter has no effect (why?). Eh, no, this (/proc/cmdline): ro root=/dev/md1

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-17 Thread Jiri Slaby
On 11/16/2007 05:10 PM, Alan Stern wrote: > On Thu, 15 Nov 2007, Greg KH wrote: > >>> The offending -mm patch is >>> gregkh-driver-pm-acquire-device-locks-prior-to-suspending.patch >>> >>> 2.6.24-rc2-mm1 minus it works just fine; PROVE_LOCKING shows nothing new >>> when >>> the patch is applied.

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-16 Thread Alan Stern
On Thu, 15 Nov 2007, Greg KH wrote: > > The offending -mm patch is > > gregkh-driver-pm-acquire-device-locks-prior-to-suspending.patch > > > > 2.6.24-rc2-mm1 minus it works just fine; PROVE_LOCKING shows nothing new > > when > > the patch is applied. > > Thanks for tracking this down. Alan, an

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-15 Thread Greg KH
On Fri, Nov 16, 2007 at 12:59:41AM +0100, Jiri Slaby wrote: > On 11/14/2007 10:48 PM, Rafael J. Wysocki wrote: > > On Wednesday, 14 of November 2007, Jiri Slaby wrote: > >> On 11/14/2007 02:59 AM, Andrew Morton wrote: > >>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc2/2.

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-15 Thread Jiri Slaby
On 11/14/2007 10:48 PM, Rafael J. Wysocki wrote: > On Wednesday, 14 of November 2007, Jiri Slaby wrote: >> On 11/14/2007 02:59 AM, Andrew Morton wrote: >>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc2/2.6.24-rc2-mm1/ >> Doesn't suspend for me (neither broken-out-2007-11-

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-14 Thread Rafael J. Wysocki
On Wednesday, 14 of November 2007, Jiri Slaby wrote: > On 11/14/2007 02:59 AM, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc2/2.6.24-rc2-mm1/ > > Doesn't suspend for me (neither broken-out-2007-11-13-04-14 did) on x86_64. > echo mem >/sys/power/st

Re: broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-14 Thread Andrew Morton
On Wed, 14 Nov 2007 21:24:39 +0100 Jiri Slaby <[EMAIL PROTECTED]> wrote: > On 11/14/2007 02:59 AM, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc2/2.6.24-rc2-mm1/ > > Doesn't suspend for me (neither broken-out-2007-11-13-04-14 did) on x86_64. > ec

broken suspend [Was: 2.6.24-rc2-mm1]

2007-11-14 Thread Jiri Slaby
On 11/14/2007 02:59 AM, Andrew Morton wrote: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc2/2.6.24-rc2-mm1/ Doesn't suspend for me (neither broken-out-2007-11-13-04-14 did) on x86_64. echo mem >/sys/power/state causes shut down of disk(s) and blinking cursor on 1,1 posi