[PATCH] block: free q->flush_rq in blk_init_allocated_queue error paths

2014-03-20 Thread Jens Axboe
Hi Linus, Turns out there was a potential leak in the error path of the flush fixup from the last pull, which Dave Jones spotted. Can you apply this to your current tree before tagging 3.14? Thanks! From: Dave Jones Commit 7982e90c3a ("block: fix q->flush_rq NULL pointer crash on dm-mpath flus

Re: block: free q->flush_rq in blk_init_allocated_queue error paths.

2014-03-20 Thread Jens Axboe
On 03/19/2014 01:22 PM, Mike Snitzer wrote: On Wed, Mar 19 2014 at 3:12pm -0400, Dave Jones wrote: Commit 7982e90c3a ("block: fix q->flush_rq NULL pointer crash on dm-mpath flush") moved an allocation to blk_init_allocated_queue(), but neglected to free that allocation on the error paths tha

Re: block: free q->flush_rq in blk_init_allocated_queue error paths.

2014-03-19 Thread Mike Snitzer
On Wed, Mar 19 2014 at 3:12pm -0400, Dave Jones wrote: > Commit 7982e90c3a ("block: fix q->flush_rq NULL pointer crash on dm-mpath > flush") > moved an allocation to blk_init_allocated_queue(), but neglected to free > that allocation on the error paths that follow. > > Signed-off-by: Dave Jone

block: free q->flush_rq in blk_init_allocated_queue error paths.

2014-03-19 Thread Dave Jones
Commit 7982e90c3a ("block: fix q->flush_rq NULL pointer crash on dm-mpath flush") moved an allocation to blk_init_allocated_queue(), but neglected to free that allocation on the error paths that follow. Signed-off-by: Dave Jones diff --git a/block/blk-core.c b/block/blk-core.c index 4cd5ffc1844