[PATCH V4 13/15] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-10-24 Thread Reinette Chatre
The MBA test incrementally throttles memory bandwidth, each time followed by a comparison between the memory bandwidth observed by the performance counters and resctrl respectively. While a comparison between performance counters and resctrl is generally appropriate, they do not have an identical

[PATCH V3 13/15] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-10-17 Thread Reinette Chatre
The MBA test incrementally throttles memory bandwidth, each time followed by a comparison between the memory bandwidth observed by the performance counters and resctrl respectively. While a comparison between performance counters and resctrl is generally appropriate, they do not have an identical

Re: [PATCH V2 12/13] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-10-04 Thread Ilpo Järvinen
On Thu, 12 Sep 2024, Reinette Chatre wrote: > The MBA test incrementally throttles memory bandwidth, each time > followed by a comparison between the memory bandwidth observed > by the performance counters and resctrl respectively. > > While a comparison between performance count

[PATCH V2 12/13] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-12 Thread Reinette Chatre
The MBA test incrementally throttles memory bandwidth, each time followed by a comparison between the memory bandwidth observed by the performance counters and resctrl respectively. While a comparison between performance counters and resctrl is generally appropriate, they do not have an identical

Re: [PATCH 5/6] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-09 Thread Ilpo Järvinen
3 AM, Ilpo Järvinen wrote: > > > > > > On Fri, 30 Aug 2024, Reinette Chatre wrote: > > > > > > > On 8/30/24 4:42 AM, Ilpo Järvinen wrote: > > > > > > > > On Thu, 29 Aug 2024, Reinette Chatre wrote: > > > > > > > >

Re: [PATCH 5/6] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-06 Thread Reinette Chatre
Järvinen wrote: On Thu, 29 Aug 2024, Reinette Chatre wrote: The MBA test incrementally throttles memory bandwidth, each time followed by a comparison between the memory bandwidth observed by the performance counters and resctrl respectively. While a comparison between performance counters and resctrl

Re: [PATCH 5/6] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-06 Thread Ilpo Järvinen
4:42 AM, Ilpo Järvinen wrote: > > > > > > On Thu, 29 Aug 2024, Reinette Chatre wrote: > > > > > > > > > > > > > The MBA test incrementally throttles memory bandwidth, each time > > > > > > > follow

Re: [PATCH 5/6] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-05 Thread Reinette Chatre
throttles memory bandwidth, each time followed by a comparison between the memory bandwidth observed by the performance counters and resctrl respectively. While a comparison between performance counters and resctrl is generally appropriate, they do not have an identical view of memory bandwidth. For

Re: [PATCH 5/6] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-05 Thread Ilpo Järvinen
gt; > > The MBA test incrementally throttles memory bandwidth, each time > > > > > followed by a comparison between the memory bandwidth observed > > > > > by the performance counters and resctrl respectively. > > > > > > > > > >

Re: [PATCH 5/6] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-04 Thread Reinette Chatre
Hi Ilpo, On 9/4/24 4:43 AM, Ilpo Järvinen wrote: On Fri, 30 Aug 2024, Reinette Chatre wrote: On 8/30/24 4:42 AM, Ilpo Järvinen wrote: On Thu, 29 Aug 2024, Reinette Chatre wrote: The MBA test incrementally throttles memory bandwidth, each time followed by a comparison between the memory

Re: [PATCH 5/6] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-04 Thread Ilpo Järvinen
On Fri, 30 Aug 2024, Reinette Chatre wrote: > On 8/30/24 4:42 AM, Ilpo Järvinen wrote: > > On Thu, 29 Aug 2024, Reinette Chatre wrote: > > > > > The MBA test incrementally throttles memory bandwidth, each time > > > followed by a comparison between the memor

[PATCH 4/8] bfq: keep the minimun bandwidth for CLASS_BE

2021-04-20 Thread brookxu
From: Chunguang Xu CLASS_RT will preempt other classes, which may starve. At present, CLASS_IDLE has alleviated the starvation problem through the minimum bandwidth mechanism. Similarly, we should do the same for CLASS_BE. Signed-off-by: Chunguang Xu --- block/bfq-iosched.c | 6 -- block

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-04-19 Thread changhuaixin
have done some reading on queueing theory and done some problem definition. Divide real time into discrete periods as cfs_b does. Assume there are m cgroups using CFS Bandwidth Control. During each period, the i-th cgroup demands u_i CPU time, where we assume u_i is under some distribution(expo

[PATCH net-next 08/10] net: sparx5: add calendar bandwidth allocation support

2021-04-16 Thread Steen Hegelund
This configures the Sparx5 calendars according to the bandwidth requested in the Device Tree nodes. It also checks if the total requested bandwidth is within the specs of the detected Sparx5 models limits. Signed-off-by: Steen Hegelund Signed-off-by: Bjarni Jonasson Signed-off-by: Lars Povlsen

[PATCH] venus: helpers: keep max bandwidth when mbps exceeds the supported range

2021-03-31 Thread Vikash Garodia
When the video usecase have macro blocks per sec which is more than supported, keep the required bus bandwidth as the maximum supported. Signed-off-by: Vikash Garodia --- drivers/media/platform/qcom/venus/pm_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 2/2] usb: xhci-mtk: relax periodic TT bandwidth checking

2021-03-31 Thread Chunfeng Yun
On Tue, 2021-03-30 at 16:06 +0800, Ikjoon Jang wrote: > Software bandwidth checking logics used by xhci-mtk puts > a quite heavy constraints to TT periodic endpoint allocations. > > This patch provides a relaxed bandwidth calculation by > - Allowing multiple periodic transac

[PATCH next 1/2] usb: xhci-mtk: fix wrong remainder of bandwidth budget

2021-03-31 Thread Chunfeng Yun
The remainder of the last bandwidth bugdget is wrong, it's the value alloacted in last bugdget, not unused. Reported-by: Yaqii Wu Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk-sch.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhc

[PATCH 2/2] usb: xhci-mtk: relax periodic TT bandwidth checking

2021-03-30 Thread Ikjoon Jang
Software bandwidth checking logics used by xhci-mtk puts a quite heavy constraints to TT periodic endpoint allocations. This patch provides a relaxed bandwidth calculation by - Allowing multiple periodic transactions in a same microframe for a device with multiple interrupt endpoints. - Using

[PATCH 0/2] usb: xhci-mtk: relax peridoc TT bandwidth checking

2021-03-30 Thread Ikjoon Jang
This series is for supporting typical full speed USB audio headsets with speaker, microphone, and control knobs together. With current implementation, such a device cannot be configured due to xhci-mtk's bandwidth allocation failure even when there's enough bandwidth available. Ikjo

[PATCH v3 06/14] bfq: keep the minimun bandwidth for CLASS_BE

2021-03-24 Thread brookxu
From: Chunguang Xu CLASS_RT will preempt other classes, which may starve. At present, CLASS_IDLE has alleviated the starvation problem through the minimum bandwidth mechanism. Similarly, we should do the same for CLASS_BE. Signed-off-by: Chunguang Xu --- block/bfq-iosched.c | 6 -- block

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-19 Thread changhuaixin
ould suggest you pick your runtime around 200% >> to get that P95 and then allow a full period burst to get your P99, but >> that same RT theory would also have you calculate the resulting >> interference and see if that works with the rest of the system... >> > > I am

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-19 Thread changhuaixin
wrote: >>> >>>>> Why do you allow such a large burst? I would expect something like: >>>>> >>>>> if (burst > quote) >>>>> return -EINVAL; >>>>> >>>>> That limits the variance in the syst

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-19 Thread changhuaixin
27;t provide the desired calculation now. But I'd like to try and do some reading if that is needed. > 16 times is horrific. So can we decide on a more relative value now? Or is the interference probabilities still the missing piece? Is the paper you mentioned about called "Insensitivity results in statistical bandwidth sharing", or some related ones on statistical bandwidth results under some kind of fairness?

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-18 Thread Peter Zijlstra
On Thu, Mar 18, 2021 at 08:59:44AM -0400, Phil Auld wrote: > I admit to not having followed all the history of this patch set. That > said, when I see the above I just think your quota is too low for your > workload. This. > The burst (mis?)feature seems to be a way to bypass the quota. And it >

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-18 Thread Peter Zijlstra
On Thu, Mar 18, 2021 at 09:26:58AM +0800, changhuaixin wrote: > > On Mar 17, 2021, at 4:06 PM, Peter Zijlstra wrote: > > So what is the typical avg,stdev,max and mode for the workloads where you > > find > > you need this? > > > > I would really like to put a limit on the burst. IMO a workload

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-18 Thread Phil Auld
t something like: > >>> > >>> if (burst > quote) > >>> return -EINVAL; > >>> > >>> That limits the variance in the system. Allowing super long bursts seems > >>> to defeat the entire purpose of bandwidth contr

Re: [PATCH v16 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-18 Thread Dmitry Osipenko
18.03.2021 12:31, Michał Mirosław пишет: >> static const struct tegra_windowgroup_soc tegra194_dc_wgrps[] = { >> @@ -2430,6 +2781,7 @@ static const struct tegra_dc_soc_info >> tegra194_dc_soc_info = { >> .has_nvdisplay = true, >> .wgrps = tegra194_dc_wgrps, >> .num_wgrps = ARRAY_SI

Re: [PATCH v16 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-18 Thread Michał Mirosław
* See the comment related to !crtc->state->active above, > + * which explains why bandwidths need to be updated when > + * CRTC is turning ON. > + */ > + if (new_avg_bw == old_avg_bw && new_peak_bw == old_peak_bw

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-17 Thread changhuaixin
return -EINVAL; >>> >>> That limits the variance in the system. Allowing super long bursts seems >>> to defeat the entire purpose of bandwidth control. >> >> I understand your concern. Surely large burst value might allow super >> long bursts thus pre

[PATCH v16 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-17 Thread Dmitry Osipenko
Display controller (DC) performs isochronous memory transfers, and thus, has a requirement for a minimum memory bandwidth that shall be fulfilled, otherwise framebuffer data can't be fetched fast enough and this results in a DC's data-FIFO underflow that follows by a visual corruption.

[PATCH v16 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver

2021-03-17 Thread Dmitry Osipenko
This series adds memory bandwidth management to the NVIDIA Tegra DRM driver, which is done using interconnect framework. It fixes display corruption that happens due to insufficient memory bandwidth. Changelog: v16: - Implemented suggestions that were given by Michał Mirosław to v15

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-17 Thread Peter Zijlstra
per long bursts seems > > to defeat the entire purpose of bandwidth control. > > I understand your concern. Surely large burst value might allow super > long bursts thus preventing bandwidth control entirely for a long > time. > > However, I am afraid it is hard to decid

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-17 Thread changhuaixin
&& quota > max_cfs_runtime) >> return -EINVAL; >> >> +/* >> + * Bound burst to defend burst against overflow during bandwidth shift. >> + */ >> +if (burst > max_cfs_runtime) >> +return -EINVAL; > >

Re: [PATCH v15 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-16 Thread Dmitry Osipenko
negative impact on >>> +* other memory clients, hence we will request a higher bandwidth >>> +* since latency depends on bandwidth. This allows to prevent memory >>> +* FIFO underflows for a large plane downscales, meanwhile allowing >>

Re: [PATCH v3 2/4] sched/fair: Make CFS bandwidth controller burstable

2021-03-16 Thread Peter Zijlstra
On Fri, Mar 12, 2021 at 09:54:33PM +0800, changhuaixin wrote: > > On Mar 10, 2021, at 9:04 PM, Peter Zijlstra wrote: > > There's already an #ifdef block that contains that bandwidth_slice > > thing, see the previous hunk, so why create a new #ifdef here? > > > > Also, personally I think percenta

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-16 Thread Peter Zijlstra
_group *tg, u64 period, u64 runtime); @@ -8989,10 +8989,10 @@ static int tg_set_cfs_bandwidth(struct t if (quota != RUNTIME_INF && quota > max_cfs_runtime) return -EINVAL; - /* -* Bound burst to defend burst against overflow during bandwidth shift. -

Re: [PATCH 5.10 154/290] PCI/LINK: Remove bandwidth notification

2021-03-16 Thread Pavel Machek
Hi! > From: Greg Kroah-Hartman > > From: Bjorn Helgaas Dup. > Remove the bandwidth change notifications for now. Hopefully we can add > this back when we have a better understanding of why this happens and how > we can make the messages useful instead of overwhelming. T

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-16 Thread Peter Zijlstra
gt; + /* > + * Bound burst to defend burst against overflow during bandwidth shift. > + */ > + if (burst > max_cfs_runtime) > + return -EINVAL; Why do you allow such a large burst? I would expect something like: if (burst > quote)

Re: [PATCH v4 2/4] sched/fair: Make CFS bandwidth controller burstable

2021-03-16 Thread Peter Zijlstra
I can't make sense of patch 1 and 2 independent of one another. Why the split?

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-16 Thread Peter Zijlstra
On Tue, Mar 16, 2021 at 12:49:28PM +0800, Huaixin Chang wrote: > In this patch, we introduce the notion of CFS bandwidth burst. Unused > "quota" from pervious "periods" might be accumulated and used in the > following "periods". The maximum amount of accum

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-16 Thread Peter Zijlstra
On Tue, Mar 16, 2021 at 12:49:28PM +0800, Huaixin Chang wrote: > In this patch, we introduce the notion of CFS bandwidth burst. Unused Documentation/process/submitting-patches.rst:instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy

[PATCH v4 2/4] sched/fair: Make CFS bandwidth controller burstable

2021-03-15 Thread Huaixin Chang
Accumulate unused quota from previous periods, thus accumulated bandwidth runtime can be used in the following periods. During accumulation, take care of runtime overflow. Previous non-burstable CFS bandwidth controller only assign quota to runtime, that saves a lot. A sysctl parameter

[PATCH v4 3/4] sched/fair: Add cfs bandwidth burst statistics

2021-03-15 Thread Huaixin Chang
into cpu.stat file: nr_burst: number of periods bandwidth burst occurs burst_time: cumulative wall-time that any cpus has used above quota in respective periods Co-developed-by: Shanpei Chen Signed-off-by: Shanpei Chen Signed-off-by: Huaixin Chang --- kernel/sched/core.c | 14

[PATCH v4 4/4] sched/fair: Add document for burstable CFS bandwidth control

2021-03-15 Thread Huaixin Chang
Basic description of usage and effect for CFS Bandwidth Control Burst. Co-developed-by: Shanpei Chen Signed-off-by: Shanpei Chen Signed-off-by: Huaixin Chang --- Documentation/admin-guide/cgroup-v2.rst | 16 + Documentation/scheduler/sched-bwc.rst | 64

[PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-15 Thread Huaixin Chang
In this patch, we introduce the notion of CFS bandwidth burst. Unused "quota" from pervious "periods" might be accumulated and used in the following "periods". The maximum amount of accumulated bandwidth is bounded by "burst". And the maximun amount of CPU

[PATCH v4 0/4] sched/fair: Burstable CFS bandwidth controller

2021-03-15 Thread Huaixin Chang
Changelog: v4: - Adjust assignments in tg_set_cfs_bandwidth(), saving unnecessary assignemnts when quota == RUNTIME_INF. - Getting rid of sysctl_sched_cfs_bw_burst_onset_percent, as there seems no justification for both controlling start bandwidth and a percent way. - Comment improvement in

Re: [PATCH v15 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-15 Thread Dmitry Osipenko
15.03.2021 01:31, Michał Mirosław пишет: > On Thu, Mar 11, 2021 at 08:22:54PM +0300, Dmitry Osipenko wrote: >> Display controller (DC) performs isochronous memory transfers, and thus, >> has a requirement for a minimum memory bandwidth that shall be fulfilled, >> otherwise f

[PATCH 5.11 150/306] PCI/LINK: Remove bandwidth notification

2021-03-15 Thread gregkh
From: Greg Kroah-Hartman From: Bjorn Helgaas [ Upstream commit b4c7d2076b4e767dd2e075a2b3a9e57753fc67f5 ] The PCIe Bandwidth Change Notification feature logs messages when the link bandwidth changes. Some users have reported that these messages occur often enough to significantly reduce NVMe

[PATCH 5.10 154/290] PCI/LINK: Remove bandwidth notification

2021-03-15 Thread gregkh
From: Greg Kroah-Hartman From: Bjorn Helgaas [ Upstream commit b4c7d2076b4e767dd2e075a2b3a9e57753fc67f5 ] The PCIe Bandwidth Change Notification feature logs messages when the link bandwidth changes. Some users have reported that these messages occur often enough to significantly reduce NVMe

Re: [PATCH v15 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-14 Thread Michał Mirosław
On Thu, Mar 11, 2021 at 08:22:54PM +0300, Dmitry Osipenko wrote: > Display controller (DC) performs isochronous memory transfers, and thus, > has a requirement for a minimum memory bandwidth that shall be fulfilled, > otherwise framebuffer data can't be fetched fast enough and this

Re: [PATCH v3 2/4] sched/fair: Make CFS bandwidth controller burstable

2021-03-12 Thread changhuaixin
> On Mar 10, 2021, at 9:04 PM, Peter Zijlstra wrote: > > On Thu, Jan 21, 2021 at 07:04:51PM +0800, Huaixin Chang wrote: >> Accumulate unused quota from previous periods, thus accumulated >> bandwidth runtime can be used in the following periods. During >> accumul

Re: [PATCH v3 0/4] sched/fair: Burstable CFS bandwidth controller

2021-03-12 Thread changhuaixin
> On Mar 10, 2021, at 7:11 PM, Odin Ugedal wrote: > > Hi, > >> If there are cases where the "start bandwidth" matters, I think there is >> need to expose the >> "start bandwidth" explicitly too. However, I doubt the existence of such &

[RFC PATCH v2 05/11] bfq: keep the minimun bandwidth for be_class

2021-03-12 Thread brookxu
From: Chunguang Xu rt_class will preempt other classes, which may cause other classes to starve to death. At present, idle_class has alleviated the starvation problem through the minimum bandwidth mechanism. Similarly, we should do the same for be_class. Signed-off-by: Chunguang Xu --- block

[PATCH v15 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver

2021-03-11 Thread Dmitry Osipenko
This series adds memory bandwidth management to the NVIDIA Tegra DRM driver, which is done using interconnect framework. It fixes display corruption that happens due to insufficient memory bandwidth. Changelog: v15: - Corrected tegra_plane_icc_names[] NULL-check that was partially lost by

[PATCH v15 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-11 Thread Dmitry Osipenko
Display controller (DC) performs isochronous memory transfers, and thus, has a requirement for a minimum memory bandwidth that shall be fulfilled, otherwise framebuffer data can't be fetched fast enough and this results in a DC's data-FIFO underflow that follows by a visual corruption.

Re: [PATCH v14 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-11 Thread Dmitry Osipenko
11.03.2021 20:06, Dmitry Osipenko пишет: > +static const char * const tegra_plane_icc_names[TEGRA_DC_LEGACY_PLANES_NUM] > = { > + "wina", "winb", "winc", "", "", "", "cursor", > +}; > + > +int tegra_plane_interconnect_init(struct tegra_plane *plane) > +{ > + const char *icc_name = tegra_pl

Re: [PATCH v14 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver

2021-03-11 Thread Dmitry Osipenko
11.03.2021 20:06, Dmitry Osipenko пишет: > This series adds memory bandwidth management to the NVIDIA Tegra DRM driver, > which is done using interconnect framework. It fixes display corruption that > happens due to insufficient memory bandwidth. > > Changelog: > > v14: - M

[PATCH v14 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-11 Thread Dmitry Osipenko
Display controller (DC) performs isochronous memory transfers, and thus, has a requirement for a minimum memory bandwidth that shall be fulfilled, otherwise framebuffer data can't be fetched fast enough and this results in a DC's data-FIFO underflow that follows by a visual corruption.

[PATCH v14 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver

2021-03-11 Thread Dmitry Osipenko
This series adds memory bandwidth management to the NVIDIA Tegra DRM driver, which is done using interconnect framework. It fixes display corruption that happens due to insufficient memory bandwidth. Changelog: v14: - Made improvements that were suggested by Michał Mirosław to v13

Re: [PATCH v3 4/4] sched/fair: Add document for burstable CFS bandwidth control

2021-03-10 Thread Peter Zijlstra
On Thu, Jan 21, 2021 at 07:04:53PM +0800, Huaixin Chang wrote: > Basic description of usage and effect for CFS Bandwidth Control Burst. > > Signed-off-by: Huaixin Chang > Signed-off-by: Shanpei Chen Guess :-) > +Sometimes users might want a group to burst without accumu

Re: [PATCH v3 3/4] sched/fair: Add cfs bandwidth burst statistics

2021-03-10 Thread Peter Zijlstra
On Thu, Jan 21, 2021 at 07:04:52PM +0800, Huaixin Chang wrote: > Introduce statistics exports for the burstable cfs bandwidth > controller. > > The following exports are included: > > current_bw: current runtime in global pool > nr_burst: number of periods bandwidth burs

Re: [PATCH v3 2/4] sched/fair: Make CFS bandwidth controller burstable

2021-03-10 Thread Peter Zijlstra
On Thu, Jan 21, 2021 at 07:04:51PM +0800, Huaixin Chang wrote: > Accumulate unused quota from previous periods, thus accumulated > bandwidth runtime can be used in the following periods. During > accumulation, take care of runtime overflow. Previous non-burstable > CFS bandwidth con

Re: [PATCH v3 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-10 Thread Peter Zijlstra
On Thu, Jan 21, 2021 at 07:04:50PM +0800, Huaixin Chang wrote: > In this patch, we introduce the notion of CFS bandwidth burst. Unused > "quota" from pervious "periods" might be accumulated and used in the > following "periods". The maximum amount of accum

Re: [PATCH v3 0/4] sched/fair: Burstable CFS bandwidth controller

2021-03-10 Thread Peter Zijlstra
On Tue, Jan 26, 2021 at 06:18:59PM +0800, changhuaixin wrote: > Ping, any new comments on this patchset? If there're no other > concerns, I think it's ready to be merged? I only found this by accident... Thread got lost because you're posting new series as replies to older series. Please don't do

Re: [PATCH v3 0/4] sched/fair: Burstable CFS bandwidth controller

2021-03-10 Thread Odin Ugedal
Hi, > If there are cases where the "start bandwidth" matters, I think there is need > to expose the > "start bandwidth" explicitly too. However, I doubt the existence of such > cases from my view > and the two examples above. Yeah, I don't think the

Re: [PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-08 Thread Dmitry Osipenko
ous memory transfers, and thus, >>>> has a requirement for a minimum memory bandwidth that shall be fulfilled, >>>> otherwise framebuffer data can't be fetched fast enough and this results >>>> in a DC's data-FIFO underflow that follows by a visua

[RFC PATCH 3/8] bfq: keep the minimun bandwidth for be_class

2021-03-08 Thread brookxu
From: Chunguang Xu From: Chunguang Xu rt_class will preempt other classes, which may cause other classes to starve to death. At present, idle_class has alleviated the starvation problem through the minimum bandwidth mechanism. Similarly, we should do the same for be_class. Signed-off-by

[PATCH v2 06/18] usb: xhci-mtk: add a function to (un)load bandwidth info

2021-03-07 Thread Chunfeng Yun
Extract a function to load/unload bandwidth info, and remove a dummy check of TT offset. Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/host/xhci-mtk-sch.c | 37 ++--- 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/drivers/usb/host

[PATCH v2 12/18] usb: xhci-mtk: rebuild the way to get bandwidth domain

2021-03-07 Thread Chunfeng Yun
Rebuild the function get_bw_index(), get the bandwidth domain directly instead its index of domain array. Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/host/xhci-mtk-sch.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a

[PATCH v2 02/18] usb: xhci-mtk: improve bandwidth scheduling with TT

2021-03-07 Thread Chunfeng Yun
When the USB headset is plug into an external hub, sometimes can't set config due to not enough bandwidth, so need improve LS/FS INT/ISOC bandwidth scheduling with TT. Fixes: 54f6a8af3722 ("usb: xhci-mtk: skip dropping bandwidth of unchecked endpoints") Cc: stable Signed-o

[PATCH v2 07/18] usb: xhci-mtk: add a function to get bandwidth boundary

2021-03-07 Thread Chunfeng Yun
= HS_BW_BOUNDARY; + break; + } + + return boundary; +} + /* * get the index of bandwidth domains array which @ep belongs to. * @@ -579,13 +598,7 @@ static int check_sch_bw(struct usb_device *udev, break; } - if (udev->sp

Re: [PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-05 Thread Michał Mirosław
rement for a minimum memory bandwidth that shall be fulfilled, > >> otherwise framebuffer data can't be fetched fast enough and this results > >> in a DC's data-FIFO underflow that follows by a visual corruption. [...] > >> + /* > >> + * Horizonta

[PATCH 12/17] usb: xhci-mtk: rebuild the way to get bandwidth domain

2021-03-05 Thread Chunfeng Yun
Rebuild the function get_bw_index(), get the bandwidth domain directly instead its index of domain array. Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk-sch.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers/usb/host/xhci-mtk

[PATCH 06/17] usb: xhci-mtk: add a function to (un)load bandwidth info

2021-03-05 Thread Chunfeng Yun
Extract a function to load/unload bandwidth info, and remove a dummy check of TT offset. Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk-sch.c | 37 ++--- 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/drivers/usb/host/xhci-mtk-sch.c b

[PATCH 02/17] usb: xhci-mtk: improve bandwidth scheduling with TT

2021-03-05 Thread Chunfeng Yun
When the USB headset is plug into an external hub, sometimes can't set config due to not enough bandwidth, so need improve LS/FS INT/ISOC bandwidth scheduling with TT. Fixes: 54f6a8af3722 ("usb: xhci-mtk: skip dropping bandwidth of unchecked endpoints") Cc: stable Signed-o

[PATCH 07/17] usb: xhci-mtk: add a function to get bandwidth boundary

2021-03-05 Thread Chunfeng Yun
; + break; + } + + return boundary; +} + /* * get the index of bandwidth domains array which @ep belongs to. * @@ -579,13 +598,7 @@ static int check_sch_bw(struct usb_device *udev, break; } - if (udev->speed == USB_SPEED_SUPER_P

Re: [PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-04 Thread Dmitry Osipenko
04.03.2021 02:08, Michał Mirosław пишет: > On Tue, Mar 02, 2021 at 03:44:44PM +0300, Dmitry Osipenko wrote: >> Display controller (DC) performs isochronous memory transfers, and thus, >> has a requirement for a minimum memory bandwidth that shall be fulfilled, >> otherwise f

Re: [PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-03 Thread Michał Mirosław
On Tue, Mar 02, 2021 at 03:44:44PM +0300, Dmitry Osipenko wrote: > Display controller (DC) performs isochronous memory transfers, and thus, > has a requirement for a minimum memory bandwidth that shall be fulfilled, > otherwise framebuffer data can't be fetched fast enough and this

[PATCH v13 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver

2021-03-02 Thread Dmitry Osipenko
This series adds memory bandwidth management to the NVIDIA Tegra DRM driver, which is done using interconnect framework. It fixes display corruption that happens due to insufficient memory bandwidth. Tegra memory drivers already got the interconnect API support and DRM patches were a part of the

[PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-02 Thread Dmitry Osipenko
Display controller (DC) performs isochronous memory transfers, and thus, has a requirement for a minimum memory bandwidth that shall be fulfilled, otherwise framebuffer data can't be fetched fast enough and this results in a DC's data-FIFO underflow that follows by a visual corruption.

[PATCH AUTOSEL 5.10 33/47] PCI/LINK: Remove bandwidth notification

2021-03-02 Thread Sasha Levin
From: Bjorn Helgaas [ Upstream commit b4c7d2076b4e767dd2e075a2b3a9e57753fc67f5 ] The PCIe Bandwidth Change Notification feature logs messages when the link bandwidth changes. Some users have reported that these messages occur often enough to significantly reduce NVMe performance. GPUs also

[PATCH AUTOSEL 5.11 37/52] PCI/LINK: Remove bandwidth notification

2021-03-02 Thread Sasha Levin
From: Bjorn Helgaas [ Upstream commit b4c7d2076b4e767dd2e075a2b3a9e57753fc67f5 ] The PCIe Bandwidth Change Notification feature logs messages when the link bandwidth changes. Some users have reported that these messages occur often enough to significantly reduce NVMe performance. GPUs also

Re: [PATCH v3 0/4] sched/fair: Burstable CFS bandwidth controller

2021-02-27 Thread changhuaixin
= do_div(burst, 100) * >> +sysctl_sched_cfs_bw_burst_onset_percent; >> + >> +cfs_b->runtime += burst_onset; >> +cfs_b->runtime = min(max_cfs_runtime, cfs_b->runtime); >> +} > > I saw a comment about this behav

Re: [RFC v4 PATCH] usb: xhci-mtk: improve bandwidth scheduling with TT

2021-02-21 Thread Ikjoon Jang
On Mon, Feb 8, 2021 at 11:27 AM Chunfeng Yun wrote: > > When the USB headset is plug into an external hub, sometimes > can't set config due to not enough bandwidth, so need improve > LS/FS INT/ISOC bandwidth scheduling with TT. > > Fixes: 08e469de87a2 ("usb:

Re: [PATCH v3 0/4] sched/fair: Burstable CFS bandwidth controller

2021-02-09 Thread Tejun Heo
. Given that it's mostly straight forward extension on an existing interface, things looks fine from cgroup side; however, please do add cgroup2 interface and documentation. One thing which has bene bothersome about the bandwidth interface is that we're exposing implementation details (win

Re: [PATCH v3 0/4] sched/fair: Burstable CFS bandwidth controller

2021-02-09 Thread Odin Ugedal
cfs_b->runtime = min(max_cfs_runtime, cfs_b->runtime); > + } I saw a comment about this behavior, but I think this can lead to a bit of confusion. If sysctl_sched_cfs_bw_burst_onset_percent=0, the amount of bandwidth when the first process starts up will depend on the time between

[PATCH 5.10 011/120] usb: xhci-mtk: fix unreleased bandwidth data

2021-02-08 Thread Greg Kroah-Hartman
From: Ikjoon Jang commit 1d69f9d901ef14d81c3b004e3282b8cc7b456280 upstream. xhci-mtk needs XHCI_MTK_HOST quirk functions in add_endpoint() and drop_endpoint() to handle its own sw bandwidth management. It stores bandwidth data into an internal table every time add_endpoint() is called, and

[PATCH 5.10 012/120] usb: xhci-mtk: skip dropping bandwidth of unchecked endpoints

2021-02-08 Thread Greg Kroah-Hartman
From: Chunfeng Yun commit 54f6a8af372213a254af6609758d99f7c0b6b5ad upstream. For those unchecked endpoints, we don't allocate bandwidth for them, so no need free the bandwidth, otherwise will decrease the allocated bandwidth. Meanwhile use xhci_dbg() instead of dev_dbg() to print log

[PATCH 5.4 29/65] usb: xhci-mtk: skip dropping bandwidth of unchecked endpoints

2021-02-08 Thread Greg Kroah-Hartman
From: Chunfeng Yun commit 54f6a8af372213a254af6609758d99f7c0b6b5ad upstream. For those unchecked endpoints, we don't allocate bandwidth for them, so no need free the bandwidth, otherwise will decrease the allocated bandwidth. Meanwhile use xhci_dbg() instead of dev_dbg() to print log

[PATCH 5.4 28/65] usb: xhci-mtk: fix unreleased bandwidth data

2021-02-08 Thread Greg Kroah-Hartman
From: Ikjoon Jang commit 1d69f9d901ef14d81c3b004e3282b8cc7b456280 upstream. xhci-mtk needs XHCI_MTK_HOST quirk functions in add_endpoint() and drop_endpoint() to handle its own sw bandwidth management. It stores bandwidth data into an internal table every time add_endpoint() is called, and

[RFC v4 PATCH] usb: xhci-mtk: improve bandwidth scheduling with TT

2021-02-07 Thread Chunfeng Yun
When the USB headset is plug into an external hub, sometimes can't set config due to not enough bandwidth, so need improve LS/FS INT/ISOC bandwidth scheduling with TT. Fixes: 08e469de87a2 ("usb: xhci-mtk: supports bandwidth scheduling with multi-TT") Signed-off-by: Yaqii Wu

Re: [PATCH] perf test: Add parse-metric memory bandwidth testcase

2021-02-02 Thread Namhyung Kim
> static int test_metric_group(void) > { > double ratio1, ratio2; > @@ -353,5 +376,6 @@ int test__parse_metric(struct test *test __maybe_unused, > int subtest __maybe_unu > TEST_ASSERT_VAL("DCache_L2 failed", test_dcache_l2() == 0); > TEST_ASSERT_VAL("recursion fail failed", test_recursion_fail() == 0); > TEST_ASSERT_VAL("test metric group", test_metric_group() == 0); > + TEST_ASSERT_VAL("Memory bandwidth", test_memory_bandwidth() == 0); > return 0; > } > -- > 2.26.2 >

[PATCH] PCI/LINK: Remove bandwidth notification

2021-02-02 Thread Bjorn Helgaas
From: Bjorn Helgaas The PCIe Bandwidth Change Notification feature logs messages when the link bandwidth changes. Some users have reported that these messages occur often enough to significantly reduce NVMe performance. GPUs also seem to generate these messages. We don't know why the

Re: Issues with "PCI/LINK: Report degraded links via link bandwidth notification"

2021-02-02 Thread Alex G.
thread petered out with no resolution. If the bandwidth change notifications are important to somebody, please speak up, preferably with a patch that makes the notifications disabled by default and adds a parameter to enable them (or some other strategy that makes sense). I think these are

Re: Issues with "PCI/LINK: Report degraded links via link bandwidth notification"

2021-02-02 Thread Bjorn Helgaas
gt; > > AFAICT, this thread petered out with no resolution. > > > > > > > > > > If the bandwidth change notifications are important to somebody, > > > > > please speak up, preferably with a patch that makes the notifications > > > >

Re: Issues with "PCI/LINK: Report degraded links via link bandwidth notification"

2021-02-02 Thread Alex G.
On 1/29/21 3:56 PM, Bjorn Helgaas wrote: On Thu, Jan 28, 2021 at 06:07:36PM -0600, Alex G. wrote: On 1/28/21 5:51 PM, Sinan Kaya wrote: On 1/28/2021 6:39 PM, Bjorn Helgaas wrote: AFAICT, this thread petered out with no resolution. If the bandwidth change notifications are important to

[PATCH 4/4] sched/fair: Add document for burstable CFS bandwidth control

2021-02-02 Thread Huaixin Chang
Basic description of usage and effect for CFS Bandwidth Control Burst. Signed-off-by: Huaixin Chang Signed-off-by: Shanpei Chen --- Documentation/scheduler/sched-bwc.rst | 70 +-- 1 file changed, 66 insertions(+), 4 deletions(-) diff --git a/Documentation

[PATCH 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-02-02 Thread Huaixin Chang
In this patch, we introduce the notion of CFS bandwidth burst. Unused "quota" from pervious "periods" might be accumulated and used in the following "periods". The maximum amount of accumulated bandwidth is bounded by "burst". And the maximun amount of CPU

[PATCH 3/4] sched/fair: Add cfs bandwidth burst statistics

2021-02-02 Thread Huaixin Chang
Introduce statistics exports for the burstable cfs bandwidth controller. The following exports are included: current_bw: current runtime in global pool nr_burst: number of periods bandwidth burst occurs burst_time: cumulative wall-time that any cpus has used above quota in

[PATCH 2/4] sched/fair: Make CFS bandwidth controller burstable

2021-02-02 Thread Huaixin Chang
Accumulate unused quota from previous periods, thus accumulated bandwidth runtime can be used in the following periods. During accumulation, take care of runtime overflow. Previous non-burstable CFS bandwidth controller only assign quota to runtime, that saves a lot. A sysctl parameter

  1   2   3   4   5   6   7   8   9   10   >