Re: asm-x86/byteorder.h: clean up for userspace

2008-01-01 Thread H. Peter Anvin
Adrian Bunk wrote: Userspace either has to #define CONFIG_X86_BSWAP or it'll get the slow versions of these functions... Leaking CONFIG_ variables to userspace is not really funny - I remember e.g. what tricks MySQL does (did?) for (ab)using asm-i386/atomic.h in userspace. True. CONFIG

Re: asm-x86/byteorder.h: clean up for userspace

2008-01-01 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 01:19:42PM -0800, H. Peter Anvin wrote: > Christoph Hellwig wrote: >> On Mon, Dec 31, 2007 at 01:12:45PM -0500, Mike Frysinger wrote: >>> Since asm-x86/byteorder.h is exported to userspace, use __asm__ rather than >>> asm in its code. >> >> The correct fix is to not export i

Re: asm-x86/byteorder.h: clean up for userspace

2008-01-01 Thread H. Peter Anvin
Christoph Hellwig wrote: On Mon, Dec 31, 2007 at 01:12:45PM -0500, Mike Frysinger wrote: Since asm-x86/byteorder.h is exported to userspace, use __asm__ rather than asm in its code. The correct fix is to not export it to userspace. Unfortunately, it's historically been provided, for over 15

Re: asm-x86/byteorder.h: clean up for userspace

2008-01-01 Thread Mike Frysinger
On Tuesday 01 January 2008, Christoph Hellwig wrote: > On Mon, Dec 31, 2007 at 01:12:45PM -0500, Mike Frysinger wrote: > > Since asm-x86/byteorder.h is exported to userspace, use __asm__ rather > > than asm in its code. > > The correct fix is to not export it to userspace. which is what people com

Re: asm-x86/byteorder.h: clean up for userspace

2008-01-01 Thread Christoph Hellwig
On Mon, Dec 31, 2007 at 01:12:45PM -0500, Mike Frysinger wrote: > Since asm-x86/byteorder.h is exported to userspace, use __asm__ rather than > asm in its code. The correct fix is to not export it to userspace. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: asm-x86/byteorder.h: clean up for userspace

2008-01-01 Thread Ingo Molnar
* Mike Frysinger <[EMAIL PROTECTED]> wrote: > Since asm-x86/byteorder.h is exported to userspace, use __asm__ rather > than asm in its code. thanks Mike, i have applied your patch to x86.git - as a fix to be pushed into 2.6.24. Ingo -- To unsubscribe from this list: send the line "uns

asm-x86/byteorder.h: clean up for userspace

2007-12-31 Thread Mike Frysinger
Since asm-x86/byteorder.h is exported to userspace, use __asm__ rather than asm in its code. Signed-Off-By: Mike Frysinger <[EMAIL PROTECTED]> --- diff --git a/include/asm-x86/byteorder.h b/include/asm-x86/byteorder.h index 1f2d6d5..fe2f2e5 100644 --- a/include/asm-x86/byteorder.h +++ b/include/as