Re: [PATCH v2] arm64: Fix the kernel panic() on QDF2400 platform

2017-02-23 Thread Shanker Donthineni
Hi Timur, On 02/23/2017 03:11 PM, Timur Tabi wrote: On 02/23/2017 03:05 PM, Shanker Donthineni wrote: Why do you want keep 'pre_ttbr0_update_workaround' in subject, nothing wrong with macro definition itself. Problem with the caller, not passing the right arguments. Ok, how about this: arm6

Re: [PATCH v2] arm64: Fix the kernel panic() on QDF2400 platform

2017-02-23 Thread Timur Tabi
On 02/23/2017 03:05 PM, Shanker Donthineni wrote: Why do you want keep 'pre_ttbr0_update_workaround' in subject, nothing wrong with macro definition itself. Problem with the caller, not passing the right arguments. Ok, how about this: arm64: qcom: do not use x1 when calling pre_ttbr0_update_wo

Re: [PATCH v2] arm64: Fix the kernel panic() on QDF2400 platform

2017-02-23 Thread Shanker Donthineni
On 02/23/2017 02:46 PM, Timur Tabi wrote: On 02/23/2017 02:02 PM, Shanker Donthineni wrote: The commit 38fd94b0275c 'arm64: Work around Falkor erratum 1003' has been added to fix the hardware bug but causing a system crash. The "causes" value of the register x1 which contains 'struct mm_st

Re: [PATCH v2] arm64: Fix the kernel panic() on QDF2400 platform

2017-02-23 Thread Timur Tabi
On 02/23/2017 02:02 PM, Shanker Donthineni wrote: The commit 38fd94b0275c 'arm64: Work around Falkor erratum 1003' has been added to fix the hardware bug but causing a system crash. The "causes" value of the register x1 which contains 'struct mm_struct *' should be preserved inside macro pre_

[PATCH v2] arm64: Fix the kernel panic() on QDF2400 platform

2017-02-23 Thread Shanker Donthineni
The commit 38fd94b0275c 'arm64: Work around Falkor erratum 1003' has been added to fix the hardware bug but causing a system crash. The value of the register x1 which contains 'struct mm_struct *' should be preserved inside macro pre_ttbr0_update_workaround. Macro pre_ttbr0_update_workaround expec

Re: [PATCH] arm64: Fix the kernel panic() on QDF2400 platform

2017-02-23 Thread Timur Tabi
On Thu, Feb 23, 2017 at 8:45 AM, Will Deacon wrote: > > Whilst I'm pleased that you've sent a fix (and I'll pick it up), I have > to ask... did anybody actually test the original patch? If so, why wasn't > this found earlier? First, Shanker's going to post a V2 with an improved patch description.

Re: arm64: Fix the kernel panic() on QDF2400 platform

2017-02-23 Thread Manoj Iyer
Tested on Ubuntu 17.04 (Linux 4.10). I am able to boot the kernel on QDF2400 platform without any panics. Tested-by: Manoj Iyer -- Manoj Iyer Ubuntu/Canonical ARM Servers - Cloud On Wed, 22 Feb 2017, Shanker Donthineni wrote: The c

Re: [PATCH] arm64: Fix the kernel panic() on QDF2400 platform

2017-02-23 Thread Will Deacon
On Wed, Feb 22, 2017 at 09:10:48PM -0600, Shanker Donthineni wrote: > The commit 38fd94b0 'arm64: Work around Falkor erratum 1003' has > been added to fix the hardware bug but causing a system crash. > The value of the register x1 which contains 'struct mm_struct *' > should be preserved inside mac

[PATCH] arm64: Fix the kernel panic() on QDF2400 platform

2017-02-22 Thread Shanker Donthineni
The commit 38fd94b0 'arm64: Work around Falkor erratum 1003' has been added to fix the hardware bug but causing a system crash. The value of the register x1 which contains 'struct mm_struct *' should be preserved inside macro pre_ttbr0_update_workaround. Macro pre_ttbr0_update_workaround expects 2