Re: arm64/acpi: NULL dereference reports from UBSAN at boot

2020-06-01 Thread Ard Biesheuvel
On Tue, 2 Jun 2020 at 00:19, Nick Desaulniers wrote: > > On Mon, Jun 1, 2020 at 2:57 PM Ard Biesheuvel wrote: > > > > On Mon, 1 Jun 2020 at 23:52, Nick Desaulniers > > wrote: > > > > > > Anyways, it looks like the address of member from NULL subexpression > > > looks problematic. I wonder if o

Re: arm64/acpi: NULL dereference reports from UBSAN at boot

2020-06-01 Thread Nick Desaulniers
On Mon, Jun 1, 2020 at 2:57 PM Ard Biesheuvel wrote: > > On Mon, 1 Jun 2020 at 23:52, Nick Desaulniers wrote: > > > > Anyways, it looks like the address of member from NULL subexpression > > looks problematic. I wonder if offsetof can be used here? > > > > #define ACPI_OFFSET(d, f) ACPI_PTR_DIFF

Re: arm64/acpi: NULL dereference reports from UBSAN at boot

2020-06-01 Thread Ard Biesheuvel
On Mon, 1 Jun 2020 at 23:52, Nick Desaulniers wrote: > > On Mon, Jun 1, 2020 at 12:05 AM Will Deacon wrote: > > > > On Wed, May 27, 2020 at 02:41:04PM +0100, Lorenzo Pieralisi wrote: > > > On Tue, May 26, 2020 at 09:21:57PM +0100, Will Deacon wrote: > > > > Hi Lorenzo, Hanjun, [+Nick] > > > > > >

Re: arm64/acpi: NULL dereference reports from UBSAN at boot

2020-06-01 Thread Nick Desaulniers
On Mon, Jun 1, 2020 at 12:05 AM Will Deacon wrote: > > On Wed, May 27, 2020 at 02:41:04PM +0100, Lorenzo Pieralisi wrote: > > On Tue, May 26, 2020 at 09:21:57PM +0100, Will Deacon wrote: > > > Hi Lorenzo, Hanjun, [+Nick] > > > > > > On Thu, May 21, 2020 at 06:37:38PM +0100, Lorenzo Pieralisi wrote

Re: arm64/acpi: NULL dereference reports from UBSAN at boot

2020-06-01 Thread Will Deacon
On Wed, May 27, 2020 at 02:41:04PM +0100, Lorenzo Pieralisi wrote: > On Tue, May 26, 2020 at 09:21:57PM +0100, Will Deacon wrote: > > Hi Lorenzo, Hanjun, [+Nick] > > > > On Thu, May 21, 2020 at 06:37:38PM +0100, Lorenzo Pieralisi wrote: > > > On Thu, May 21, 2020 at 11:09:53AM +0100, Will Deacon w

Re: arm64/acpi: NULL dereference reports from UBSAN at boot

2020-05-27 Thread Lorenzo Pieralisi
On Tue, May 26, 2020 at 09:21:57PM +0100, Will Deacon wrote: > Hi Lorenzo, Hanjun, [+Nick] > > On Thu, May 21, 2020 at 06:37:38PM +0100, Lorenzo Pieralisi wrote: > > On Thu, May 21, 2020 at 11:09:53AM +0100, Will Deacon wrote: > > > Hi folks, > > > > > > I just tried booting the arm64 for-kernelc

Re: arm64/acpi: NULL dereference reports from UBSAN at boot

2020-05-26 Thread Will Deacon
Hi Lorenzo, Hanjun, [+Nick] On Thu, May 21, 2020 at 06:37:38PM +0100, Lorenzo Pieralisi wrote: > On Thu, May 21, 2020 at 11:09:53AM +0100, Will Deacon wrote: > > Hi folks, > > > > I just tried booting the arm64 for-kernelci branch under QEMU (version > > 4.2.50 (v4.2.0-779-g4354edb6dcc7)) with UB

Re: arm64/acpi: NULL dereference reports from UBSAN at boot

2020-05-22 Thread Hanjun Guo
On 2020/5/22 16:07, Hanjun Guo wrote: Hi Will, On 2020/5/21 18:09, Will Deacon wrote: Hi folks, I just tried booting the arm64 for-kernelci branch under QEMU (version 4.2.50 (v4.2.0-779-g4354edb6dcc7)) with UBSAN enabled, and I see a couple of NULL pointer dereferences reported at boot. I thin

Re: arm64/acpi: NULL dereference reports from UBSAN at boot

2020-05-22 Thread Hanjun Guo
Hi Will, On 2020/5/21 18:09, Will Deacon wrote: Hi folks, I just tried booting the arm64 for-kernelci branch under QEMU (version 4.2.50 (v4.2.0-779-g4354edb6dcc7)) with UBSAN enabled, and I see a couple of NULL pointer dereferences reported at boot. I think they're both GIC related (log below).

Re: arm64/acpi: NULL dereference reports from UBSAN at boot

2020-05-21 Thread Lorenzo Pieralisi
On Thu, May 21, 2020 at 11:09:53AM +0100, Will Deacon wrote: > Hi folks, > > I just tried booting the arm64 for-kernelci branch under QEMU (version > 4.2.50 (v4.2.0-779-g4354edb6dcc7)) with UBSAN enabled, and I see a > couple of NULL pointer dereferences reported at boot. I think they're > both GI

arm64/acpi: NULL dereference reports from UBSAN at boot

2020-05-21 Thread Will Deacon
Hi folks, I just tried booting the arm64 for-kernelci branch under QEMU (version 4.2.50 (v4.2.0-779-g4354edb6dcc7)) with UBSAN enabled, and I see a couple of NULL pointer dereferences reported at boot. I think they're both GIC related (log below). I don't see a panic with UBSAN disabled, so someth