Re: add page argument to copy/clear_user_page

2001-05-23 Thread Paul Mackerras
Linus Torvalds writes: > > As for the `to' argument, yes it is redundant since it is just kmap(page). > > And why not let "clear_page()" just do that itself? OK, here's a patch that does that. > The thing is, copy/clear_page shouldn't exist at all (or rather, the > "highpage" versions should b

Re: add page argument to copy/clear_user_page

2001-05-22 Thread Linus Torvalds
On Mon, 21 May 2001, Paul Mackerras wrote: > > As for the `to' argument, yes it is redundant since it is just kmap(page). And why not let "clear_page()" just do that itself? The only place that doesn't already do "kmap(page)" is basically get_zeroed_page(), and the only reason it doesn't do th

Re: add page argument to copy/clear_user_page

2001-05-20 Thread Paul Mackerras
Linus Torvalds writes: > If you add the page argument, why leave the old arguments lingering there > at all? They only create confusion, and add no information. You mean the `to' pointer argument, or the `vaddr' argument? The `vaddr' argument isn't redundant, it's the user virtual address wher

Re: add page argument to copy/clear_user_page

2001-05-20 Thread Linus Torvalds
On Sun, 20 May 2001, Paul Mackerras wrote: > > The patch below adds a page * argument to copy_user_page and > clear_user_page. If you add the page argument, why leave the old arguments lingering there at all? They only create confusion, and add no information. Linus - To unsu

add page argument to copy/clear_user_page

2001-05-20 Thread Paul Mackerras
Linus, The patch below adds a page * argument to copy_user_page and clear_user_page. These functions are used only in include/linux/highmem.h to implement clear_user_highpage and copy_user_highpage. The idea is to pass in the pointer to the page struct for the destination page so that, on archi