On Tue, 2021-04-13 at 00:45 -0500, Gustavo A. R. Silva wrote:
> Hi Martin,
>
> On 4/12/21 23:52, Martin K. Petersen wrote:
>
> > Silencing analyzer warnings shouldn't be done at the expense of
> > human
> > readers. If it is imperative to switch to flex_array_size() to
> > quiesce
> > checker war
Hi Martin,
On 4/12/21 23:52, Martin K. Petersen wrote:
> Silencing analyzer warnings shouldn't be done at the expense of human
> readers. If it is imperative to switch to flex_array_size() to quiesce
> checker warnings, please add a comment in the code explaining that the
> size evaluates to nseg
].
Refactor the code according to the use of a flexible-array member in
struct aac_raw_io2 instead of one-element array, and use the
struct_size() and flex_array_size() helpers.
Also, this helps with the ongoing efforts to enable -Warray-bounds by
fixing the following warnings:
drivers/scsi/aacraid
Hi Kees/Gustavo!
>> @@ -4020,7 +4020,8 @@ static int aac_convert_sgraw2(struct aac_raw_io2
>> *rio2, int pages, int nseg, int
>> }
>> }
>> sge[pos] = rio2->sge[nseg-1];
>> -memcpy(&rio2->sge[1], &sge[1], (nseg_new-1)*sizeof(struct
>> sge_ieee1212));
>> +memcpy(&r
helps with the ongoing efforts to enable -Warray-bounds by
> fixing the following warnings:
>
> drivers/scsi/aacraid/aachba.c: In function ‘aac_build_sgraw2’:
> drivers/scsi/aacraid/aachba.c:3970:18: warning: array subscript 1 is above
> array bounds of ‘struct sge_ieee1212[1]’ [
The TODO file here has not been updated from 2.6.12 for more than 15 years.
Its existence will mislead developers seeking to view outdated information.
Signed-off-by: Wang Qing
---
drivers/scsi/aacraid/TODO | 3 ---
1 file changed, 3 deletions(-)
delete mode 100644 drivers/scsi/aacraid/TODO
I find it counter-intuitive to use the type of the destination array to
> size the amount of source data to copy. "Are source and destination same
The destination and source arrays are of the same type. :)
drivers/scsi/aacraid/aachba.c:
3999 struct sge_ieee1212 *sge;
> type? Doe
Gustavo,
> Precisely this sort of confusion is one of the things we want to avoid
> by using flexible-array members instead of one-element arrays.
Ah, you're right!
Now that I look at it again I also don't think that was the issue that
originally caused concern.
@@ -4020,7 +4020,8 @@ static i
> sge_ieee1212));
>> +fibsize = struct_size(readcmd2, sge,
>> + le32_to_cpu(readcmd2->sgeCnt));
>
> The old code allocated sgeCnt-1 elements (whether that was a mistake or
> not I do not know) whereas the new code would send a larger fib to th
pu(readcmd2->sgeCnt));
The old code allocated sgeCnt-1 elements (whether that was a mistake or
not I do not know) whereas the new code would send a larger fib to the
ASIC. I don't have any aacraid adapters and I am hesitant to merging
changes that have not been validated on real hardwar
].
Refactor the code according to the use of a flexible-array member in
struct aac_raw_io2 instead of one-element array, and use the
struct_size() and flex_array_size() helpers.
Also, this helps with the ongoing efforts to enable -Warray-bounds by
fixing the following warnings:
drivers/scsi/aacraid
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git
testing/scsi/aacraid
branch HEAD: eae919a32e577ba5cdbe353ce1eabebd969c04df scsi: aacraid: Replace
one-element array with flexible-array member
elapsed time: 720m
configs tested: 97
configs skipped: 3
The
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/rx.c:544: warning: expecting prototype for aac_rx_init().
Prototype was for _aac_rx_init() instead
Cc: Adaptec OEM Raid Solutions
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: "PMC-
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/commsup.c:334: warning: expecting prototype for
fib_deallocate(). Prototype was for fib_dealloc() instead
drivers/scsi/aacraid/commsup.c:1961: warning: expecting prototype for
aac_handle_sa_aif Handle a message from
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/commctrl.c:480: warning: expecting prototype for
aac_send_raw_scb(). Prototype was for aac_send_raw_srb() instead
Cc: Adaptec OEM Raid Solutions
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/aachba.c:796: warning: expecting prototype for
aac_probe_container(). Prototype was for aac_probe_container_callback1() instead
drivers/scsi/aacraid/aachba.c:850: warning: expecting prototype for
InqStrCopy(). Prototype was
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git
testing/scsi/aacraid
branch HEAD: b3519d554ac927b6d1dd3a65831b5e464a5a1347 scsi: aacraid: Replace
one-element array with flexible-array member
elapsed time: 1286m
configs tested: 92
configs skipped: 2
The
...@kernel.org
Fixes: 572ee53a9bad ("scsi: aacraid: check adapter health")
Reviewed-by: Christoph Hellwig
Signed-off-by: Arnd Bergmann
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/commctrl.c | 22 ++--
drivers/scsi/aacraid/linit
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/aacraid/commsup.c | 1
In current code, it jumps to call pci_disable_device() when
pci_enable_device() failes to initialize device. Add a label
'fail_enable' to fix it.
Fixes: de665f28f788 ("aacraid: Add Power Management support")
Signed-off-by: Jing Xiangfeng
---
drivers/scsi/aacraid/linit
ter argument.
>
> Calling aac_ioctl() instead of aac_compat_do_ioctl() means the
> compat and native code paths behave the same way again, which
> they stopped when the adapter health check was added only
> in the native function.
Applied to 5.11/scsi-queue, thanks!
[1/3] scsi: aa
Arnd,
> The use of compat_alloc_user_space() can be easily replaced by
> handling compat arguments in the regular handler, and this will make
> it work for big-endian kernels as well, which at the moment get an
> invalid indirect pointer argument.
Applied to 5.11/scsi-staging, thanks!
--
Mart
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
aac_resume().
Signed-off-by: Vaibhav Gupta
---
drivers/scsi/aacraid/linit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 8f3772480582..8c4dcb5ab329 100644
--- a
upta
Acked-by: Balsundar P
---
drivers/scsi/aacraid/linit.c | 33 +++--
1 file changed, 7 insertions(+), 26 deletions(-)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 8c4dcb5ab329..5177d387854a 100644
--- a/drivers/scsi/aacraid/linit.c
+++
aac_compat_do_ioctl() means the
compat and native code paths behave the same way again, which
they stopped when the adapter health check was added only
in the native function.
Fixes: 572ee53a9bad ("scsi: aacraid: check adapter health")
Reviewed-by: Christoph Hellwig
Signed-off-by: Arn
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
aac_resume().
Signed-off-by: Vaibhav Gupta
---
drivers/scsi/aacraid/linit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index a308e86a97f1..289887d5cc79 100644
--- a
---
drivers/scsi/aacraid/linit.c | 33 +++--
1 file changed, 7 insertions(+), 26 deletions(-)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 289887d5cc79..4740b7afa612 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/a
: Balsundar P
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/aachba.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 6e356325d8d98..54717fb84a54c 100644
--- a
. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/commsup.c | 2 +-
drivers/scsi/aacraid/linit.c | 34 +-
2 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index b7588de4484e5
assignments to 'error'. These values are
overwridden a few lines later.
Link:
https://lore.kernel.org/r/20200412094039.8822-1-christophe.jail...@wanadoo.fr
Signed-off-by: Christophe JAILLET
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/lini
: Balsundar P
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/aachba.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 0ed3f806ace54..2388143d59f5d 100644
--- a
. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/commsup.c | 2 +-
drivers/scsi/aacraid/linit.c | 34 +-
2 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 2142a649e865b
assignments to 'error'. These values are
overwridden a few lines later.
Link:
https://lore.kernel.org/r/20200412094039.8822-1-christophe.jail...@wanadoo.fr
Signed-off-by: Christophe JAILLET
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/lini
. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/commsup.c | 2 +-
drivers/scsi/aacraid/linit.c | 34 +-
2 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index a284527999c55
: Balsundar P
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/aachba.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 7173ae53c5260..ba11313568810 100644
--- a
: Balsundar P
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/aachba.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 065f11a1964d4..39deea8601d68 100644
--- a
: Balsundar P
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/aachba.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index de33801ca31ea..0614d05a990a6 100644
--- a
compat and native code paths behave the same way again, which
they stopped when the adapter health check was added only
in the native function.
Fixes: 572ee53a9bad ("scsi: aacraid: check adapter health")
Reviewed-by: Christoph Hellwig
Signed-off-by: Arnd Bergmann
---
drivers/sc
: Balsundar P
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/aachba.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 0ed3f806ace54..2388143d59f5d 100644
--- a
: Balsundar P
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/aachba.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 6e356325d8d98..54717fb84a54c 100644
--- a
. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/commsup.c | 2 +-
drivers/scsi/aacraid/linit.c | 34 +-
2 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index b7588de4484e5
assignments to 'error'. These values are
overwridden a few lines later.
Link:
https://lore.kernel.org/r/20200412094039.8822-1-christophe.jail...@wanadoo.fr
Signed-off-by: Christophe JAILLET
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/lini
. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/commsup.c | 2 +-
drivers/scsi/aacraid/linit.c | 34 +-
2 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index a284527999c55
: Balsundar P
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/aachba.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 065f11a1964d4..39deea8601d68 100644
--- a
: Balsundar P
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/aachba.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index de33801ca31ea..0614d05a990a6 100644
--- a
: Balsundar P
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/aachba.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 7173ae53c5260..ba11313568810 100644
--- a
assignments to 'error'. These values are
overwridden a few lines later.
Link:
https://lore.kernel.org/r/20200412094039.8822-1-christophe.jail...@wanadoo.fr
Signed-off-by: Christophe JAILLET
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/lini
. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aacraid/commsup.c | 2 +-
drivers/scsi/aacraid/linit.c | 34 +-
2 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 2142a649e865b
On Sat, Sep 12, 2020 at 9:09 AM Christoph Hellwig wrote:
>
> On Tue, Sep 08, 2020 at 11:36:21PM +0200, Arnd Bergmann wrote:
> > @@ -243,8 +244,23 @@ static int next_getadapter_fib(struct aac_dev * dev,
> > void __user *arg)
> > struct list_head * entry;
> > unsigned long flags;
> >
>
On Tue, Sep 08, 2020 at 11:36:21PM +0200, Arnd Bergmann wrote:
> @@ -243,8 +244,23 @@ static int next_getadapter_fib(struct aac_dev * dev,
> void __user *arg)
> struct list_head * entry;
> unsigned long flags;
>
> - if(copy_from_user((void *)&f, arg, sizeof(struct fib_ioctl)))
>
compat and native code paths behave the same way again, which
they stopped when the adapter health check was added only
in the native function.
Fixes: 572ee53a9bad ("scsi: aacraid: check adapter health")
Signed-off-by: Arnd Bergmann
---
drivers/scsi/aacraid/commctrl.c | 20 +-
pile-tested only.
>
> Signed-off-by: Vaibhav Gupta
> ---
> drivers/scsi/aacraid/linit.c | 34 --
> 1 file changed, 8 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
> index a30
t;dev, E2)
@@ expression E1, E2; @@
- pci_set_consistent_dma_mask(E1, E2)
+ dma_set_coherent_mask(&E1->dev, E2)
@@ expression E1, E2; @@
- pci_set_dma_mask(E1, E2)
+ dma_set_mask(&E1->dev, E2)
Signed-off-by: Suraj Upadhyay
---
drivers/scsi/aacraid/aachba.c | 4 ++--
driver
l-ment...@lists.linuxfoundation.org; linux-s...@vger.kernel.org;
esc.storage...@microsemi.com; megaraidlinux@broadcom.com;
mpt-fusionlinux@broadcom.com
Subject: [PATCH v2 02/15] scsi: aacraid: use generic power management
EXTERNAL EMAIL: Do not click links or open attachments unless you kn
Also clean-up some white space issues while we're here.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/sa.c:147: warning: Function parameter or member 'p2' not
described in 'sa_sync_cmd'
drivers/scsi/aacraid/sa.c:147: warning: Function par
And clean-up a couple of whitespace issues while we're here.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/rkt.c:64: warning: Function parameter or member 'dev' not
described in 'aac_rkt_ioremap'
Cc: Adaptec OEM Raid Solutions
Cc: "PMC-Si
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/src.c:203: warning: Function parameter or member 'p2' not
described in 'src_sync_cmd'
drivers/scsi/aacraid/src.c:203: warning: Function parameter or member 'p3' not
described in 'src_sy
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/nark.c:31: warning: Function parameter or member 'dev'
not described in 'aac_nark_ioremap'
Cc: Adaptec OEM Raid Solutions
Cc: "PMC-Sierra, Inc"
Signed-off-by: Lee Jones
---
drivers/scs
sing PCI helper functions like pci_save/restore_state(),
pci_disable/enable_device(), pci_set_power_state() and pci_enable_wake().
They should not be invoked by the driver.
Compile-tested only.
Signed-off-by: Vaibhav Gupta
---
drivers/scsi/aacraid/linit.c | 34 --
_mapping_error(&E1->dev, E2)
@@ expression E1, E2; @@
- pci_set_consistent_dma_mask(E1, E2)
+ dma_set_coherent_mask(&E1->dev, E2)
@@ expression E1, E2; @@
- pci_set_dma_mask(E1, E2)
+ dma_set_mask(&E1->dev, E2)
Signed-off-by: Suraj Upadhyay
---
drivers/scsi/aacraid/aachba.c | 4 ++--
drivers/s
sing PCI helper functions like pci_save/restore_state(),
pci_disable/enable_device(), pci_set_power_state() and pci_enable_wake().
They should not be invoked by the driver.
Compile-tested only.
Signed-off-by: Vaibhav Gupta
---
drivers/scsi/aacraid/linit.c | 34 --
Functions must follow imediately after the header documenting them and
all parameters must be present.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/commctrl.c:43: warning: Excess function parameter 'dev'
description in 'AAC_DEBUG_PREAMBLE'
When DBG is not enabled FIB_COUNTER_INCREMENT() results in an
empty statement, leaving the contents of if() and else() empty.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/dpcsup.c: In function ‘aac_response_normal’:
drivers/scsi/aacraid/dpcsup.c:105:50: warning
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/dpcsup.c: In function ‘aac_aif_callback’:
drivers/scsi/aacraid/dpcsup.c:232:6: warning: variable ‘status’ set but not
used [-Wunused-but-set-variable]
232 | int status;
| ^~
Cc: Adaptec OEM Raid Solutions
Cc: &quo
... and document aac_rx_ioremap() 'dev' param.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/rx.c:156: warning: Function parameter or member 'p2' not
described in 'rx_sync_cmd'
drivers/scsi/aacraid/rx.c:156: warning: Function parameter or
This should be populated by someone who knows the meaning of all the params.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/dpcsup.c:272: warning: Function parameter or member
'isAif' not described in 'aac_intr_normal'
drivers/scsi/aacraid/d
Some parameters not documented. Others misspelled.
Also, functions must follow directly after the header that documents them.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/commsup.c:223: warning: Function parameter or member
'scmd' not described in 'aa
The function headers for aac_get_config_status() and aac_get_containers()
have suffered bitrot where the documentation hasn't kept up with the API.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/aachba.c:358: warning: Function parameter or member 'dev'
n
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’:
drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body
in an ‘if’ statement [-Wempty-body]
368 | param->heads, param->sectors, num));
| ^
Cc: Adaptec OE
Most likely caused by bitrot (docs not keeping in sync with API).
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’:
drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body
in an ‘if’ statement [-Wempty-body
And a few missing/excessive parameter descriptions.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/aachba.c:358: warning: Function parameter or member 'dev'
not described in 'aac_get_config_status'
drivers/scsi/aacraid/aachba.c:358: warning: Function
... and document aac_rx_ioremap() 'dev' param.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/rx.c:156: warning: Function parameter or member 'p2' not
described in 'rx_sync_cmd'
drivers/scsi/aacraid/rx.c:156: warning: Function parameter or
When DBG is not enabled FIB_COUNTER_INCREMENT() results in an
empty statement, leaving the contents of if() and else() empty.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/dpcsup.c: In function ‘aac_response_normal’:
drivers/scsi/aacraid/dpcsup.c:105:50: warning
Some parameters not documented. Others misspelled.
Also, functions must follow directly after the header that documents them.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/commsup.c:223: warning: Function parameter or member
'scmd' not described in 'aa
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/dpcsup.c: In function ‘aac_aif_callback’:
drivers/scsi/aacraid/dpcsup.c:232:6: warning: variable ‘status’ set but not
used [-Wunused-but-set-variable]
232 | int status;
| ^~
Cc: Adaptec OEM Raid Solutions
Cc: &quo
Functions must follow imediately after the header documenting them and
all parameters must be present.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/commctrl.c:43: warning: Excess function parameter 'dev'
description in 'AAC_DEBUG_PREAMBLE'
The function headers for aac_get_config_status() and aac_get_containers()
have suffered bitrot where the documentation hasn't kept up with the API.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/aachba.c:358: warning: Function parameter or member 'dev'
n
This should be populated by someone who knows the meaning of all the params.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/dpcsup.c:272: warning: Function parameter or member
'isAif' not described in 'aac_intr_normal'
drivers/scsi/aacraid/d
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’:
drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body
in an ‘if’ statement [-Wempty-body]
368 | param->heads, param->sectors, num));
| ^
Cc: Adaptec OE
And a few missing/excessive parameter descriptions.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/aachba.c:358: warning: Function parameter or member 'dev'
not described in 'aac_get_config_status'
drivers/scsi/aacraid/aachba.c:358: warning: Function
Most likely caused by bitrot (docs not keeping in sync with API).
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’:
drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body
in an ‘if’ statement [-Wempty-body
On Sun, 26 Apr 2020 10:42:44 +0800, Zou Wei wrote:
> Fix coccicheck warning which recommends to use memdup_user().
>
> This patch fixes the following coccicheck warning:
>
> drivers/scsi/aacraid/commctrl.c:516:15-22: WARNING opportunity for memdup_user
Applied to 5.8/scsi-queue
On Thu, 30 Apr 2020 18:02:12 +0800, Zou Wei wrote:
> Fix the following sparse warnings:
>
> drivers/scsi/aacraid/linit.c:867:6: warning:
> symbol 'aac_tmf_callback' was not declared. Should it be static?
> drivers/scsi/aacraid/linit.c:1081:5: warning:
> symbol
Fix the following sparse warnings:
drivers/scsi/aacraid/linit.c:867:6: warning:
symbol 'aac_tmf_callback' was not declared. Should it be static?
drivers/scsi/aacraid/linit.c:1081:5: warning:
symbol 'aac_eh_host_reset' was not declared. Should it be static?
drivers/scsi/aacr
> Problem description:
>
> A node with Adaptec 6405 controller, latest BIOS V5.3-0[19204] A lot
> of disks attached to the controller. Simple test: running mkfs.ext4
> on many disks on the same controller in parallel (mkfs is not
> important here, any serious io load trigger
aborts)
Results:
* no problems (controller resets) with kernels prior to
395e5df79a95 ("scsi: aacraid: Remove reference to Series-9")
* latest ms kernel v5.2-rc6-15-g249155c20f9b - mkfs processes are in D state,
lot of complains in logs like:
[ 654.894633] aacraid: Host ada
The patch introduces another wrapper similar to aac_is_src()
which avoids checking for Series 6 devices.
Use this new wrapper in order to revert original arc ctrl checks for
Series-6 controllers which were occasionally changed by commit
395e5df79a95 ("scsi: aacraid: Remove reference to Ser
Hi Konstantin,
> The patch removes references to Series 9 adapters following
> 395e5df79a95 ("scsi: aacraid: Remove reference to Series-9"),
> but doesn't touch Series 6 adapters logic.
We'll need some guidance from the Microsemi folks on this issue.
> https://
aborts)
Results:
* no problems (controller resets) with kernels prior to
395e5df79a95 ("scsi: aacraid: Remove reference to Series-9")
* latest ms kernel v5.2-rc6-15-g249155c20f9b - mkfs processes are in D state,
lot of complains in logs like:
[ 654.894633] aacraid: Host ada
The patch removes references to Series 9 adapters following
395e5df79a95 ("scsi: aacraid: Remove reference to Series-9"),
but doesn't touch Series 6 adapters logic.
Leaving Series 6 adapters untouched avoids controller
hungs/resets under high io load.
https://bugs.launchpad.net
removed by next patch.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1777586
https://bugzilla.redhat.com/show_bug.cgi?id=1724077
https://jira.sw.ru/browse/PSBM-95736
Signed-off-by: Konstantin Khorenko
---
drivers/scsi/aacraid/aacraid.h | 12 +---
drivers/scsi/aacraid/comminit.c | 18
On 07/08/2019 02:49 AM, Finn Thain wrote:
> Andrey,
>
> It is helpful to send your review to the patch author. I've added
> Konstantin to the Cc list, as well as Raghava (who introduced the
> regression addressed by Konstantin's patch).
>
> If I'm not mistaken, your review misunderstands the patch
7;s patch might have been easier to follow if it was a
simple 'git revert'.
--
On Sun, 7 Jul 2019, Andrey Jr. Melnikov wrote:
> In gmane.linux.scsi Konstantin Khorenko wrote:
> > This partially reverts ms commit
> > 395e5df79a95 ("scsi: aacraid: Remove reference t
In gmane.linux.scsi Konstantin Khorenko wrote:
> This partially reverts ms commit
> 395e5df79a95 ("scsi: aacraid: Remove reference to Series-9")
> The patch above not only drops Series-9 cards checks but also
> changes logic for Series-6 controllers which leads to controlle
In commit af7ddd8a627c
("Merge tag 'dma-mapping-4.21' of
git://git.infradead.org/users/hch/dma-mapping"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.
Signed-off-by: Fuqian Huang
---
drivers/scsi/aacraid/rx.c | 1 -
1 file changed, 1 delet
aborts)
Results:
* no problems (controller resets) with kernels prior to
395e5df79a95 ("scsi: aacraid: Remove reference to Series-9")
* latest ms kernel v5.2-rc6-15-g249155c20f9b - mkfs processes are in D state,
lot of complains in logs like:
[ 654.894633] aacraid: Host ada
This partially reverts ms commit
395e5df79a95 ("scsi: aacraid: Remove reference to Series-9")
The patch above not only drops Series-9 cards checks but also
changes logic for Series-6 controllers which leads to controller
hangs/resets under high io load.
So revert to original arc ctrl
: Martin K. Petersen
Signed-off-by: Sasha Levin (Microsoft)
---
drivers/scsi/aacraid/aacraid.h | 7 ++-
drivers/scsi/aacraid/commsup.c | 4 ++--
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
index 3291d1c16864
: Martin K. Petersen
Signed-off-by: Sasha Levin (Microsoft)
---
drivers/scsi/aacraid/aacraid.h | 7 ++-
drivers/scsi/aacraid/commsup.c | 4 ++--
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
index 39eb415987fc
Biradar
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin (Microsoft)
---
drivers/scsi/aacraid/aacraid.h | 7 ++-
drivers/scsi/aacraid/commsup.c | 4 ++--
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
1 - 100 of 492 matches
Mail list logo
