Re: WMI driver no longer load after switching to generic UUID library

2016-05-30 Thread Kui Zhang
Thanks guys. keyboard functions are working now. kui.z On Mon, May 30, 2016 at 7:40 AM, Andy Shevchenko wrote: > On Mon, 2016-05-30 at 12:52 +0200, Bjørn Mork wrote: >> How about the untested attached patch? >> > > Facepalm.jpg! > > Good catch! > > The question is how it passed in our internal

Re: WMI driver no longer load after switching to generic UUID library

2016-05-30 Thread Andy Shevchenko
On Mon, 2016-05-30 at 12:52 +0200, Bjørn Mork wrote: > How about the untested attached patch? >  Facepalm.jpg! Good catch! The question is how it passed in our internal tree without being notified (it even included a lot of ACPI code updated)!? My explanation since I have no access to archive o

Re: WMI driver no longer load after switching to generic UUID library

2016-05-30 Thread Bjørn Mork
How about the untested attached patch? Bjørn >From d1682d6c0a558cf8ffb82af959156f99f0f1f61a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Mork?= Date: Mon, 30 May 2016 12:44:05 +0200 Subject: [PATCH] lib/uuid.c: use correct offset in uuid parser MIME-Version: 1.0 Content-Type: text/plai

Re: WMI driver no longer load after switching to generic UUID library

2016-05-30 Thread Andy Shevchenko
On Sun, 2016-05-29 at 13:22 -0700, Linus Torvalds wrote: > Andy? > > Looking at that commit, it does look like what wmi_parse_guid + > wmi_swap_bytes did was to implement a LE uuid. So the conversion looks > correct, but the fact that it breaks something obviously means that > there's something mi

Re: WMI driver no longer load after switching to generic UUID library

2016-05-29 Thread Linus Torvalds
Andy? Looking at that commit, it does look like what wmi_parse_guid + wmi_swap_bytes did was to implement a LE uuid. So the conversion looks correct, but the fact that it breaks something obviously means that there's something missing. What's going on? And dammit, how I hate uuid's and the idioti

Fwd: WMI driver no longer load after switching to generic UUID library

2016-05-29 Thread Kui Zhang
oops, forgot the list. -- Forwarded message -- From: Kui Zhang Date: Sun, May 29, 2016 at 11:35 AM Subject: WMI driver no longer load after switching to generic UUID library To: andriy.shevche...@linux.intel.com, dvh...@linux.intel.com, a...@linux-foundation.org, torva...@linux