Re: [PATCH v2] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()

2019-09-30 Thread Martin K. Petersen
Daniel, > Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not > called from the completion path") introduced the WARN_ON_ONCE in > qla2x00_status_cont_entry(). The assumption was that there is only one > status continuations element. According to the fi

Re: [PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()

2019-09-27 Thread Daniel Wagner
Hi, > Should the following be added? > > Fixes: 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not > called from the completion path") Good point. Just send out and updated version > Anyway: > > Reviewed-by: Bart Van Assche Thanks! Daniel

[PATCH v2] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()

2019-09-27 Thread Daniel Wagner
Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") introduced the WARN_ON_ONCE in qla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is

Re: [PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()

2019-09-26 Thread Bart Van Assche
On 2019-09-26 00:46, Daniel Wagner wrote: > Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not > called from the completion path") introduced the WARN_ON_ONCE in > qla2x00_status_cont_entry(). The assumption was that there is only one > status continuati

Re: [PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()

2019-09-26 Thread Hannes Reinecke
On 9/26/19 9:46 AM, Daniel Wagner wrote: > Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not > called from the completion path") introduced the WARN_ON_ONCE in > qla2x00_status_cont_entry(). The assumption was that there is only one > status continuations

Re: WARN_ON_ONCE in qla2x00_status_cont_entry

2019-09-26 Thread Daniel Wagner
On Wed, Sep 25, 2019 at 06:33:35PM -0700, Bart Van Assche wrote: > On 2019-09-25 05:39, Daniel Wagner wrote: > > So I after starring on the code I am not sure if the WARN_ON_ONCE is > > correct. It assumes that after processing one status continuation, > > there is no more work. Though it looks lik

[PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()

2019-09-26 Thread Daniel Wagner
Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") introduced the WARN_ON_ONCE in qla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is

Re: WARN_ON_ONCE in qla2x00_status_cont_entry

2019-09-25 Thread Bart Van Assche
On 2019-09-25 05:39, Daniel Wagner wrote: > So I after starring on the code I am not sure if the WARN_ON_ONCE is > correct. It assumes that after processing one status continuation, > there is no more work. Though it looks like there is another element > to process. Is it possible that two sense co

WARN_ON_ONCE in qla2x00_status_cont_entry

2019-09-25 Thread Daniel Wagner
Hi, While testing an update of the qla2xxx driver (10.01.00.19-k) in our downstream kernel, I noticed that the WARN_ON_ONCE in qla2x00_status_cont_entry() is triggered. It was introduced by 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path")