Re: WARNING in tty_set_termios

2019-03-17 Thread syzbot
syzbot has bisected this bug to: commit 162f812f23bab583f5d514ca0e4df67797ac9cdf Author: Loic Poulain Date: Mon Sep 19 14:29:27 2016 + Bluetooth: hci_uart: Add Marvell support bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12cd5c2b20 start commit: 162f812f Bluetoo

Re: [PATCH v5] bluetooth: Fix WARNING in tty_set_termios()

2019-02-12 Thread shuah
On 2/9/19 2:42 AM, Johan Hovold wrote: On Fri, Feb 08, 2019 at 04:06:09PM -0700, Shuah Khan wrote: tty_set_termios() has the following WARN_ON which can be triggered with a syscall to invoke TIOCSETD __NR_ioctl. WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && tty->driver->s

Re: [PATCH v5] bluetooth: Fix WARNING in tty_set_termios()

2019-02-09 Thread Johan Hovold
On Fri, Feb 08, 2019 at 04:06:09PM -0700, Shuah Khan wrote: > tty_set_termios() has the following WARN_ON which can be triggered with a > syscall to invoke TIOCSETD __NR_ioctl. > > WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && > tty->driver->subtype == PTY_TYPE_MASTER); > Ref

[PATCH v5] bluetooth: Fix WARNING in tty_set_termios()

2019-02-08 Thread Shuah Khan
tty_set_termios() has the following WARN_ON which can be triggered with a syscall to invoke TIOCSETD __NR_ioctl. WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && tty->driver->subtype == PTY_TYPE_MASTER); Reference: https://syzkaller.appspot.com/bug?id=2410d22f1d8e5984217329dd08

Re: [PATCH v4] bluetooth: Fix WARNING in tty_set_termios()

2019-02-04 Thread shuah
On 2/3/19 10:39 PM, Marcel Holtmann wrote: Hi Shuah, tty_set_termios() has the following WARN_ON which can be triggered with a syscall to invoke TIOCSETD __NR_ioctl. WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && tty->driver->subtype == PTY_TYPE_MASTER); Reference: https:

Re: [PATCH v4] bluetooth: Fix WARNING in tty_set_termios()

2019-02-03 Thread Marcel Holtmann
Hi Shuah, > tty_set_termios() has the following WARN_ON which can be triggered with a > syscall to invoke TIOCSETD __NR_ioctl. > > WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && >tty->driver->subtype == PTY_TYPE_MASTER); > Reference: > https://syzkaller.appspot.com/bug?id=24

[PATCH v4] bluetooth: Fix WARNING in tty_set_termios()

2019-02-03 Thread Shuah Khan
tty_set_termios() has the following WARN_ON which can be triggered with a syscall to invoke TIOCSETD __NR_ioctl. WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && tty->driver->subtype == PTY_TYPE_MASTER); Reference: https://syzkaller.appspot.com/bug?id=2410d22f1d8e5984217329dd08

Re: [PATCH v3] bluetooth: Fix WARNING in tty_set_termios()

2019-02-03 Thread shuah
On 2/3/19 10:31 AM, Marcel Holtmann wrote: Hi Shuah, tty_set_termios() has the following WARN_ON which can be triggered with a syscall to invoke TIOCSETD __NR_ioctl. WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && tty->driver->subtype == PTY_TYPE_MASTER); Reference: https:

Re: [PATCH v3] bluetooth: Fix WARNING in tty_set_termios()

2019-02-03 Thread Marcel Holtmann
Hi Shuah, > tty_set_termios() has the following WARN_ON which can be triggered with a > syscall to invoke TIOCSETD __NR_ioctl. > > WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && >tty->driver->subtype == PTY_TYPE_MASTER); > Reference: > https://syzkaller.appspot.com/bug?id=24

[PATCH v3] bluetooth: Fix WARNING in tty_set_termios()

2019-02-03 Thread Shuah Khan
tty_set_termios() has the following WARN_ON which can be triggered with a syscall to invoke TIOCSETD __NR_ioctl. WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && tty->driver->subtype == PTY_TYPE_MASTER); Reference: https://syzkaller.appspot.com/bug?id=2410d22f1d8e5984217329dd08

Re: [PATCH v2] tty: Fix WARNING in tty_set_termios()

2019-02-01 Thread shuah
.appspotmail.com Signed-off-by: Shuah Khan --- drivers/bluetooth/hci_ldisc.c | 11 +++ 1 file changed, 11 insertions(+) I think the subject should be something like: "bluetooth: hci: Fix warning in tty_set_termios()" it isn't a tty core problem :) Yes. Sorry ab

Re: [PATCH v2] tty: Fix WARNING in tty_set_termios()

2019-02-01 Thread shuah
On 2/1/19 2:28 AM, Johan Hovold wrote: On Thu, Jan 31, 2019 at 04:23:59PM -0700, Shuah Khan wrote: tty_set_termios() has the following WARN_ON which can be triggered with a syscall to invoke TIOCSETD __NR_ioctl. That's the only way to set the hci line discipline. And it's the consequent ioctl

Re: [PATCH v2] tty: Fix WARNING in tty_set_termios()

2019-02-01 Thread shuah
On 2/1/19 3:00 AM, Marcel Holtmann wrote: Hi Shuah, tty_set_termios() has the following WARN_ON which can be triggered with a syscall to invoke TIOCSETD __NR_ioctl. WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && tty->driver->subtype == PTY_TYPE_MASTER); Reference: https:/

Re: [PATCH v2] tty: Fix WARNING in tty_set_termios()

2019-02-01 Thread Marcel Holtmann
Hi Shuah, > tty_set_termios() has the following WARN_ON which can be triggered with a > syscall to invoke TIOCSETD __NR_ioctl. > > WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && >tty->driver->subtype == PTY_TYPE_MASTER); > Reference: > https://syzkaller.appspot.com/bug?id=24

Re: [PATCH v2] tty: Fix WARNING in tty_set_termios()

2019-02-01 Thread Johan Hovold
On Fri, Feb 01, 2019 at 10:28:43AM +0100, Johan Hovold wrote: > On Thu, Jan 31, 2019 at 04:23:59PM -0700, Shuah Khan wrote: > > tty_set_termios() has the following WARN_ON which can be triggered with a > > syscall to invoke TIOCSETD __NR_ioctl. > > That's the only way to set the hci line disciplin

Re: [PATCH v2] tty: Fix WARNING in tty_set_termios()

2019-02-01 Thread Johan Hovold
On Thu, Jan 31, 2019 at 04:23:59PM -0700, Shuah Khan wrote: > tty_set_termios() has the following WARN_ON which can be triggered with a > syscall to invoke TIOCSETD __NR_ioctl. That's the only way to set the hci line discipline. And it's the consequent ioctl that sets the uart protocol that trigge

Re: [PATCH v2] tty: Fix WARNING in tty_set_termios()

2019-01-31 Thread Greg KH
; Reported-by: syzbot+a950165cbb86bdd02...@syzkaller.appspotmail.com > Signed-off-by: Shuah Khan > --- > drivers/bluetooth/hci_ldisc.c | 11 +++ > 1 file changed, 11 insertions(+) I think the subject should be something like: "bluetooth: hci: Fix warning in tty_set_termios()" it isn't a tty core problem :) thanks, greg k-h

[PATCH v2] tty: Fix WARNING in tty_set_termios()

2019-01-31 Thread Shuah Khan
tty_set_termios() has the following WARN_ON which can be triggered with a syscall to invoke TIOCSETD __NR_ioctl. WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && tty->driver->subtype == PTY_TYPE_MASTER); Reference: https://syzkaller.appspot.com/bug?id=2410d22f1d8e5984217329dd08

Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-31 Thread shuah
On 1/31/19 8:33 AM, Johan Hovold wrote: On Thu, Jan 31, 2019 at 04:18:33PM +0100, Marcel Holtmann wrote: I agree with Al that this change doesn't make much sense. The WARN_ON is there to catch any bugs leading to the termios being changed for a master side pty. Those should bugs should be fixed

Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-31 Thread Johan Hovold
On Thu, Jan 31, 2019 at 04:18:33PM +0100, Marcel Holtmann wrote: > > I agree with Al that this change doesn't make much sense. The WARN_ON > > is there to catch any bugs leading to the termios being changed for a > > master side pty. Those should bugs should be fixed, and not worked > > around in

Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-31 Thread Marcel Holtmann
Hi Johan, >>> On Fri, Jan 25, 2019 at 04:29:05PM -0700, Shuah Khan wrote: tty_set_termios() has the following WARMN_ON which can be triggered with a syscall to invoke TIOCGETD __NR_ioctl. > > You meant TIOCSETD here, and in fact its the call which sets the uart > protocol that triggers

Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-30 Thread shuah
On 1/30/19 3:32 AM, Johan Hovold wrote: On Mon, Jan 28, 2019 at 02:29:22PM -0700, shuah wrote: On 1/25/19 9:14 PM, Al Viro wrote: On Fri, Jan 25, 2019 at 04:29:05PM -0700, Shuah Khan wrote: tty_set_termios() has the following WARMN_ON which can be triggered with a syscall to invoke TIOCGETD __

Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-30 Thread Johan Hovold
On Mon, Jan 28, 2019 at 02:29:22PM -0700, shuah wrote: > On 1/25/19 9:14 PM, Al Viro wrote: > > On Fri, Jan 25, 2019 at 04:29:05PM -0700, Shuah Khan wrote: > >> tty_set_termios() has the following WARMN_ON which can be triggered with a > >> syscall to invoke TIOCGETD __NR_ioctl. You meant TIOCSETD

Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-28 Thread shuah
On 1/25/19 9:14 PM, Al Viro wrote: On Fri, Jan 25, 2019 at 04:29:05PM -0700, Shuah Khan wrote: tty_set_termios() has the following WARMN_ON which can be triggered with a syscall to invoke TIOCGETD __NR_ioctl. WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && tty->driver->subt

Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-25 Thread Al Viro
On Fri, Jan 25, 2019 at 04:29:05PM -0700, Shuah Khan wrote: > tty_set_termios() has the following WARMN_ON which can be triggered with a > syscall to invoke TIOCGETD __NR_ioctl. > > WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && > tty->driver->subtype == PTY_TYPE_MASTER); > Re

[PATCH] tty: Fix WARNING in tty_set_termios

2019-01-25 Thread Shuah Khan
tty_set_termios() has the following WARMN_ON which can be triggered with a syscall to invoke TIOCGETD __NR_ioctl. WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY && tty->driver->subtype == PTY_TYPE_MASTER); Reference: https://syzkaller.appspot.com/bug?id=2410d22f1d8e5984217329dd0

WARNING in tty_set_termios

2019-01-12 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:66c56cfa64d9 Merge tag 'remove-dma_zalloc_coherent-5.0' of.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=167fd6d8c0 kernel config: https://syzkaller.appspot.com/x/.config?x=b05cfdb4ee8ab9b2 da