Re: WARNING in kill_block_super

2018-04-11 Thread Tetsuo Handa
calling deactivate_locked_super() from sget_userns(). Manual auditing and syzbot tests will eventually reveal remaining bugs. [1] https://syzkaller.appspot.com/bug?id=588996a25a2587be2e3a54e8646728fb9cae44e7 Signed-off-by: Tetsuo Handa Reported-by: syzbot # WARNING: refcount bug in should_f

Re: Re: WARNING in kill_block_super

2018-04-10 Thread Al Viro
On Wed, Apr 11, 2018 at 10:28:06AM +0900, Tetsuo Handa wrote: > Al Viro wrote: > > On Wed, Apr 04, 2018 at 07:53:07PM +0900, Tetsuo Handa wrote: > > > Al and Michal, are you OK with this patch? > > > > First of all, it does *NOT* fix the problems with careless ->kill_sb(). > > The fuse-blk case is

Re: WARNING in kill_block_super

2018-04-10 Thread Al Viro
On Wed, Apr 04, 2018 at 07:53:07PM +0900, Tetsuo Handa wrote: > Al and Michal, are you OK with this patch? First of all, it does *NOT* fix the problems with careless ->kill_sb(). The fuse-blk case is the only real rationale so far. Said that, > @@ -166,6 +166,7 @@ static void destroy_unused_supe

Re: WARNING in kill_block_super

2018-04-06 Thread Tetsuo Handa
Michal Hocko wrote: > On Wed 04-04-18 19:53:07, Tetsuo Handa wrote: > > Al and Michal, are you OK with this patch? > > Maybe I've misunderstood, but hasn't Al explained [1] that the > appropriate fix is in the fs code? > > [1] http://lkml.kernel.org/r/20180402143415.gc30...@zeniv.linux.org.uk Ye

Re: WARNING in kill_block_super

2018-04-06 Thread Michal Hocko
On Wed 04-04-18 19:53:07, Tetsuo Handa wrote: > Al and Michal, are you OK with this patch? Maybe I've misunderstood, but hasn't Al explained [1] that the appropriate fix is in the fs code? [1] http://lkml.kernel.org/r/20180402143415.gc30...@zeniv.linux.org.uk -- Michal Hocko SUSE Labs

Re: WARNING in kill_block_super

2018-04-04 Thread Tetsuo Handa
Al and Michal, are you OK with this patch? >From bbc0d00935ebcb7e287403bae545fae9340830d9 Mon Sep 17 00:00:00 2001 From: Tetsuo Handa Date: Wed, 4 Apr 2018 12:19:42 +0900 Subject: [PATCH] mm,vmscan: Allow preallocating memory for register_shrinker(). syzbot is catching so many bugs triggered by

WARNING in kill_block_super

2018-03-29 Thread syzbot
Hello, syzbot hit the following crash on upstream commit 0b412605ef5f5c64b31f19e2910b1d5eba9929c3 (Thu Mar 29 01:07:23 2018 +) Merge tag 'drm-fixes-for-v4.16-rc8' of git://people.freedesktop.org/~airlied/linux syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=5a170e19c963a2e0