Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-02 Thread Paul E. McKenney
On Wed, Sep 02, 2020 at 06:07:05PM +0200, Ulf Hansson wrote: > On Wed, 2 Sep 2020 at 15:52, Paul E. McKenney wrote: > > > > On Wed, Sep 02, 2020 at 08:49:11AM +0200, Ulf Hansson wrote: > > > On Tue, 1 Sep 2020 at 17:00, Paul E. McKenney wrote: > > > > [ . . . ] > > > > > > Here is the list, thoug

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-02 Thread Ulf Hansson
On Wed, 2 Sep 2020 at 15:52, Paul E. McKenney wrote: > > On Wed, Sep 02, 2020 at 08:49:11AM +0200, Ulf Hansson wrote: > > On Tue, 1 Sep 2020 at 17:00, Paul E. McKenney wrote: > > [ . . . ] > > > > Here is the list, though it is early in the morning here: > > > > > > 1. RCU_NONIDLE(). > > > >

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-02 Thread Ulf Hansson
On Wed, 2 Sep 2020 at 14:14, wrote: > > On Wed, Sep 02, 2020 at 09:03:37AM +0200, Ulf Hansson wrote: > > Lots of cpuidle drivers are using CPU_PM notifiers (grep for > > cpu_pm_enter and you will see) from their idlestates ->enter() > > callbacks. And for those we are already calling > > rcu_irq_e

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-02 Thread Paul E. McKenney
On Wed, Sep 02, 2020 at 08:49:11AM +0200, Ulf Hansson wrote: > On Tue, 1 Sep 2020 at 17:00, Paul E. McKenney wrote: [ . . . ] > > Here is the list, though it is early in the morning here: > > > > 1. RCU_NONIDLE(). > > > > 2. Peter's patch, if it turns out to hoist your code out of what

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-02 Thread peterz
On Wed, Sep 02, 2020 at 09:03:37AM +0200, Ulf Hansson wrote: > Lots of cpuidle drivers are using CPU_PM notifiers (grep for > cpu_pm_enter and you will see) from their idlestates ->enter() > callbacks. And for those we are already calling > rcu_irq_enter_irqson|off() in cpu_pm_notify() when firing

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-02 Thread Ulf Hansson
On Tue, 1 Sep 2020 at 19:42, Peter Zijlstra wrote: > > On Tue, Sep 01, 2020 at 09:13:40AM -0700, Paul E. McKenney wrote: > > On Tue, Sep 01, 2020 at 05:50:14PM +0200, pet...@infradead.org wrote: > > > On Tue, Sep 01, 2020 at 09:44:17AM -0600, Lina Iyer wrote: > > > > > > > > > I could add RCU_NONI

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-01 Thread Ulf Hansson
On Tue, 1 Sep 2020 at 17:00, Paul E. McKenney wrote: > > On Tue, Sep 01, 2020 at 08:46:54AM +0200, Ulf Hansson wrote: > > + Saravanna, Rafael, Lina > > > > On Mon, 31 Aug 2020 at 21:44, Paul E. McKenney wrote: > > > > > > On Mon, Aug 31, 2020 at 12:02:31PM +0530, Naresh Kamboju wrote: > > > > Whi

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-01 Thread Peter Zijlstra
On Tue, Sep 01, 2020 at 09:13:40AM -0700, Paul E. McKenney wrote: > On Tue, Sep 01, 2020 at 05:50:14PM +0200, pet...@infradead.org wrote: > > On Tue, Sep 01, 2020 at 09:44:17AM -0600, Lina Iyer wrote: > > > > > > > > I could add RCU_NONIDLE for the calls to > > > > > > > > pm_runtime_put_sync_susp

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-01 Thread Paul E. McKenney
On Tue, Sep 01, 2020 at 05:50:14PM +0200, pet...@infradead.org wrote: > On Tue, Sep 01, 2020 at 09:44:17AM -0600, Lina Iyer wrote: > > > > > > > I could add RCU_NONIDLE for the calls to > > > > > > > pm_runtime_put_sync_suspend() > > > > > > > and pm_runtime_get_sync() in psci_enter_domain_idle_st

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-01 Thread peterz
On Tue, Sep 01, 2020 at 09:44:17AM -0600, Lina Iyer wrote: > > > > > > I could add RCU_NONIDLE for the calls to > > > > > > pm_runtime_put_sync_suspend() > > > > > > and pm_runtime_get_sync() in psci_enter_domain_idle_state(). Perhaps > > > > > > that's the easiest approach, at least to start with

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-01 Thread Lina Iyer
Hi Ulf, On Tue, Sep 01 2020 at 06:41 -0600, Ulf Hansson wrote: On Tue, 1 Sep 2020 at 14:35, Ulf Hansson wrote: On Tue, 1 Sep 2020 at 12:42, wrote: > > On Tue, Sep 01, 2020 at 08:50:57AM +0200, Ulf Hansson wrote: > > On Tue, 1 Sep 2020 at 08:46, Ulf Hansson wrote: > > > On Mon, 31 Aug 2020 a

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-01 Thread peterz
On Tue, Sep 01, 2020 at 02:35:52PM +0200, Ulf Hansson wrote: > On Tue, 1 Sep 2020 at 12:42, wrote: > > That said; I pushed the rcu_idle_enter() about as deep as it goes into > > generic code in commit 1098582a0f6c ("sched,idle,rcu: Push rcu_idle > > deeper into the idle path") > > Aha, that comm

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-01 Thread Paul E. McKenney
On Tue, Sep 01, 2020 at 08:46:54AM +0200, Ulf Hansson wrote: > + Saravanna, Rafael, Lina > > On Mon, 31 Aug 2020 at 21:44, Paul E. McKenney wrote: > > > > On Mon, Aug 31, 2020 at 12:02:31PM +0530, Naresh Kamboju wrote: > > > While booting linux mainline kernel on arm64 db410c this kernel warning

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-01 Thread Ulf Hansson
On Tue, 1 Sep 2020 at 14:35, Ulf Hansson wrote: > > On Tue, 1 Sep 2020 at 12:42, wrote: > > > > On Tue, Sep 01, 2020 at 08:50:57AM +0200, Ulf Hansson wrote: > > > On Tue, 1 Sep 2020 at 08:46, Ulf Hansson wrote: > > > > On Mon, 31 Aug 2020 at 21:44, Paul E. McKenney > > > > wrote: > > > > > > >

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-01 Thread Ulf Hansson
On Tue, 1 Sep 2020 at 12:42, wrote: > > On Tue, Sep 01, 2020 at 08:50:57AM +0200, Ulf Hansson wrote: > > On Tue, 1 Sep 2020 at 08:46, Ulf Hansson wrote: > > > On Mon, 31 Aug 2020 at 21:44, Paul E. McKenney wrote: > > > > > > [5.308588] = > > > > > [5.308593] W

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-01 Thread peterz
On Tue, Sep 01, 2020 at 08:50:57AM +0200, Ulf Hansson wrote: > On Tue, 1 Sep 2020 at 08:46, Ulf Hansson wrote: > > On Mon, 31 Aug 2020 at 21:44, Paul E. McKenney wrote: > > > > [5.308588] = > > > > [5.308593] WARNING: suspicious RCU usage > > > > [5.316628

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-08-31 Thread Ulf Hansson
+ Re-adding Peter (seems like the original address was wrong) On Tue, 1 Sep 2020 at 08:46, Ulf Hansson wrote: > > + Saravanna, Rafael, Lina > > On Mon, 31 Aug 2020 at 21:44, Paul E. McKenney wrote: > > > > On Mon, Aug 31, 2020 at 12:02:31PM +0530, Naresh Kamboju wrote: > > > While booting linux

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-08-31 Thread Ulf Hansson
+ Saravanna, Rafael, Lina On Mon, 31 Aug 2020 at 21:44, Paul E. McKenney wrote: > > On Mon, Aug 31, 2020 at 12:02:31PM +0530, Naresh Kamboju wrote: > > While booting linux mainline kernel on arm64 db410c this kernel warning > > noticed. > > > > metadata: > > git branch: master > > git repo:

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-08-31 Thread Paul E. McKenney
On Mon, Aug 31, 2020 at 12:02:31PM +0530, Naresh Kamboju wrote: > While booting linux mainline kernel on arm64 db410c this kernel warning > noticed. > > metadata: > git branch: master > git repo: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > git commit: f75aef392f86901

WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-08-30 Thread Naresh Kamboju
While booting linux mainline kernel on arm64 db410c this kernel warning noticed. metadata: git branch: master git repo: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git commit: f75aef392f869018f78cfedf3c320a6b3fcfda6b git describe: v5.9-rc3 make_kernelversion: 5.9.0