Re: [tpmdd-devel] TPM: STMicroelectronics st33 driver SPI

2013-09-11 Thread Peter Hüwe
When compiling it I get WARNING: modpost: missing MODULE_LICENSE() in drivers/char/tpm/tpm_spi_stm_st33.o Thanks, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/m

Re: TPM: STMicroelectronics st33 driver SPI

2013-08-26 Thread Ashley Lai
Please see my comments below. Did you get a chance to run the trousers testsuite? git://trousers.git.sourceforge.net/gitroot/trousers/testsuite +static u8 spi_read8_reg(struct tpm_chip *tpm, u8 tpm_register, + u8 *tpm_data, u16 tpm_size) +{ + ... + + /* header +

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-07-25 Thread Mathias leblanc
From: Mathias Leblanc * STMicroelectronics version 1.2.0, Copyright (C) 2013 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you h

Re: [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-23 Thread Andy Shevchenko
On Thu, May 23, 2013 at 10:43 AM, Mathias LEBLANC wrote: > Thanks for your support, I will fix these code style problem. I left below the comments I think should be addressed besides style. Please, comment what you think about them. > However in a first time, can we publish this SPI driver? It

RE: [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-23 Thread Mathias LEBLANC
lists.sourceforge.net; linux-kernel@vger.kernel.org; Jean-Luc BLANC Subject: Re: [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI On Fri, May 17, 2013 at 4:10 PM, Matthias Leblanc wrote: > From: Mathias Leblanc Which name is correct? You have not to have this From: line if submitter an

Re: [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-19 Thread Andy Shevchenko
On Fri, May 17, 2013 at 4:10 PM, Matthias Leblanc wrote: > From: Mathias Leblanc Which name is correct? You have not to have this From: line if submitter and author is the same person. > +++ b/drivers/char/tpm/tpm_spi_stm_st33.c > @@ -0,0 +1,943 @@ > +/* > + * STMicroelectronics TPM SPI Linux

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-17 Thread Matthias Leblanc
From: Mathias Leblanc * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you h

RE: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-17 Thread Mathias LEBLANC
as Leblanc From: Peter Hüwe [peterhu...@gmx.de] Sent: 16 May 2013 21:03 To: tpmdd-de...@lists.sourceforge.net Cc: Mathias LEBLANC; Jean-Luc BLANC; linux-kernel@vger.kernel.org; Rajiv Andrade; Sirrix AG Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI H

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-16 Thread Peter Hüwe
Hi Matthias: > Regarding the while loop, I don't see how can I check the number of dummy > byte differently? Checking the number of dummy bytes is fine - in line #144 you check it with a while loop which looks fine in line #198 you check it with a for loop with an empty body, which in my opinio

RE: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-16 Thread Mathias LEBLANC
rge.net Cc: Mathias LEBLANC; Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG; Jean-Luc BLANC; linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI Hi Matthias, Am Mittwoch, 15. Mai 2013, 15:53:19 schrieb Matthias Leblanc: > +stat

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-15 Thread Peter Hüwe
ister() on error in init_tis() drivers/char/tpm $ git am /tmp/\[tpmdd-devel\]\ \[PATCH\ 1_1\]\ TPM_STMicroelectronics\ st33\ driver\ SPI.mbox Applying: TPM: STMicroelectronics st33 driver SPI drivers/char/tpm $ tail tpm_spi_stm_st33.c}, .probe = tpm_st33_spi_probe, .remove =

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-15 Thread Matthias Leblanc
From: Mathias Leblanc * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you h

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-13 Thread Kent Yoder
May, 2013 17:07 > To: Mathias LEBLANC > Cc: Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG; TPM Device Driver > List; Jean-Luc BLANC; linux-kernel@vger.kernel.org > Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI > > On Fri, May 10, 2013 at

RE: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-13 Thread Mathias LEBLANC
Kent Yoder [mailto:shpedoi...@gmail.com] Sent: 10 May, 2013 17:07 To: Mathias LEBLANC Cc: Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG; TPM Device Driver List; Jean-Luc BLANC; linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI On Fri, May 10, 20

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-10 Thread Kent Yoder
On Fri, May 10, 2013 at 8:38 AM, Kent Yoder wrote: > Hi Mathias, Sorry, this note got sent before I was done somehow... A few compile warnings left: drivers/char/tpm/tpm_spi_stm_st33.c: In function ‘tpm_stm_spi_status’: drivers/char/tpm/tpm_spi_stm_st33.c:289:2: error: ‘data’ is used uninitiali

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-07 Thread Matthias Leblanc
From: Mathias Leblanc * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you h

Re: [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-06 Thread Kent Yoder
Hi Mathias, On Mon, May 06, 2013 at 01:14:44PM +0200, Matthias Leblanc wrote: > From: Mathias Leblanc > > * STMicroelectronics version 1.2.0, Copyright (C) 2010 > * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. > * This is free software, and you are welcome to redistribute it > * und

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-06 Thread Matthias Leblanc
From: Mathias Leblanc * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you h

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-29 Thread Kent Yoder
On Sun, Apr 28, 2013 at 03:16:33AM +0200, Peter Hüwe wrote: > Hi Matthias, > > it's nice to see that you consider most of the comments, unfortunately I > still > have some left ;) > > > +/* > > + * tpm_st33_spi_init initialize driver > > + * @return: 0 if successful, else non zero value. > > +

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-29 Thread Matthias Leblanc
From: Mathias Leblanc * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you h

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-27 Thread Peter Hüwe
Hi Matthias, it's nice to see that you consider most of the comments, unfortunately I still have some left ;) > +/* > + * tpm_st33_spi_init initialize driver > + * @return: 0 if successful, else non zero value. > + */ > +static int __init tpm_st33_spi_init(void) > +{ > + return spi_register_

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-26 Thread Kent Yoder
an-Luc BLANC; > linux-kernel@vger.kernel.org > Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI > > On Mon, Apr 22, 2013 at 06:32:05PM +0200, Mathias LEBLANC wrote: > > Hi Kent, > > > > > + while (size < count && >

RE: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-25 Thread Mathias LEBLANC
; Jean-Luc BLANC; linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI On Mon, Apr 22, 2013 at 06:32:05PM +0200, Mathias LEBLANC wrote: > Hi Kent, > > > + while (size < count && > > +

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-22 Thread Kent Yoder
> Sent: 22 April, 2013 17:26 > To: Mathias LEBLANC > Cc: Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG; > tpmdd-de...@lists.sourceforge.net; Jean-Luc BLANC; > linux-kernel@vger.kernel.org > Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI >

Re: [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-22 Thread Kent Yoder
On Mon, Apr 22, 2013 at 06:20:17PM +0200, Matthias Leblanc wrote: > From: Mathias Leblanc > > * STMicroelectronics version 1.2.0, Copyright (C) 2010 > * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. > * This is free software, and you are welcome to redistribute it > * under certain co

RE: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-22 Thread Mathias LEBLANC
r.kernel.org Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI On Mon, Apr 22, 2013 at 10:50:06AM +0200, Mathias Leblanc wrote: > * STMicroelectronics version 1.2.0, Copyright (C) 2010 > * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. > * This is free sof

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-22 Thread Matthias Leblanc
From: Mathias Leblanc * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you h

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-22 Thread Kent Yoder
On Mon, Apr 22, 2013 at 10:50:06AM +0200, Mathias Leblanc wrote: > * STMicroelectronics version 1.2.0, Copyright (C) 2010 > * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. > * This is free software, and you are welcome to redistribute it > * under certain conditions. > > This is the dr

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-22 Thread Mathias Leblanc
* STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you have a TPM security chip

RE: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-19 Thread Mathias LEBLANC
n-Luc BLANC; linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI Hi Matthias, On Fri, Apr 12, 2013 at 10:44:11AM +0200, Matthias Leblanc wrote: > From: Mathias Leblanc > > * STMicroelectronics version 1.2.0, Copyright (C) 2010 >

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-17 Thread Kent Yoder
Hi Matthias, On Fri, Apr 12, 2013 at 10:44:11AM +0200, Matthias Leblanc wrote: > From: Mathias Leblanc > > * STMicroelectronics version 1.2.0, Copyright (C) 2010 > * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. > * This is free software, and you are welcome to redistribute it > * un

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-12 Thread Matthias Leblanc
From: Mathias Leblanc * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you h

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-11 Thread Peter Hüwe
Hi Matthias, Am Donnerstag, 11. April 2013, 10:58:59 schrieb Mathias LEBLANC: > Hi Peter, > > Yes, you have right, these error are generated by #ifndef > __STM_ST33_TPM_SPI_H__ Just remove it and the #endif next the structure. Yes, I know that - for the submission to be included this has to be cha

RE: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-11 Thread Mathias LEBLANC
] Sent: 10 April, 2013 22:32 To: tpmdd-de...@lists.sourceforge.net; Mathias LEBLANC; Kent Yoder; Jean-Luc BLANC Cc: linux-kernel@vger.kernel.org; Mathias leblanc Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI Hi Matthias, Am Dienstag, 9. April 2013, 16:42:42 schrieb

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-10 Thread Peter Hüwe
Hi Matthias, Am Dienstag, 9. April 2013, 16:42:42 schrieb Matthias Leblanc: > From: Mathias leblanc > > * STMicroelectronics version 1.2.0, Copyright (C) 2010 > * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. > * This is free software, and you are welcome to redistribute it > * under

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-09 Thread Matthias Leblanc
From: Mathias leblanc * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you h

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-08 Thread Mathias Leblanc
* STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you have a TPM security chip

RE: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-03-25 Thread Mathias LEBLANC
...@lists.sourceforge.net; Jean-Luc BLANC; linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI On Mon, Mar 25, 2013 at 10:08 AM, Matthias Leblanc wrote: > From: admin01 > > * STMicroelectronics version 1.2.0, Copyright

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-03-25 Thread Kent Yoder
On Mon, Mar 25, 2013 at 10:08 AM, Matthias Leblanc wrote: > From: admin01 > > * STMicroelectronics version 1.2.0, Copyright (C) 2010 > * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. > * This is free software, and you are welcome to redistribute it > * under certain conditions. > > Th

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-03-25 Thread Matthias Leblanc
From: admin01 * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you have a TP

[PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-01-07 Thread Mathias Leblanc
From: admin01 * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you have a TP