Re: [PATCH] Support TrackStick of Thinkpad L570

2018-02-12 Thread Pali Rohár
喜 Masaki Ota ; linux-in...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] Support TrackStick of Thinkpad L570 > > On Monday 20 November 2017 16:55:30 Masaki Ota wrote: > > From: Masaki Ota > > - The issue is that Thinkpad L570 TrackStick does not work. B

RE: [PATCH] Support TrackStick of Thinkpad L570

2017-12-05 Thread Masaki Ota
.torok...@gmail.com; benjamin.tissoi...@redhat.com; aaron...@canonical.com; j...@ristioja.ee; linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] Support TrackStick of Thinkpad L570 On Monday 04 December 2017 09:40:04 Masaki Ota wrote: > Hi, Pali, > > It does not

Re: [PATCH] Support TrackStick of Thinkpad L570

2017-12-04 Thread Pali Rohár
6:12 PM > To: 太田 真喜 Masaki Ota > Cc: Masaki Ota <012ne...@gmail.com>; dmitry.torok...@gmail.com; > benjamin.tissoi...@redhat.com; aaron...@canonical.com; j...@ristioja.ee; > linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] Support TrackStick of

RE: [PATCH] Support TrackStick of Thinkpad L570

2017-12-04 Thread Masaki Ota
December 04, 2017 6:12 PM To: 太田 真喜 Masaki Ota Cc: Masaki Ota <012ne...@gmail.com>; dmitry.torok...@gmail.com; benjamin.tissoi...@redhat.com; aaron...@canonical.com; j...@ristioja.ee; linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] Support TrackStick of T

Re: [PATCH] Support TrackStick of Thinkpad L570

2017-12-04 Thread Pali Rohár
t: Saturday, December 02, 2017 6:08 AM > To: Masaki Ota <012ne...@gmail.com> > Cc: dmitry.torok...@gmail.com; benjamin.tissoi...@redhat.com; > aaron...@canonical.com; j...@ristioja.ee; 太田 真喜 Masaki Ota > ; linux-in...@vger.kernel.org; > linux-kernel@vger.kernel.org >

RE: [PATCH] Support TrackStick of Thinkpad L570

2017-12-03 Thread Masaki Ota
.@gmail.com; benjamin.tissoi...@redhat.com; aaron...@canonical.com; j...@ristioja.ee; 太田 真喜 Masaki Ota ; linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] Support TrackStick of Thinkpad L570 On Wednesday 29 November 2017 17:33:58 Masaki Ota wrote: > From: Masaki Ota > -

Re: [PATCH] Support TrackStick of Thinkpad L570

2017-12-01 Thread Pali Rohár
On Wednesday 29 November 2017 17:33:58 Masaki Ota wrote: > From: Masaki Ota > - The issue is that Thinkpad L570 TrackStick does not work. Because the main > interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface > Firmware setting of TrackStick. The detail is that TrackStic

Re: Support TrackStick of Thinkpad L570

2017-12-01 Thread Jonathan Liu
Hi Masaki, On 29 November 2017 at 19:33, Masaki Ota <012ne...@gmail.com> wrote: > From: Masaki Ota > - The issue is that Thinkpad L570 TrackStick does not work. Because the main > interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface > Firmware setting of TrackStick. The

Re: [PATCH] Support TrackStick of Thinkpad L570

2017-11-29 Thread Aaron Ma
Please add the patch version next time. The patch make trackstick work on L570. Tested-by: Aaron Ma On 11/29/2017 04:33 PM, Masaki Ota wrote: > From: Masaki Ota > - The issue is that Thinkpad L570 TrackStick does not work. Because the main > interface of Thinkpad L570 device is SMBus, so ALPS

[PATCH] Support TrackStick of Thinkpad L570

2017-11-29 Thread Masaki Ota
From: Masaki Ota - The issue is that Thinkpad L570 TrackStick does not work. Because the main interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface Firmware setting of TrackStick. The detail is that TrackStick otp bit is disabled. - Add the code that checks 0xD7 address v

Re: [PATCH] Support TrackStick of Thinkpad L570

2017-11-29 Thread Pali Rohár
struct psmouse *psmouse) > { > bool is_dual = false; > + int reg_val = 0; > + struct ps2dev *ps2dev = &psmouse->ps2dev; > > - if (IS_SS4PLUS_DEV(priv->dev_id)) > + if (IS_SS4PLUS_DEV(priv->dev_id)) { > is_dual = (otp[0]

[PATCH] Support TrackStick of Thinkpad L570

2017-11-28 Thread Masaki Ota
+ if (IS_SS4PLUS_DEV(priv->dev_id)) { is_dual = (otp[0][0] >> 4) & 0x01; + if (!is_dual) { + /* For support TrackStick of Thinkpad L570 device */ + if (alps_exit_com

RE: [PATCH] Support TrackStick of Thinkpad L570

2017-11-28 Thread Masaki Ota
:16 AM To: Masaki Ota <012ne...@gmail.com> Cc: benjamin.tissoi...@redhat.com; pali.ro...@gmail.com; aaron...@canonical.com; j...@ristioja.ee; 太田 真喜 Masaki Ota ; linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] Support TrackStick of Thinkpad L570 Hi, On Mon,

Re: [PATCH] Support TrackStick of Thinkpad L570

2017-11-25 Thread Dmitry Torokhov
struct psmouse *psmouse) > { > bool is_dual = false; > + int reg_val = 0; > + struct ps2dev *ps2dev = &psmouse->ps2dev; > > - if (IS_SS4PLUS_DEV(priv->dev_id)) > + if (IS_SS4PLUS_DEV(priv->dev_id)) { >

Re: [PATCH] Support TrackStick of Thinkpad L570

2017-11-25 Thread Dmitry Torokhov
= 0; > + struct ps2dev *ps2dev = &psmouse->ps2dev; > > - if (IS_SS4PLUS_DEV(priv->dev_id)) > + if (IS_SS4PLUS_DEV(priv->dev_id)) { > is_dual = (otp[0][0] >> 4) & 0x01; > > + /* For support TrackStick of Th

Re: Support TrackStick of Thinkpad L570

2017-11-23 Thread Jonathan Liu
Hi Masaki, On 20 November 2017 at 18:55, Masaki Ota <012ne...@gmail.com> wrote: > From: Masaki Ota > - The issue is that Thinkpad L570 TrackStick does not work. Because the main > interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface > Firmware setting of TrackStick. The

Re: [PATCH] Support TrackStick of Thinkpad L570

2017-11-20 Thread Aaron Ma
struct psmouse *psmouse) > { > bool is_dual = false; > + int reg_val = 0; > + struct ps2dev *ps2dev = &psmouse->ps2dev; > > - if (IS_SS4PLUS_DEV(priv->dev_id)) > + if (IS_SS4PLUS_DEV(priv->dev_id)) { >

RE: [PATCH] Support TrackStick of Thinkpad L570

2017-11-20 Thread Masaki Ota
i Ota <012ne...@gmail.com>; dmitry.torok...@gmail.com Cc: benjamin.tissoi...@redhat.com; aaron...@canonical.com; j...@ristioja.ee; 太田 真喜 Masaki Ota ; linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] Support TrackStick of Thinkpad L570 On Monday 20 November 20

Re: [PATCH] Support TrackStick of Thinkpad L570

2017-11-20 Thread Pali Rohár
DEV(priv->dev_id)) > + if (IS_SS4PLUS_DEV(priv->dev_id)) { > is_dual = (otp[0][0] >> 4) & 0x01; > > + /* For support TrackStick of Thinkpad L570 device */ > + if (alps_exit_command_mode(psmouse) == 0

[PATCH] Support TrackStick of Thinkpad L570

2017-11-19 Thread Masaki Ota
+ if (IS_SS4PLUS_DEV(priv->dev_id)) { is_dual = (otp[0][0] >> 4) & 0x01; + /* For support TrackStick of Thinkpad L570 device */ + if (alps_exit_command_mode(psmouse) == 0 && + alps_enter_command_mode(psmouse) == 0) {