Re: Resource leak in unshare

2015-11-03 Thread Dmitry Vyukov
On Tue, Nov 3, 2015 at 1:48 PM, Eric Dumazet wrote: > On Tue, 2015-11-03 at 09:48 +0100, Dmitry Vyukov wrote: >> On Mon, Nov 2, 2015 at 8:01 PM, Eric W. Biederman >> wrote: >> > Dmitry Vyukov writes: >> > >> >> Hello, >> >> >> >> I am hitting the following warnings on >> >> bcee19f424a0d8c26ecf

Re: Resource leak in unshare

2015-11-03 Thread Eric Dumazet
On Tue, 2015-11-03 at 09:48 +0100, Dmitry Vyukov wrote: > On Mon, Nov 2, 2015 at 8:01 PM, Eric W. Biederman > wrote: > > Dmitry Vyukov writes: > > > >> Hello, > >> > >> I am hitting the following warnings on > >> bcee19f424a0d8c26ecf2607b73c690802658b29 (4.3): > > > > Do you have any trace of th

Re: Resource leak in unshare

2015-11-03 Thread Dmitry Vyukov
On Mon, Nov 2, 2015 at 8:01 PM, Eric W. Biederman wrote: > Dmitry Vyukov writes: > >> Hello, >> >> I am hitting the following warnings on >> bcee19f424a0d8c26ecf2607b73c690802658b29 (4.3): > > Do you have any trace of the earlier failures? > > This appears to be something caused by an earlier fai

Re: Resource leak in unshare

2015-11-02 Thread David Miller
From: Eric Dumazet Date: Mon, 02 Nov 2015 17:16:44 -0800 > On Mon, 2015-11-02 at 17:08 -0800, Eric Dumazet wrote: >> From: Eric Dumazet > > Erm, patch title would be : > > [PATCH] sit: fix sit0 percpu double allocations :-) Applied and queued up for -stable. -- To unsubscribe from this list:

Re: Resource leak in unshare

2015-11-02 Thread Eric Dumazet
On Mon, 2015-11-02 at 17:08 -0800, Eric Dumazet wrote: > From: Eric Dumazet Erm, patch title would be : [PATCH] sit: fix sit0 percpu double allocations -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordom

Re: Resource leak in unshare

2015-11-02 Thread Eric Dumazet
From: Eric Dumazet sit0 device allocates its percpu storage twice : - One time in ipip6_tunnel_init() - One time in ipip6_fb_tunnel_init() Thus we leak 48 bytes per possible cpu per network namespace dismantle. ipip6_fb_tunnel_init() can be much simpler and does not return an error, and should

Re: Resource leak in unshare

2015-11-02 Thread Eric Dumazet
On Mon, 2015-11-02 at 11:54 -0800, Eric Dumazet wrote: > On Mon, 2015-11-02 at 13:01 -0600, Eric W. Biederman wrote: > > Dmitry Vyukov writes: > > > > > Hello, > > > > > > I am hitting the following warnings on > > > bcee19f424a0d8c26ecf2607b73c690802658b29 (4.3): > > > > Do you have any trace o

Re: Resource leak in unshare

2015-11-02 Thread Eric Dumazet
On Mon, 2015-11-02 at 13:01 -0600, Eric W. Biederman wrote: > Dmitry Vyukov writes: > > > Hello, > > > > I am hitting the following warnings on > > bcee19f424a0d8c26ecf2607b73c690802658b29 (4.3): > > Do you have any trace of the earlier failures? > > This appears to be something caused by an ea

Re: Resource leak in unshare

2015-11-02 Thread Eric W. Biederman
Dmitry Vyukov writes: > Hello, > > I am hitting the following warnings on > bcee19f424a0d8c26ecf2607b73c690802658b29 (4.3): Do you have any trace of the earlier failures? This appears to be something caused by an earlier failure (possibly whatever fails to allocate memory). Having network devi

Resource leak in unshare

2015-11-02 Thread Dmitry Vyukov
Hello, I am hitting the following warnings on bcee19f424a0d8c26ecf2607b73c690802658b29 (4.3): [ cut here ] WARNING: CPU: 3 PID: 16049 at fs/proc/generic.c:575 remove_proc_entry+0x284/0x2f0() remove_proc_entry: removing non-empty directory 'net/dev_snmp6', leaking at least