Re: Removal of dump_stack()s from /fs/ubifs/io.c

2019-05-16 Thread Richard Weinberger
- Ursprüngliche Mail - >> They are not required, but they are just useful. While you are right that the >> locations within UBIFS are unique, >> they are not for the whole kernel context. >> Filesystem functions can get called via many different paths from VFS... > > Isn't that true for an

Re: Removal of dump_stack()s from /fs/ubifs/io.c

2019-05-15 Thread Shreya Gangan (shgangan)
Hi Richard, On 5/15/19, 2:01 PM, "Richard Weinberger" wrote: > On Wed, May 15, 2019 at 10:45 PM Shreya Gangan (shgangan) > wrote: > > > > Hi, > > > > /fs/ubifs/io.c has dump_stack() in multiple functions upon errors and > > sometimes warnings. > > Since the error and warning messages seem to

Re: Removal of dump_stack()s from /fs/ubifs/io.c

2019-05-15 Thread Richard Weinberger
On Wed, May 15, 2019 at 10:45 PM Shreya Gangan (shgangan) wrote: > > Hi, > > /fs/ubifs/io.c has dump_stack() in multiple functions upon errors and > sometimes warnings. > Since the error and warning messages seem to be unique, the functional value > of these dump_stacks is not apparent. > Why a

Removal of dump_stack()s from /fs/ubifs/io.c

2019-05-15 Thread Shreya Gangan (shgangan)
Hi, /fs/ubifs/io.c has dump_stack() in multiple functions upon errors and sometimes warnings. Since the error and warning messages seem to be unique, the functional value of these dump_stacks is not apparent. Why are these dump_stacks required and what issues might occur upon the removal