Re: Read O_DIRECT regression in 3.7-rc8 (bisected)

On 12/08/2012 01:57 AM, Linus Torvalds wrote: > > On Fri, 7 Dec 2012, Linus Torvalds wrote: >> >> This (TOTALLY UNTESTED) patch adds it the same iov_shorten() logic that >> the write side has. It does it differently (in fs/block_dev.c rather than >> in mm/filemap.c), but I actually suspect this

Re: Read O_DIRECT regression in 3.7-rc8 (bisected)

On Fri, 7 Dec 2012, Linus Torvalds wrote: > > This (TOTALLY UNTESTED) patch adds it the same iov_shorten() logic that > the write side has. It does it differently (in fs/block_dev.c rather than > in mm/filemap.c), but I actually suspect this is a nicer way to do it, and > maybe we should do t

Re: Read O_DIRECT regression in 3.7-rc8 (bisected)

On Sat, 8 Dec 2012, Milan Broz wrote: > > seems this commit in 3.7-rc8 caused regression for O_DIRECT > read near the end of the device. Oh, good find, and thanks for the test-case. I had looked at the O_DIRECT side, and convinced myself that it already truncates to i_size_read(), but it look

Read O_DIRECT regression in 3.7-rc8 (bisected)

Hi Linus, seems this commit in 3.7-rc8 caused regression for O_DIRECT read near the end of the device. bbec0270bdd887f96377065ee38b8848b5afa395 is the first bad commit commit bbec0270bdd887f96377065ee38b8848b5afa395 Author: Linus Torvalds Date: Thu Nov 29 12:31:52 2012 -0800 blkdev_max_bl