Re: xfs mknod regression

2007-12-19 Thread Rafael J. Wysocki
On Wednesday, 19 of December 2007, David Chinner wrote: > On Tue, Dec 18, 2007 at 05:36:42PM +, Christoph Hellwig wrote: > > > > This was broken by my '[XFS] simplify xfs_create/mknod/symlink prototype', > > which assigned the re-shuffled ondisk dev_t back to the rdev variable in > > xfs_vn_mk

Re: xfs mknod regression

2007-12-18 Thread Bret Towe
On Dec 18, 2007 9:36 AM, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > This was broken by my '[XFS] simplify xfs_create/mknod/symlink prototype', > which assigned the re-shuffled ondisk dev_t back to the rdev variable in > xfs_vn_mknod. Because of that i_rdev is set to the ondisk dev_t instead

Re: xfs mknod regression

2007-12-18 Thread David Chinner
On Tue, Dec 18, 2007 at 05:36:42PM +, Christoph Hellwig wrote: > > This was broken by my '[XFS] simplify xfs_create/mknod/symlink prototype', > which assigned the re-shuffled ondisk dev_t back to the rdev variable in > xfs_vn_mknod. Because of that i_rdev is set to the ondisk dev_t instead >

Re: xfs mknod regression

2007-12-18 Thread Christoph Hellwig
This was broken by my '[XFS] simplify xfs_create/mknod/symlink prototype', which assigned the re-shuffled ondisk dev_t back to the rdev variable in xfs_vn_mknod. Because of that i_rdev is set to the ondisk dev_t instead of the linux dev_t later down the function. Fortunately the fix for it is tr

Re: xfs mknod regression

2007-12-18 Thread David Chinner
On Mon, Dec 17, 2007 at 08:48:40PM -0800, Bret Towe wrote: > I hit a bug in 2.6.24-rc looks to be in 2.6.23 also so not sure how > long it's been there > with an xfs filesystem pbuilder has an issue using device files it > makes for chroot > the mknod command looks to work fine the file is created