Re: vmstat: On demand vmstat workers V5

2014-05-29 Thread Paul E. McKenney
On Thu, May 29, 2014 at 11:24:15AM -0500, Christoph Lameter wrote: > On Thu, 29 May 2014, Frederic Weisbecker wrote: > > > > Well yes and I am tying directly into that scheme there in cpu.c to > > > display the active vmstat threads in sysfs. so its the same. > > > > I don't think so. Or is there

Re: vmstat: On demand vmstat workers V5

2014-05-29 Thread Paul E. McKenney
On Thu, May 29, 2014 at 04:26:05PM +0200, Frederic Weisbecker wrote: > On Thu, May 29, 2014 at 09:07:44AM -0500, Christoph Lameter wrote: > > On Thu, 29 May 2014, Frederic Weisbecker wrote: > > > > > The cpumasks in cpu.c are special as they are the base of the > > > cpumask_var_t > > > definitio

Re: vmstat: On demand vmstat workers V5

2014-05-29 Thread Christoph Lameter
On Thu, 29 May 2014, Frederic Weisbecker wrote: > > Well yes and I am tying directly into that scheme there in cpu.c to > > display the active vmstat threads in sysfs. so its the same. > > I don't think so. Or is there something in vmstat that cpumask_var_t > definition depends upon? This patch d

Re: vmstat: On demand vmstat workers V5

2014-05-29 Thread Frederic Weisbecker
On Thu, May 29, 2014 at 09:07:44AM -0500, Christoph Lameter wrote: > On Thu, 29 May 2014, Frederic Weisbecker wrote: > > > The cpumasks in cpu.c are special as they are the base of the cpumask_var_t > > definition. They are necessary to define nr_cpu_bits which is the base of > > cpumask_var_t all

Re: vmstat: On demand vmstat workers V5

2014-05-29 Thread Christoph Lameter
On Thu, 29 May 2014, Frederic Weisbecker wrote: > The cpumasks in cpu.c are special as they are the base of the cpumask_var_t > definition. They are necessary to define nr_cpu_bits which is the base of > cpumask_var_t allocations. As such they must stay lower level and defined > on top of NR_CPUS.

Re: vmstat: On demand vmstat workers V5

2014-05-28 Thread Frederic Weisbecker
On Wed, May 28, 2014 at 11:19:49AM -0500, Christoph Lameter wrote: > On Wed, 28 May 2014, Frederic Weisbecker wrote: > > > On Mon, May 12, 2014 at 01:18:10PM -0500, Christoph Lameter wrote: > > > #ifdef CONFIG_SMP > > > static DEFINE_PER_CPU(struct delayed_work, vmstat_work); > > > int sysctl_s

Re: vmstat: On demand vmstat workers V5

2014-05-28 Thread Christoph Lameter
On Wed, 28 May 2014, Frederic Weisbecker wrote: > On Mon, May 12, 2014 at 01:18:10PM -0500, Christoph Lameter wrote: > > #ifdef CONFIG_SMP > > static DEFINE_PER_CPU(struct delayed_work, vmstat_work); > > int sysctl_stat_interval __read_mostly = HZ; > > +static DECLARE_BITMAP(cpu_stat_off_bits,

Re: vmstat: On demand vmstat workers V5

2014-05-28 Thread Frederic Weisbecker
On Mon, May 12, 2014 at 01:18:10PM -0500, Christoph Lameter wrote: > #ifdef CONFIG_SMP > static DEFINE_PER_CPU(struct delayed_work, vmstat_work); > int sysctl_stat_interval __read_mostly = HZ; > +static DECLARE_BITMAP(cpu_stat_off_bits, CONFIG_NR_CPUS) __read_mostly; > +const struct cpumask *con

Re: vmstat: On demand vmstat workers V5

2014-05-27 Thread Christoph Lameter
On Thu, 15 May 2014, Thomas Gleixner wrote: > Acked-by me for the general approach. > > I don't want to give any unqualified opinion on the mm/vmstat parts of > this patch. Thanks. Any other comments? Could we get this into -next? -- To unsubscribe from this list: send the line "unsubscribe linu

Re: vmstat: On demand vmstat workers V5

2014-05-14 Thread Thomas Gleixner
On Wed, 14 May 2014, Christoph Lameter wrote: > - Shepherd thread as a general worker thread. This means > that the general mechanism to control worker thread > cpu proposed by Frederic Weisbecker is necessary to > restrict the shepherd thread to the cpus not used > for low latency tasks. H

Re: vmstat: On demand vmstat workers V5

2014-05-14 Thread Christoph Lameter
On Tue, 13 May 2014, Thomas Gleixner wrote: > So as I said before: This wants to be on a dedicated housekeeper > workqueue. Where the thread is placed is decided by the core depending > on system configuration and state. Ok then we can just go with a generic worker thread and use the work on rest

Re: vmstat: On demand vmstat workers V5

2014-05-13 Thread Thomas Gleixner
On Mon, 12 May 2014, Christoph Lameter wrote: > > V4->V5: > - Shepherd thread on a specific cpu (HOUSEKEEPING_CPU). That's going to fail for the NOHZ_IDLE case, e.g. for the little/big cluster support on ARM. They need to be able to move it from the housekeeper on the big to the housekeeper on t