Re: v5.9-rc1 commit reliably breaks pci nvme detection

2020-08-21 Thread John Garry
On 20/08/2020 18:12, Christoph Hellwig wrote: On Thu, Aug 20, 2020 at 11:10:58AM -0600, Jens Axboe wrote: To be fair, I've only heard this one complaint about it, so hopefully it's not too widespread. I'm on an x86-64 laptop myself with nvme, and it works just fine:-) The cause for this is the

Re: v5.9-rc1 commit reliably breaks pci nvme detection

2020-08-20 Thread Jens Axboe
On 8/20/20 11:12 AM, Christoph Hellwig wrote: > On Thu, Aug 20, 2020 at 11:10:58AM -0600, Jens Axboe wrote: >> To be fair, I've only heard this one complaint about it, so hopefully it's >> not too widespread. I'm on an x86-64 laptop myself with nvme, and it works >> just fine :-) > > The cause for

Re: v5.9-rc1 commit reliably breaks pci nvme detection

2020-08-20 Thread Christoph Hellwig
On Thu, Aug 20, 2020 at 11:10:58AM -0600, Jens Axboe wrote: > To be fair, I've only heard this one complaint about it, so hopefully it's > not too widespread. I'm on an x86-64 laptop myself with nvme, and it works > just fine :-) The cause for this is the weird NVMe of by ones, where 0 in a field

Re: v5.9-rc1 commit reliably breaks pci nvme detection

2020-08-20 Thread Jens Axboe
On 8/20/20 11:07 AM, Ahmed S. Darwish wrote: > On Thu, Aug 20, 2020 at 09:35:38AM -0600, Jens Axboe wrote: >> On 8/17/20 9:58 AM, Jens Axboe wrote: >>> On 8/17/20 8:56 AM, Keith Busch wrote: On Mon, Aug 17, 2020 at 03:50:11PM +0200, Ahmed S. Darwish wrote: > Hello, > > Below v5.9-r

Re: v5.9-rc1 commit reliably breaks pci nvme detection

2020-08-20 Thread Ahmed S. Darwish
On Thu, Aug 20, 2020 at 09:35:38AM -0600, Jens Axboe wrote: > On 8/17/20 9:58 AM, Jens Axboe wrote: > > On 8/17/20 8:56 AM, Keith Busch wrote: > >> On Mon, Aug 17, 2020 at 03:50:11PM +0200, Ahmed S. Darwish wrote: > >>> Hello, > >>> > >>> Below v5.9-rc1 commit reliably breaks my boot on a Thinkpad

Re: v5.9-rc1 commit reliably breaks pci nvme detection

2020-08-20 Thread Jens Axboe
On 8/17/20 9:58 AM, Jens Axboe wrote: > On 8/17/20 8:56 AM, Keith Busch wrote: >> On Mon, Aug 17, 2020 at 03:50:11PM +0200, Ahmed S. Darwish wrote: >>> Hello, >>> >>> Below v5.9-rc1 commit reliably breaks my boot on a Thinkpad e480 >>> laptop. PCI nvme detection fails, and the kernel becomes not ab

Re: v5.9-rc1 commit reliably breaks pci nvme detection

2020-08-17 Thread Keith Busch
On Mon, Aug 17, 2020 at 03:50:11PM +0200, Ahmed S. Darwish wrote: > Hello, > > Below v5.9-rc1 commit reliably breaks my boot on a Thinkpad e480 > laptop. PCI nvme detection fails, and the kernel becomes not able > anymore to find the rootfs / parse "root=". > > Bisecting v5.8=>v5.9-rc1 blames tha

Re: v5.9-rc1 commit reliably breaks pci nvme detection

2020-08-17 Thread Jens Axboe
On 8/17/20 8:56 AM, Keith Busch wrote: > On Mon, Aug 17, 2020 at 03:50:11PM +0200, Ahmed S. Darwish wrote: >> Hello, >> >> Below v5.9-rc1 commit reliably breaks my boot on a Thinkpad e480 >> laptop. PCI nvme detection fails, and the kernel becomes not able >> anymore to find the rootfs / parse "roo