Re: [PATCH] fix unchecked mutex_lock_interruptible (was Re: use mutex instead of semaphore in RocketPort driver)

2007-05-23 Thread Matthias Kaehlcke
El Wed, May 23, 2007 at 06:25:49PM +0530 Satyam Sharma ha dit: > On 5/23/07, Jiri Slaby <[EMAIL PROTECTED]> wrote: > >Simon Arlott napsal(a): > >> On 22/05/07 21:06, Matthias Kaehlcke wrote: > >>> would the following resolve the problem? > >>> > >>> if(mutex_lock_interruptible(&info->write_mtx))

[PATCH] fix unchecked mutex_lock_interruptible (was Re: use mutex instead of semaphore in RocketPort driver)

2007-05-23 Thread Satyam Sharma
On 5/23/07, Jiri Slaby <[EMAIL PROTECTED]> wrote: Simon Arlott napsal(a): > On 22/05/07 21:06, Matthias Kaehlcke wrote: >> would the following resolve the problem? >> >> if(mutex_lock_interruptible(&info->write_mtx)) return >> -ERESTARTSYS >> >> thanks for your comments Hum. I remember

Re: use mutex instead of semaphore in RocketPort driver

2007-05-22 Thread Jiri Slaby
Simon Arlott napsal(a): > On 22/05/07 21:06, Matthias Kaehlcke wrote: >> would the following resolve the problem? >> >> if(mutex_lock_interruptible(&info->write_mtx)) return >> -ERESTARTSYS >> >> thanks for your comments >> > > No. At least one user of tty_operations/tty_driver's write fun

Re: use mutex instead of semaphore in RocketPort driver

2007-05-22 Thread Simon Arlott
On 22/05/07 21:06, Matthias Kaehlcke wrote: El Tue, May 22, 2007 at 09:59:01AM -0700 Arjan van de Ven ha dit: Please provide context when quoting a patch, git grep takes a while... - down_interruptible(&info->write_sem); + mutex_lock_interruptible(&info->write_mtx); #ifdef R

Re: use mutex instead of semaphore in RocketPort driver

2007-05-22 Thread Matthias Kaehlcke
El Tue, May 22, 2007 at 09:59:01AM -0700 Arjan van de Ven ha dit: > > > > - down_interruptible(&info->write_sem); > > + mutex_lock_interruptible(&info->write_mtx); > > > > #ifdef ROCKET_DEBUG_WRITE > > printk(KERN_INFO "rp_write %d chars...", count); > > @@ -1773,7 +1776,7 @@ end: > >

Re: use mutex instead of semaphore in RocketPort driver

2007-05-22 Thread Arjan van de Ven
> > - down_interruptible(&info->write_sem); > + mutex_lock_interruptible(&info->write_mtx); > > #ifdef ROCKET_DEBUG_WRITE > printk(KERN_INFO "rp_write %d chars...", count); > @@ -1773,7 +1776,7 @@ end: > wake_up_interruptible(&tty->poll_wait); > #endif > } >