==> Regarding Re: unused 'size' assignment in filemap_nopage; Herbert Xu
<[EMAIL PROTECTED]> adds:
herbert> Jeff Moyer <[EMAIL PROTECTED]> wrote:
>> After this, size is not referenced. So, either this potential
>> reassignment of size is superfluous, or
Jeff Moyer <[EMAIL PROTECTED]> wrote:
>
> After this, size is not referenced. So, either this potential reassignment
> of size is superfluous, or we are missing some other code later on in the
> function. If it is the former, I've attached a patch which will remove the
> code.
Yes it's obsolete
> size = (i_size_read(inode) + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
> if (pgoff >= size)
> goto outside_data_content;
> ...
> if (size > endoff)
> size = endoff;
>
>After this, size is not referenced. So, either this potential reassignment
>
3 matches
Mail list logo
