[PATCH] Introduce CONFIG_CHECK_SIGNATURE (was: Re: uninline check_signature())

2007-08-12 Thread Geert Uytterhoeven
Hi Linus, On Tue, 17 Jul 2007, Linus Torvalds wrote: > On Tue, 17 Jul 2007, Geert Uytterhoeven wrote: > > OR I'll have to disable HAS_IOMEM on m68k, and invent a new Kconfig > > symbol for lots of other stuff that currently depends on HAS_IOMEM... > > Well, as far as I'm concerned, you co

Re: uninline check_signature()

2007-07-18 Thread Maciej W. Rozycki
On Tue, 17 Jul 2007, Geert Uytterhoeven wrote: > > > No, no revert, please. If the architecture doesn't support readb() then > > > we > > > need some reliable way of working that out within Kconfig. > > > > Isn't that CONFIG_HAS_IOMEM? > > No, having memory mapped I/O doesn't mean you have PCI

Re: uninline check_signature()

2007-07-17 Thread Geert Uytterhoeven
On Tue, 17 Jul 2007, Linus Torvalds wrote: > On Tue, 17 Jul 2007, Geert Uytterhoeven wrote: > > OR I'll have to disable HAS_IOMEM on m68k, and invent a new Kconfig > > symbol for lots of other stuff that currently depends on HAS_IOMEM... > > Well, as far as I'm concerned, you could also make all d

Re: uninline check_signature()

2007-07-17 Thread Linus Torvalds
On Tue, 17 Jul 2007, Geert Uytterhoeven wrote: > > OR I'll have to disable HAS_IOMEM on m68k, and invent a new Kconfig > symbol for lots of other stuff that currently depends on HAS_IOMEM... Well, as far as I'm concerned, you could also make all drivers that actually need "check_signature()" d

Re: uninline check_signature()

2007-07-17 Thread Al Viro
On Tue, Jul 17, 2007 at 10:31:08PM +0200, Geert Uytterhoeven wrote: > And we'll all live with a check_signature() in our kernel, which is used > only by a few legacy drivers that depend on ISA || PCI... > > OR I'll have to disable HAS_IOMEM on m68k, and invent a new Kconfig > symbol for lots of ot

Re: uninline check_signature()

2007-07-17 Thread Geert Uytterhoeven
On Tue, 17 Jul 2007, Linus Torvalds wrote: > On Tue, 17 Jul 2007, Geert Uytterhoeven wrote: > > M68k uses I/O memory for all I/O (hence it sets CONFIG_HAS_IOMEM), but > > many m68k machines don't have PCI or ISA (hence it doesn't set > > CONFIG_PCI resp. CONFIG_ISA). > > It doesn't matter whether

Re: uninline check_signature()

2007-07-17 Thread Linus Torvalds
On Tue, 17 Jul 2007, Geert Uytterhoeven wrote: > > M68k uses I/O memory for all I/O (hence it sets CONFIG_HAS_IOMEM), but > many m68k machines don't have PCI or ISA (hence it doesn't set > CONFIG_PCI resp. CONFIG_ISA). It doesn't matter whether the machine has PCI or ISA. The only thing that m

Re: uninline check_signature()

2007-07-17 Thread Geert Uytterhoeven
On Tue, 17 Jul 2007, Jeff Dike wrote: > On Tue, Jul 17, 2007 at 03:22:16PM +0200, Geert Uytterhoeven wrote: > > I saw this patch went in. > > > > iomap_copy.o ues the raw I/O memory accessors, so it truly depends on > > CONFIG_HAS_IOMEM. > > This works for UML. Of course. UML (and s390) doesn't

Re: uninline check_signature()

2007-07-17 Thread Jeff Dike
On Tue, Jul 17, 2007 at 03:22:16PM +0200, Geert Uytterhoeven wrote: > I saw this patch went in. > > iomap_copy.o ues the raw I/O memory accessors, so it truly depends on > CONFIG_HAS_IOMEM. This works for UML. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscri

Re: uninline check_signature()

2007-07-17 Thread Geert Uytterhoeven
On Tue, 17 Jul 2007, Heiko Carstens wrote: > On Mon, Jul 16, 2007 at 03:35:34PM -0700, Linus Torvalds wrote: > > On Mon, 16 Jul 2007, Andrew Morton wrote: > > > > > > No, no revert, please. If the architecture doesn't support readb() then > > > we > > > need some reliable way of working that out

Re: uninline check_signature()

2007-07-17 Thread Pekka Enberg
Hi Heiko, On 7/17/07, Heiko Carstens <[EMAIL PROTECTED]> wrote: Hmm.. this breaks s390 and probably m68k and UML as well: CC lib/check_signature.o lib/check_signature.c: In function 'check_signature': lib/check_signature.c:19: error: implicit declaration of function 'readb' Just to con

Re: uninline check_signature()

2007-07-17 Thread Geert Uytterhoeven
On Tue, 17 Jul 2007, Geert Uytterhoeven wrote: > On Mon, 16 Jul 2007, Linus Torvalds wrote: > > On Mon, 16 Jul 2007, Andrew Morton wrote: > > > No, no revert, please. If the architecture doesn't support readb() then > > > we > > > need some reliable way of working that out within Kconfig. > > >

Re: uninline check_signature()

2007-07-17 Thread Geert Uytterhoeven
On Mon, 16 Jul 2007, Linus Torvalds wrote: > On Mon, 16 Jul 2007, Andrew Morton wrote: > > No, no revert, please. If the architecture doesn't support readb() then we > > need some reliable way of working that out within Kconfig. > > Isn't that CONFIG_HAS_IOMEM? No, having memory mapped I/O doesn

Re: uninline check_signature()

2007-07-16 Thread Heiko Carstens
On Mon, Jul 16, 2007 at 03:35:34PM -0700, Linus Torvalds wrote: > On Mon, 16 Jul 2007, Andrew Morton wrote: > > > > No, no revert, please. If the architecture doesn't support readb() then we > > need some reliable way of working that out within Kconfig. > > Isn't that CONFIG_HAS_IOMEM? That was

Re: uninline check_signature()

2007-07-16 Thread Linus Torvalds
On Mon, 16 Jul 2007, Andrew Morton wrote: > > No, no revert, please. If the architecture doesn't support readb() then we > need some reliable way of working that out within Kconfig. Isn't that CONFIG_HAS_IOMEM? Linus - To unsubscribe from this list: send the line "unsubscribe

Re: uninline check_signature()

2007-07-16 Thread Andrew Morton
On Tue, 17 Jul 2007 00:12:57 +0200 Heiko Carstens <[EMAIL PROTECTED]> wrote: > On Mon, Jul 16, 2007 at 06:02:55PM +, Linux Kernel Mailing List wrote: > > Gitweb: > > http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=cc2ea416b2aa04d0c34ff2281a23dae5b76b7b3b >

Re: uninline check_signature()

2007-07-16 Thread Heiko Carstens
On Mon, Jul 16, 2007 at 06:02:55PM +, Linux Kernel Mailing List wrote: > Gitweb: > http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=cc2ea416b2aa04d0c34ff2281a23dae5b76b7b3b > Commit: cc2ea416b2aa04d0c34ff2281a23dae5b76b7b3b > Parent: 4e7bd66318b3ae60f