Re: udev 182: response timeout for request_firmware in module_probe path

2012-08-26 Thread Benjamin Herrenschmidt
On Thu, 2012-08-23 at 17:46 +0100, Alan Cox wrote: > > IMO, the driver probing path is allowed to sleep, so looks request > firmware > > should be allowed inside .probe(). > > I'm not convinced about that. It can sleep but its holding various > locks > in most cases, and it looks like that can end

Re: udev 182: response timeout for request_firmware in module_probe path

2012-08-25 Thread Linus Torvalds
On Thu, Aug 23, 2012 at 8:31 AM, Kay Sievers wrote: > > Calling out from inside the kernel and blocking in a firmware loading > userspace transaction during module_init() is kind of weird. It's *very* common. I personally would prefer if drivers did their firmware loading not at probe time, but

Re: udev 182: response timeout for request_firmware in module_probe path

2012-08-23 Thread Ming Lei
On Fri, Aug 24, 2012 at 12:46 AM, Alan Cox wrote: >> IMO, the driver probing path is allowed to sleep, so looks request firmware >> should be allowed inside .probe(). > > I'm not convinced about that. It can sleep but its holding various locks > in most cases, and it looks like that can end up in

Re: udev 182: response timeout for request_firmware in module_probe path

2012-08-23 Thread Alan Cox
> IMO, the driver probing path is allowed to sleep, so looks request firmware > should be allowed inside .probe(). I'm not convinced about that. It can sleep but its holding various locks in most cases, and it looks like that can end up in a complete heap. By all means *request* the firmware asyn

Re: udev 182: response timeout for request_firmware in module_probe path

2012-08-23 Thread Ming Lei
On Thu, Aug 23, 2012 at 11:31 PM, Kay Sievers wrote: > On Thu, Aug 23, 2012 at 5:16 PM, Ming Lei wrote: >> On Tue, Aug 21, 2012 at 1:34 PM, Ming Lei wrote: > >>> I found that udev 182 doesn't response for the request_firmware in >>> module_probe path until 30sec later after the 'ADD' event of fi

Re: udev 182: response timeout for request_firmware in module_probe path

2012-08-23 Thread Kay Sievers
On Thu, Aug 23, 2012 at 5:16 PM, Ming Lei wrote: > On Tue, Aug 21, 2012 at 1:34 PM, Ming Lei wrote: >> I found that udev 182 doesn't response for the request_firmware in >> module_probe path until 30sec later after the 'ADD' event of firmware >> device, but no such problem in udev175, sounds lik

Re: udev 182: response timeout for request_firmware in module_probe path

2012-08-23 Thread Ming Lei
Cc systemd-devel Hi, On Tue, Aug 21, 2012 at 1:34 PM, Ming Lei wrote: > Hi Kay, > > I found that udev 182 doesn't response for the request_firmware in > module_probe path until 30sec later after the 'ADD' event of firmware > device, but no such problem in udev175, sounds like a regression of ude