Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-31 Thread Sam Ravnborg
> > Here is what I mean, specifically. And this is build tested :-) > > From 97ef1bb0c8e371b7988287f38bd107c4aa14d78d Mon Sep 17 00:00:00 2001 > From: David S. Miller <[EMAIL PROTECTED]> > Date: Tue, 30 Oct 2007 21:44:00 -0700 > Subject: [PATCH] [TIPC]: Fix headercheck wrt. tipc_config.h > > It

Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-30 Thread Alex Riesen
David Miller, Wed, Oct 31, 2007 05:56:16 +0100: > diff --git a/include/linux/string.h b/include/linux/string.h > index 836062b..c5d3fca 100644 > --- a/include/linux/string.h > +++ b/include/linux/string.h > @@ -3,16 +3,14 @@ > > /* We don't want strings.h stuff being user by user stuff by accide

Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-30 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 21:14:04 -0700 (PDT) > Unfortunately I have to back it out, it breaks the build. > > In file included from net/tipc/core.h:41, > from net/tipc/addr.c:37: > include/linux/tipc_config.h: In function 'TLV_SET': > include/

Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-30 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 15:31:54 -0700 (PDT) > From: Sam Ravnborg <[EMAIL PROTECTED]> > Date: Tue, 30 Oct 2007 23:20:25 +0100 > > > Something like this.. > > I like it - much better than adding string.h to unidef-y. > > PS - had not pulled latest -linus - so

Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-30 Thread David Miller
From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 23:20:25 +0100 > On Tue, Oct 30, 2007 at 03:05:37PM -0700, David Miller wrote: > > From: David Miller <[EMAIL PROTECTED]> > > Date: Tue, 30 Oct 2007 14:59:26 -0700 (PDT) > > > > > I think the thing to do is just __KERNEL__ protect the

Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-30 Thread Sam Ravnborg
On Tue, Oct 30, 2007 at 03:05:37PM -0700, David Miller wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Tue, 30 Oct 2007 14:59:26 -0700 (PDT) > > > I think the thing to do is just __KERNEL__ protect the > > include and require userspace to > > include itself when using these headers. > >

Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-30 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 14:59:26 -0700 (PDT) > I think the thing to do is just __KERNEL__ protect the > include and require userspace to > include itself when using these headers. > > That's what I'm testing right now. > > I'm pretty sure those inlines are

Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-30 Thread David Miller
From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 22:54:09 +0100 > tipc_config.h uses memcpy in an inline function that is > never used in the kernel. > I'm awaiting response from tipc people if we can kill > that inline or we should make it a macro. > But davem decided just to include

Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-30 Thread Sam Ravnborg
On Tue, Oct 30, 2007 at 08:13:17PM +0100, Alex Riesen wrote: > Sorry for random Cc: list. > > v2.6.24-rc1-423-g97855b4, with CONFIG_HEADERS_CHECK=y > > $ make > ... > CHECK include/linux/tipc_config.h > /home/raa/linux/usr/include/linux/tipc_config.h requires linux/string.h, > which does not