Re: cpufreq notifiers break suspend -- Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-09 Thread Viresh Kumar
On 08-07-19, 16:13, Pavel Machek wrote: > On Mon 2019-07-08 14:58:40, Viresh Kumar wrote: > > Though it makes me wonder why I didn't hit this thing. I was using the > > cpu_cooling device the other day, which calls cpufreq_update_policy() > > very frequently on heat-up. And I had a hair dryer blowi

Re: cpufreq notifiers break suspend -- Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-08 Thread Pavel Machek
On Mon 2019-07-08 14:58:40, Viresh Kumar wrote: > On 08-07-19, 10:28, Rafael J. Wysocki wrote: > > Pavel has tested the latest version of the patch series AFAICS. > > > > The locking added by the commit in question to > > refresh_frequency_limits() requires an update of > > cpufreq_update_policy()

Re: cpufreq notifiers break suspend -- Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-08 Thread Rafael J. Wysocki
On Mon, Jul 8, 2019 at 11:28 AM Viresh Kumar wrote: > > On 08-07-19, 10:28, Rafael J. Wysocki wrote: > > Pavel has tested the latest version of the patch series AFAICS. > > > > The locking added by the commit in question to > > refresh_frequency_limits() requires an update of > > cpufreq_update_po

Re: cpufreq notifiers break suspend -- Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-08 Thread Viresh Kumar
On 08-07-19, 10:28, Rafael J. Wysocki wrote: > Pavel has tested the latest version of the patch series AFAICS. > > The locking added by the commit in question to > refresh_frequency_limits() requires an update of > cpufreq_update_policy(), or it will deadlock in there because of the > lock acquire

Re: cpufreq notifiers break suspend -- Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-08 Thread Rafael J. Wysocki
On Mon, Jul 8, 2019 at 5:05 AM Viresh Kumar wrote: > > On 06-07-19, 22:30, Pavel Machek wrote: > > Hi! > > > > > Anyway, if 5.2-rc7 is OK, something in this branch causes the problem > > > to happen for you. > > > > > > I would try > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/rafael

Re: cpufreq notifiers break suspend -- Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-07 Thread Viresh Kumar
On 06-07-19, 22:30, Pavel Machek wrote: > Hi! > > > Anyway, if 5.2-rc7 is OK, something in this branch causes the problem > > to happen for you. > > > > I would try > > > > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=f012a132824fc870b90980540f727c7

cpufreq notifiers break suspend -- Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-06 Thread Pavel Machek
Hi! > Anyway, if 5.2-rc7 is OK, something in this branch causes the problem > to happen for you. > > I would try > > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=f012a132824fc870b90980540f727c76fc72e244 > > to narrow down the scope somewhat. Bisec

Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-06 Thread Pavel Machek
Hi! > > > > Suspend is broken in next-20190704 on Thinkpad X60. > > > > > > Broken in what way? Any details? > > > > > > > It very very probably worked ok in 20190701. > > > > > > Well, please try the linux-next branch from linux-pm.git > > > (git://git.kernel.org/pub/scm/linux/kernel/git/rafael/

Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-06 Thread Pavel Machek
Hi! > > commit 1e2a4c9019eb53f62790fadf86c14a54f4cf4888 (patch) > > treecb5339fcaae2166832f91f4ce9f40575cc6cb6e5 > > parent 3836c60c063581294c3a82f8cbccf3f702951358 (diff) > > parent 0a811974f3f79eea299af79c29595d8e1cb80a15 (diff) > > download > > linux-pm-1e2a4c9019eb53f62790fadf86c14a54f4

Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-06 Thread Pavel Machek
Hi! > > > > Suspend is broken in next-20190704 on Thinkpad X60. > > > > > > Broken in what way? Any details? > > > > > > > It very very probably worked ok in 20190701. > > > > > > Well, please try the linux-next branch from linux-pm.git > > > (git://git.kernel.org/pub/scm/linux/kernel/git/rafael/

Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-06 Thread Rafael J. Wysocki
On Fri, Jul 5, 2019 at 8:50 PM Pavel Machek wrote: > > On Fri 2019-07-05 00:59:35, Rafael J. Wysocki wrote: > > On Thu, Jul 4, 2019 at 9:20 PM Pavel Machek wrote: > > > > > > Hi! > > > > > > Suspend is broken in next-20190704 on Thinkpad X60. > > > > Broken in what way? Any details? > > > > > It

Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-05 Thread Pavel Machek
On Fri 2019-07-05 00:59:35, Rafael J. Wysocki wrote: > On Thu, Jul 4, 2019 at 9:20 PM Pavel Machek wrote: > > > > Hi! > > > > Suspend is broken in next-20190704 on Thinkpad X60. > > Broken in what way? Any details? > > > It very very probably worked ok in 20190701. > > Well, please try the lin

Re: suspend broken in next-20190704 on Thinkpad X60

2019-07-04 Thread Rafael J. Wysocki
On Thu, Jul 4, 2019 at 9:20 PM Pavel Machek wrote: > > Hi! > > Suspend is broken in next-20190704 on Thinkpad X60. Broken in what way? Any details? > It very very probably worked ok in 20190701. Well, please try the linux-next branch from linux-pm.git (git://git.kernel.org/pub/scm/linux/kernel