Re: stmmac-socfpga breakage in arm-soc

2014-03-24 Thread srinivas kandagatla
On 19/03/14 15:07, Arnd Bergmann wrote: > Ok, so the two of you basically moved in opposite directions where > Srinivas started out with the method you ended up with and vice versa. Yes thats correct, While adding dwmac-sunxi.c we decided to go with callback methods given its flexibility for callin

Re: stmmac-socfpga breakage in arm-soc

2014-03-21 Thread Arnd Bergmann
On Wednesday 19 March 2014, Emilio López wrote: > El 19/03/14 11:58, Arnd Bergmann escribió: > (snip) > > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt > > b/Documentation/devicetree/bindings/net/stmmac.txt > > index 5748351..19d5648 100644 > > --- a/Documentation/devicetree/bindin

Re: stmmac-socfpga breakage in arm-soc

2014-03-19 Thread Emilio López
Hi Arnd, El 19/03/14 11:58, Arnd Bergmann escribió: (snip) diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt index 5748351..19d5648 100644 --- a/Documentation/devicetree/bindings/net/stmmac.txt +++ b/Documentation/devicetree/binding

Re: stmmac-socfpga breakage in arm-soc

2014-03-19 Thread Arnd Bergmann
On Wednesday 19 March 2014 09:20:17 Dinh Nguyen wrote: > > Peppe asked me to remove DWMAC_SOCFPGA Koption and take the dwmac-sti.c > file as an example, which I did. The original patch for dwmac-sti.c had > just a CONFIG_ARCH_STI Kconfig option and not CONFIG_DWMAC_STI. > > http://marc.info/?l=l

Re: stmmac-socfpga breakage in arm-soc

2014-03-19 Thread Arnd Bergmann
On Wednesday 19 March 2014 09:34:09 Dinh Nguyen wrote: > > diff --git a/arch/arm/boot/dts/socfpga.dtsi > b/arch/arm/boot/dts/socfpga.dtsi > index 5f1e256..953801c 100644 > --- a/arch/arm/boot/dts/socfpga.dtsi > +++ b/arch/arm/boot/dts/socfpga.dtsi > @@ -456,8 +456,10 @@ >

Re: stmmac-socfpga breakage in arm-soc

2014-03-19 Thread Dinh Nguyen
Hi Arnd, On 03/19/2014 09:05 AM, Arnd Bergmann wrote: On Wednesday 19 March 2014 08:33:28 Dinh Nguyen wrote: On 03/19/2014 07:33 AM, Arnd Bergmann wrote: * Replaced the parent/child DT nodes with a combined node * Renamed the device node from 'ethernet0' to 'ethernet' as the standard name

Re: stmmac-socfpga breakage in arm-soc

2014-03-19 Thread Dinh Nguyen
On 03/19/2014 09:05 AM, Arnd Bergmann wrote: On Wednesday 19 March 2014 08:33:28 Dinh Nguyen wrote: On 03/19/2014 07:33 AM, Arnd Bergmann wrote: * Replaced the parent/child DT nodes with a combined node * Renamed the device node from 'ethernet0' to 'ethernet' as the standard name. * Remo

Re: stmmac-socfpga breakage in arm-soc

2014-03-19 Thread Arnd Bergmann
On Wednesday 19 March 2014 08:33:28 Dinh Nguyen wrote: > On 03/19/2014 07:33 AM, Arnd Bergmann wrote: > > > > * Replaced the parent/child DT nodes with a combined node > > * Renamed the device node from 'ethernet0' to 'ethernet' > >as the standard name. > > * Removed interrupt-names and clock-n

Re: stmmac-socfpga breakage in arm-soc

2014-03-19 Thread Dinh Nguyen
Hi Arnd, On 03/19/2014 07:33 AM, Arnd Bergmann wrote: Hi Dinh, I just merged your stmmac socfpga glue driver with Ack from David Miller, but then found multiple issues with it. I've attempted to fix them up in an untested patch below, which I could apply on top, if everyone thinks this is a goo