Re: spidev: fix hang when transfer_one_message fails

2014-01-27 Thread Daniel Santos
On 01/24/2014 07:01 AM, Mark Brown wrote: Please don't write enormous walls of text, it really doesn't make it easy to read your messages or encourage doing so. Use blank lines between paragraphs (including within lists) and try to either split or condense your ideas so that what you're trying

Re: spidev: fix hang when transfer_one_message fails

2014-01-24 Thread Mark Brown
On Thu, Jan 23, 2014 at 08:21:39PM -0600, Daniel Santos wrote: > On 01/23/2014 12:17 PM, Mark Brown wrote: > >On Thu, Jan 23, 2014 at 05:47:02PM +0100, Geert Uytterhoeven wrote: Please don't write enormous walls of text, it really doesn't make it easy to read your messages or encourage doing so.

Re: spidev: fix hang when transfer_one_message fails

2014-01-23 Thread Daniel Santos
On 01/23/2014 12:17 PM, Mark Brown wrote: On Thu, Jan 23, 2014 at 05:47:02PM +0100, Geert Uytterhoeven wrote: Probably your transfer_one_message() forgot to call spi_finalize_current_message()? Is this allowed in case of failure? Probably not, or at least we should be consistent about requirin

Re: spidev: fix hang when transfer_one_message fails

2014-01-23 Thread Mark Brown
On Thu, Jan 23, 2014 at 05:47:02PM +0100, Geert Uytterhoeven wrote: > Probably your transfer_one_message() forgot to call > spi_finalize_current_message()? Is this allowed in case of failure? Probably not, or at least we should be consistent about requiring it or not. Do you want to send a rever

Re: spidev: fix hang when transfer_one_message fails

2014-01-23 Thread Geert Uytterhoeven
On Mon, Jan 6, 2014 at 12:39 AM, wrote: > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -735,7 +735,9 @@ static void spi_pump_messages(struct kthread_work *work) > ret = master->transfer_one_message(master, master->cur_msg); > if (ret) { > dev_err(&master-

Re: spidev: fix hang when transfer_one_message fails

2014-01-06 Thread Mark Brown
On Sun, Jan 05, 2014 at 05:39:26PM -0600, danielfsan...@att.net wrote: > This corrects a problem in spi_pump_messages() that leads to an spi > message hanging forever when a call to transfer_one_message() fails. > This failure occurs in my MCP2210 driver when the cs_change bit is set > on the last