Re: schedule_timeout() called with state TASK_RUNNING from fs/select.c

2007-07-10 Thread Robert P. J. Day
On Sun, 8 Jul 2007, Oleg Nesterov wrote: > Robert P. J. Day wrote: > > > > as i understand it, schedule_timeout() should always be called with > > a current->state of TASK_INTERRUPTIBLE or TASK_UNINTERRUPTIBLE, no? > > No. > > Yes, it is pointless to call schedule() if it is known that ->state ==

Re: schedule_timeout() called with state TASK_RUNNING from fs/select.c

2007-07-08 Thread Oleg Nesterov
Robert P. J. Day wrote: > > as i understand it, schedule_timeout() should always be called with > a current->state of TASK_INTERRUPTIBLE or TASK_UNINTERRUPTIBLE, no? No. Yes, it is pointless to call schedule() if it is known that ->state == TASK_RUNNING, but sometimes the task doesn't know its s