Re: regarding use of various cmpxchg* API

2014-06-06 Thread Peter Zijlstra
On Fri, Jun 06, 2014 at 10:17:20AM -0400, Pranith Kumar wrote: > On 06/06/2014 03:29 AM, Peter Zijlstra wrote: > > > > > Don't think that's useful. If you really want to go do something, try > > the annotation I suggested to get the parisc/sparc32 things correct > > again. Add the __atomic sparse

Re: regarding use of various cmpxchg* API

2014-06-06 Thread Pranith Kumar
On 06/06/2014 03:29 AM, Peter Zijlstra wrote: > > Don't think that's useful. If you really want to go do something, try > the annotation I suggested to get the parisc/sparc32 things correct > again. Add the __atomic sparse address space and the store()/load() > accessors. > OK. I am not sure wh

Re: regarding use of various cmpxchg* API

2014-06-06 Thread Peter Zijlstra
On Thu, Jun 05, 2014 at 06:44:37PM -0400, Pranith Kumar wrote: > Hi Peter, Ingo, > > I see that in the drivers there are the following types of cmpxchg API: > > __cmpxchg64() That shouldn't really be used, and its only used in intel-iommu.c. > atomic_cmpxchg() > atomic64_cmpxchg() > atomic_long