Re: radix-tree.c:__lookup_slot() dead code removal

2006-12-04 Thread WU Fengguang
On Mon, Dec 04, 2006 at 09:18:40PM +1100, Nick Piggin wrote: > Frank van Maarseveen wrote: > >Most of the code suggests that it is valid to insert a NULL item, > >possibly a zero item with pointer cast. However, in __lookup_slot() > >whether or not the slot is found seems to depend on the actual va

Re: radix-tree.c:__lookup_slot() dead code removal

2006-12-04 Thread Nick Piggin
Frank van Maarseveen wrote: Most of the code suggests that it is valid to insert a NULL item, possibly a zero item with pointer cast. However, in __lookup_slot() whether or not the slot is found seems to depend on the actual value of the item in one special case. But further on it doesn't make an

Re: radix-tree.c:__lookup_slot() dead code removal

2006-12-03 Thread Fengguang Wu
On Sun, Dec 03, 2006 at 06:02:31PM +0100, Frank van Maarseveen wrote: > --- a/lib/radix-tree.c2006-12-03 13:23:00.0 +0100 > +++ b/lib/radix-tree.c2006-12-03 17:57:03.0 +0100 > @@ -319,9 +319,6 @@ static inline void **__lookup_slot(struc > if (index > radix_tree