Re: pci_size() error condition

2005-07-14 Thread Ivan Kokshaysky
On Thu, Jul 14, 2005 at 11:04:00AM -0500, John Rose wrote: > Okay, point taken :) So for cases of base == maxbase, why would we ever > want to return a nonzero value? What is the intended purpose of the > second part of that conditional? Well, just two examples (both for PCI IO limited to 16 bit

Re: pci_size() error condition

2005-07-14 Thread John Rose
> It was always effectual for IO where the mask is 0x. Okay, point taken :) So for cases of base == maxbase, why would we ever want to return a nonzero value? What is the intended purpose of the second part of that conditional? - To unsubscribe from this list: send the line "unsubscribe lin

Re: pci_size() error condition

2005-07-13 Thread Ivan Kokshaysky
On Wed, Jul 13, 2005 at 05:53:13PM -0500, John Rose wrote: > Before a recent change, mask was a 64-bit number. The second part of > the if statement would always resolve to true, since the 32-bit bitop > would never equal the 64-bit mask. So the second part of the if > statement was ineffectual u