Re: next-20130117 - kernel BUG with aio

2013-02-06 Thread Valdis . Kletnieks
On Tue, 05 Feb 2013 09:20:15 -0800, Kent Overstreet said: > The "smoosh struct kiocb" patch also needs to be dropped. That causes > aio_rw_vect_retry() to check ki_nbytes/ki_left after they've been > overwritten by aio_complete(), which causes it to return an error when > it shouldn't have, which

Re: next-20130117 - kernel BUG with aio

2013-02-05 Thread Valdis . Kletnieks
On Tue, 05 Feb 2013 09:20:15 -0800, Kent Overstreet said: > On Tue, Feb 05, 2013 at 10:53:00AM -0500, valdis.kletni...@vt.edu wrote: > > On Thu, 31 Jan 2013 16:37:27 -0800, Kent Overstreet said: > > > On Thu, Jan 31, 2013 at 01:59:52PM -0800, Andrew Morton wrote: > > > > Did this get fixed? > > > >

Re: next-20130117 - kernel BUG with aio

2013-02-05 Thread Kent Overstreet
On Tue, Feb 05, 2013 at 10:53:00AM -0500, valdis.kletni...@vt.edu wrote: > On Thu, 31 Jan 2013 16:37:27 -0800, Kent Overstreet said: > > On Thu, Jan 31, 2013 at 01:59:52PM -0800, Andrew Morton wrote: > > > Did this get fixed? > > > With the patches I sent you, yes - not seeing a new linux-next tre

Re: next-20130117 - kernel BUG with aio

2013-02-05 Thread Valdis . Kletnieks
On Thu, 31 Jan 2013 16:37:27 -0800, Kent Overstreet said: > On Thu, Jan 31, 2013 at 01:59:52PM -0800, Andrew Morton wrote: > > Did this get fixed? > With the patches I sent you, yes - not seeing a new linux-next tree yet? Well, it's a mixed bag at my end. Finally got a chance to do some more tes

Re: next-20130117 - kernel BUG with aio

2013-01-31 Thread Kent Overstreet
On Thu, Jan 31, 2013 at 01:59:52PM -0800, Andrew Morton wrote: > On Tue, 22 Jan 2013 16:28:18 -0500 > valdis.kletni...@vt.edu wrote: > > > On Tue, 22 Jan 2013 21:43:27 +0800, Hillf Danton said: > > > On Mon, Jan 21, 2013 at 9:24 PM, Valdis Kletnieks > > > wrote: > > > > Am seeing a reproducible B

Re: next-20130117 - kernel BUG with aio

2013-01-31 Thread Andrew Morton
On Tue, 22 Jan 2013 16:28:18 -0500 valdis.kletni...@vt.edu wrote: > On Tue, 22 Jan 2013 21:43:27 +0800, Hillf Danton said: > > On Mon, Jan 21, 2013 at 9:24 PM, Valdis Kletnieks > > wrote: > > > Am seeing a reproducible BUG in the kernel with next-20130117 > > > whenever I fire up VirtualBox. Unf

Re: next-20130117 - kernel BUG with aio

2013-01-29 Thread Jan Kara
On Thu 24-01-13 14:13:52, Kent Overstreet wrote: > On Thu, Jan 24, 2013 at 01:27:59PM -0800, Andrew Morton wrote: > > Please also take a look at Jan's recent > > http://www.spinics.net/lists/linux-fsdevel/msg61738.html and have a > > think about how this plays with your patchset. > > I can't think

Re: next-20130117 - kernel BUG with aio

2013-01-24 Thread Kent Overstreet
On Thu, Jan 24, 2013 at 02:25:37PM -0800, Zach Brown wrote: > > No, I didn't see that bug until after I'd fixed the other three, but as > > far as I can tell everything's fixed with the patches I'm about to mail > > out - my test VM has been running for the past two days without errors, > > it's ki

Re: next-20130117 - kernel BUG with aio

2013-01-24 Thread Jeff Moyer
Zach Brown writes: >> No, I didn't see that bug until after I'd fixed the other three, but as >> far as I can tell everything's fixed with the patches I'm about to mail >> out - my test VM has been running for the past two days without errors, >> it's kill -9'ing a process that's got iocbs in fli

Re: next-20130117 - kernel BUG with aio

2013-01-24 Thread Zach Brown
> No, I didn't see that bug until after I'd fixed the other three, but as > far as I can tell everything's fixed with the patches I'm about to mail > out - my test VM has been running for the past two days without errors, > it's kill -9'ing a process that's got iocbs in flight to a loopback > devic

Re: next-20130117 - kernel BUG with aio

2013-01-24 Thread Kent Overstreet
On Thu, Jan 24, 2013 at 01:27:59PM -0800, Andrew Morton wrote: > Please also take a look at Jan's recent > http://www.spinics.net/lists/linux-fsdevel/msg61738.html and have a > think about how this plays with your patchset. I can't think of any possible interactions - none of my aio stuff messes w

Re: next-20130117 - kernel BUG with aio

2013-01-24 Thread Kent Overstreet
On Thu, Jan 24, 2013 at 01:27:59PM -0800, Andrew Morton wrote: > On Thu, 24 Jan 2013 13:18:50 -0800 > Kent Overstreet wrote: > > > So, Andrew - that "smoosh struct kiocb" patch should just be dropped, > > even if I fixed that issue clearly the idea is a lot less safe than I > > thought. I've got

Re: next-20130117 - kernel BUG with aio

2013-01-24 Thread Andrew Morton
On Thu, 24 Jan 2013 13:18:50 -0800 Kent Overstreet wrote: > So, Andrew - that "smoosh struct kiocb" patch should just be dropped, > even if I fixed that issue clearly the idea is a lot less safe than I > thought. I've got patches for the other stuff I'm going to mail out > momentarily. Dropped.

Re: next-20130117 - kernel BUG with aio

2013-01-24 Thread Kent Overstreet
On Thu, Jan 24, 2013 at 12:22:21PM -0500, valdis.kletni...@vt.edu wrote: > On Wed, 23 Jan 2013 20:10:03 +0800, Hillf Danton said: > > > Try again? > > --- > > > > --- a/fs/aio.c Tue Jan 22 21:37:54 2013 > > +++ b/fs/aio.c Wed Jan 23 20:06:14 2013 > > Now seeing this: > > [ 2941.495370]

Re: next-20130117 - kernel BUG with aio

2013-01-24 Thread Valdis . Kletnieks
On Wed, 23 Jan 2013 20:10:03 +0800, Hillf Danton said: > Try again? > --- > > --- a/fs/aio.cTue Jan 22 21:37:54 2013 > +++ b/fs/aio.cWed Jan 23 20:06:14 2013 Now seeing this: [ 2941.495370] [ cut here ] [ 2941.495379] WARNING: at fs/aio.c:336 put_ioctx+0x1

Re: next-20130117 - kernel BUG with aio

2013-01-23 Thread Hillf Danton
On Wed, Jan 23, 2013 at 5:28 AM, wrote: > On Tue, 22 Jan 2013 21:43:27 +0800, Hillf Danton said: >> On Mon, Jan 21, 2013 at 9:24 PM, Valdis Kletnieks >> wrote: >> > Am seeing a reproducible BUG in the kernel with next-20130117 >> > whenever I fire up VirtualBox. Unfortunately, I hadn't done tha

Re: next-20130117 - kernel BUG with aio

2013-01-22 Thread Valdis . Kletnieks
On Tue, 22 Jan 2013 21:43:27 +0800, Hillf Danton said: > On Mon, Jan 21, 2013 at 9:24 PM, Valdis Kletnieks > wrote: > > Am seeing a reproducible BUG in the kernel with next-20130117 > > whenever I fire up VirtualBox. Unfortunately, I hadn't done that > > in a while, so the last 'known good' kerne

Re: next-20130117 - kernel BUG with aio

2013-01-22 Thread Hillf Danton
On Mon, Jan 21, 2013 at 9:24 PM, Valdis Kletnieks wrote: > Am seeing a reproducible BUG in the kernel with next-20130117 > whenever I fire up VirtualBox. Unfortunately, I hadn't done that > in a while, so the last 'known good' kernel was next-20121203. > > I'm strongly suspecting one of Kent Over