Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-17 Thread Atish Patra
On Tue, Jun 16, 2020 at 11:30 PM Michel Lespinasse wrote: > > On Tue, Jun 16, 2020 at 11:07 PM Stafford Horne wrote: > > On Wed, Jun 17, 2020 at 02:35:39PM +0900, Stafford Horne wrote: > > > On Tue, Jun 16, 2020 at 01:47:24PM -0700, Michel Lespinasse wrote: > > > > This makes me wonder actually -

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Michel Lespinasse
On Tue, Jun 16, 2020 at 11:07 PM Stafford Horne wrote: > On Wed, Jun 17, 2020 at 02:35:39PM +0900, Stafford Horne wrote: > > On Tue, Jun 16, 2020 at 01:47:24PM -0700, Michel Lespinasse wrote: > > > This makes me wonder actually - maybe there is a latent bug that got > > > exposed after my change a

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Stafford Horne
On Wed, Jun 17, 2020 at 02:35:39PM +0900, Stafford Horne wrote: > On Tue, Jun 16, 2020 at 01:47:24PM -0700, Michel Lespinasse wrote: > > This makes me wonder actually - maybe there is a latent bug that got > > exposed after my change added the rwsem_is_locked assertion to the > > lockdep_assert_hel

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Stafford Horne
On Tue, Jun 16, 2020 at 01:47:24PM -0700, Michel Lespinasse wrote: > This makes me wonder actually - maybe there is a latent bug that got > exposed after my change added the rwsem_is_locked assertion to the > lockdep_assert_held one. If that is the case, it may be helpful to > bisect when that issu

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Michel Lespinasse
This makes me wonder actually - maybe there is a latent bug that got exposed after my change added the rwsem_is_locked assertion to the lockdep_assert_held one. If that is the case, it may be helpful to bisect when that issue first appeared, by testing before my patchset with VM_BUG_ON(!rwsem_is_lo

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Atish Patra
On Tue, Jun 16, 2020 at 12:19 PM Stafford Horne wrote: > > On Tue, Jun 16, 2020 at 03:44:49AM -0700, Michel Lespinasse wrote: > > I am also unable to reproduce the issue so far. > > > > I wanted to point to a few things in case this helps: > > - Commit 42fc541404f2 was bisected as the cause. This

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Stafford Horne
On Tue, Jun 16, 2020 at 03:44:49AM -0700, Michel Lespinasse wrote: > I am also unable to reproduce the issue so far. > > I wanted to point to a few things in case this helps: > - Commit 42fc541404f2 was bisected as the cause. This commit changes > walk_page_range_novma() to use mmap_assert_locked(

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Alex Ghiti
Le 6/16/20 à 2:07 PM, Palmer Dabbelt a écrit : On Tue, 16 Jun 2020 10:54:51 PDT (-0700), ati...@atishpatra.org wrote: On Tue, Jun 16, 2020 at 3:45 AM Michel Lespinasse wrote: I am also unable to reproduce the issue so far. I wanted to point to a few things in case this helps: - Commit 42fc54

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Atish Patra
On Tue, Jun 16, 2020 at 11:15 AM Palmer Dabbelt wrote: > > On Tue, 16 Jun 2020 11:08:55 PDT (-0700), ati...@atishpatra.org wrote: > > On Tue, Jun 16, 2020 at 11:07 AM Palmer Dabbelt wrote: > >> > >> On Tue, 16 Jun 2020 10:54:51 PDT (-0700), ati...@atishpatra.org wrote: > >> > On Tue, Jun 16, 2020

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Palmer Dabbelt
On Tue, 16 Jun 2020 11:08:55 PDT (-0700), ati...@atishpatra.org wrote: On Tue, Jun 16, 2020 at 11:07 AM Palmer Dabbelt wrote: On Tue, 16 Jun 2020 10:54:51 PDT (-0700), ati...@atishpatra.org wrote: > On Tue, Jun 16, 2020 at 3:45 AM Michel Lespinasse wrote: >> >> I am also unable to reproduce t

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Atish Patra
On Tue, Jun 16, 2020 at 11:07 AM Palmer Dabbelt wrote: > > On Tue, 16 Jun 2020 10:54:51 PDT (-0700), ati...@atishpatra.org wrote: > > On Tue, Jun 16, 2020 at 3:45 AM Michel Lespinasse wrote: > >> > >> I am also unable to reproduce the issue so far. > >> > >> I wanted to point to a few things in c

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Palmer Dabbelt
On Tue, 16 Jun 2020 10:54:51 PDT (-0700), ati...@atishpatra.org wrote: On Tue, Jun 16, 2020 at 3:45 AM Michel Lespinasse wrote: I am also unable to reproduce the issue so far. I wanted to point to a few things in case this helps: - Commit 42fc541404f2 was bisected as the cause. This commit ch

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Atish Patra
On Tue, Jun 16, 2020 at 3:45 AM Michel Lespinasse wrote: > > I am also unable to reproduce the issue so far. > > I wanted to point to a few things in case this helps: > - Commit 42fc541404f2 was bisected as the cause. This commit changes > walk_page_range_novma() to use mmap_assert_locked() instea

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Michel Lespinasse
I am also unable to reproduce the issue so far. I wanted to point to a few things in case this helps: - Commit 42fc541404f2 was bisected as the cause. This commit changes walk_page_range_novma() to use mmap_assert_locked() instead of lockdep_assert_held() - mmap_assert_locked() checks lockdep_asse

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Palmer Dabbelt
On Mon, 15 Jun 2020 21:51:08 PDT (-0700), sho...@gmail.com wrote: On Tue, Jun 16, 2020 at 06:57:47AM +0900, Stafford Horne wrote: On Mon, Jun 15, 2020 at 12:28:11AM -0700, Atish Patra wrote: > Hi, > I encountered the following issue while booting 5.8-rc1 on Qemu for RV64. > I added additional du

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-15 Thread Stafford Horne
On Tue, Jun 16, 2020 at 06:57:47AM +0900, Stafford Horne wrote: > On Mon, Jun 15, 2020 at 12:28:11AM -0700, Atish Patra wrote: > > Hi, > > I encountered the following issue while booting 5.8-rc1 on Qemu for RV64. > > I added additional dump_stack and observed that it's happening in bpf free > > pa

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-15 Thread Stafford Horne
On Mon, Jun 15, 2020 at 12:28:11AM -0700, Atish Patra wrote: > Hi, > I encountered the following issue while booting 5.8-rc1 on Qemu for RV64. > I added additional dump_stack and observed that it's happening in bpf free > path. > It happens always if CONFIG_DEBUG_VM is enabled. VM_BUG_ON_MM is > c