Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Michal Hocko
On Thu 02-03-17 09:51:31, Brian Foster wrote: > On Thu, Mar 02, 2017 at 03:34:41PM +0100, Michal Hocko wrote: > > On Thu 02-03-17 09:23:15, Brian Foster wrote: > > > On Thu, Mar 02, 2017 at 02:50:01PM +0100, Michal Hocko wrote: > > > > On Thu 02-03-17 08:41:58, Brian Foster wrote: > > > > > On Thu,

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Michal Hocko
On Thu 02-03-17 10:30:02, Brian Foster wrote: > On Thu, Mar 02, 2017 at 04:14:11PM +0100, Michal Hocko wrote: [...] > > I am not objecting to adding fatal_signal_pending as well I just thought > > that from the logic POV breaking after reaching the minimum size is just > > the right thing to do. We

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Christoph Hellwig
On Thu, Mar 02, 2017 at 09:51:31AM -0500, Brian Foster wrote: > Otherwise, I'm fine with breaking the infinite retry loop at the same > time. It looks like Christoph added this function originally so this > should probably require his ack as well.. I just moved the code around, but I'll take a loo

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Michal Hocko
On Thu 02-03-17 09:23:15, Brian Foster wrote: > On Thu, Mar 02, 2017 at 02:50:01PM +0100, Michal Hocko wrote: > > On Thu 02-03-17 08:41:58, Brian Foster wrote: > > > On Thu, Mar 02, 2017 at 02:27:55PM +0100, Michal Hocko wrote: > > [...] > > > > I see your argument about being in sync with other km

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Tetsuo Handa
Brian Foster wrote: > On Thu, Mar 02, 2017 at 01:49:09PM +0100, Michal Hocko wrote: > > On Thu 02-03-17 07:24:27, Brian Foster wrote: > > > On Thu, Mar 02, 2017 at 11:35:20AM +0100, Michal Hocko wrote: > > > > On Thu 02-03-17 19:04:48, Tetsuo Handa wrote: > > > > [...] > > > > > So, commit 5d17a73a

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Brian Foster
On Thu, Mar 02, 2017 at 04:14:11PM +0100, Michal Hocko wrote: > On Thu 02-03-17 09:51:31, Brian Foster wrote: > > On Thu, Mar 02, 2017 at 03:34:41PM +0100, Michal Hocko wrote: > > > On Thu 02-03-17 09:23:15, Brian Foster wrote: > > > > On Thu, Mar 02, 2017 at 02:50:01PM +0100, Michal Hocko wrote: >

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Brian Foster
On Thu, Mar 02, 2017 at 02:50:01PM +0100, Michal Hocko wrote: > On Thu 02-03-17 08:41:58, Brian Foster wrote: > > On Thu, Mar 02, 2017 at 02:27:55PM +0100, Michal Hocko wrote: > [...] > > > I see your argument about being in sync with other kmem helpers but > > > those are bit different because reg

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Brian Foster
On Thu, Mar 02, 2017 at 03:34:41PM +0100, Michal Hocko wrote: > On Thu 02-03-17 09:23:15, Brian Foster wrote: > > On Thu, Mar 02, 2017 at 02:50:01PM +0100, Michal Hocko wrote: > > > On Thu 02-03-17 08:41:58, Brian Foster wrote: > > > > On Thu, Mar 02, 2017 at 02:27:55PM +0100, Michal Hocko wrote: >

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Michal Hocko
On Thu 02-03-17 08:00:09, Brian Foster wrote: > On Thu, Mar 02, 2017 at 01:49:09PM +0100, Michal Hocko wrote: > > On Thu 02-03-17 07:24:27, Brian Foster wrote: > > > On Thu, Mar 02, 2017 at 11:35:20AM +0100, Michal Hocko wrote: > > > > On Thu 02-03-17 19:04:48, Tetsuo Handa wrote: > > > > [...] > >

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Brian Foster
On Thu, Mar 02, 2017 at 01:49:09PM +0100, Michal Hocko wrote: > On Thu 02-03-17 07:24:27, Brian Foster wrote: > > On Thu, Mar 02, 2017 at 11:35:20AM +0100, Michal Hocko wrote: > > > On Thu 02-03-17 19:04:48, Tetsuo Handa wrote: > > > [...] > > > > So, commit 5d17a73a2ebeb8d1("vmalloc: back off when

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Michal Hocko
On Thu 02-03-17 08:41:58, Brian Foster wrote: > On Thu, Mar 02, 2017 at 02:27:55PM +0100, Michal Hocko wrote: [...] > > I see your argument about being in sync with other kmem helpers but > > those are bit different because regular page/slab allocators allow never > > fail semantic (even though thi

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Brian Foster
On Thu, Mar 02, 2017 at 02:27:55PM +0100, Michal Hocko wrote: > On Thu 02-03-17 08:00:09, Brian Foster wrote: > > On Thu, Mar 02, 2017 at 01:49:09PM +0100, Michal Hocko wrote: > > > On Thu 02-03-17 07:24:27, Brian Foster wrote: > > > > On Thu, Mar 02, 2017 at 11:35:20AM +0100, Michal Hocko wrote: >

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Michal Hocko
On Thu 02-03-17 07:24:27, Brian Foster wrote: > On Thu, Mar 02, 2017 at 11:35:20AM +0100, Michal Hocko wrote: > > On Thu 02-03-17 19:04:48, Tetsuo Handa wrote: > > [...] > > > So, commit 5d17a73a2ebeb8d1("vmalloc: back off when the current task is > > > killed") implemented __GFP_KILLABLE flag and

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Michal Hocko
On Thu 02-03-17 19:04:48, Tetsuo Handa wrote: [...] > So, commit 5d17a73a2ebeb8d1("vmalloc: back off when the current task is > killed") implemented __GFP_KILLABLE flag and automatically applied that > flag. As a result, those who are not ready to fail upon SIGKILL are > confused. ;-) You are righ

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Brian Foster
On Thu, Mar 02, 2017 at 11:35:20AM +0100, Michal Hocko wrote: > On Thu 02-03-17 19:04:48, Tetsuo Handa wrote: > [...] > > So, commit 5d17a73a2ebeb8d1("vmalloc: back off when the current task is > > killed") implemented __GFP_KILLABLE flag and automatically applied that > > flag. As a result, those

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Tetsuo Handa
On 2017/03/02 14:19, Xiong Zhou wrote: > On Wed, Mar 01, 2017 at 04:37:31PM -0800, Christoph Hellwig wrote: >> On Wed, Mar 01, 2017 at 12:46:34PM +0800, Xiong Zhou wrote: >>> Hi, >>> >>> It's reproduciable, not everytime though. Ext4 works fine. >> >> On ext4 fsstress won't run bulkstat because it

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Xiong Zhou
On Thu, Mar 02, 2017 at 09:42:23AM +0100, Michal Hocko wrote: > On Thu 02-03-17 12:17:47, Anshuman Khandual wrote: > > On 03/02/2017 10:49 AM, Xiong Zhou wrote: > > > On Wed, Mar 01, 2017 at 04:37:31PM -0800, Christoph Hellwig wrote: > > >> On Wed, Mar 01, 2017 at 12:46:34PM +0800, Xiong Zhou wrote

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-02 Thread Michal Hocko
On Thu 02-03-17 12:17:47, Anshuman Khandual wrote: > On 03/02/2017 10:49 AM, Xiong Zhou wrote: > > On Wed, Mar 01, 2017 at 04:37:31PM -0800, Christoph Hellwig wrote: > >> On Wed, Mar 01, 2017 at 12:46:34PM +0800, Xiong Zhou wrote: > >>> Hi, > >>> > >>> It's reproduciable, not everytime though. Ext4

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-01 Thread Anshuman Khandual
On 03/02/2017 10:49 AM, Xiong Zhou wrote: > On Wed, Mar 01, 2017 at 04:37:31PM -0800, Christoph Hellwig wrote: >> On Wed, Mar 01, 2017 at 12:46:34PM +0800, Xiong Zhou wrote: >>> Hi, >>> >>> It's reproduciable, not everytime though. Ext4 works fine. >> On ext4 fsstress won't run bulkstat because it

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-01 Thread Bob Liu
On 2017/3/2 13:19, Xiong Zhou wrote: > On Wed, Mar 01, 2017 at 04:37:31PM -0800, Christoph Hellwig wrote: >> On Wed, Mar 01, 2017 at 12:46:34PM +0800, Xiong Zhou wrote: >>> Hi, >>> >>> It's reproduciable, not everytime though. Ext4 works fine. >> >> On ext4 fsstress won't run bulkstat because it do

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-01 Thread Xiong Zhou
On Wed, Mar 01, 2017 at 04:37:31PM -0800, Christoph Hellwig wrote: > On Wed, Mar 01, 2017 at 12:46:34PM +0800, Xiong Zhou wrote: > > Hi, > > > > It's reproduciable, not everytime though. Ext4 works fine. > > On ext4 fsstress won't run bulkstat because it doesn't exist. Either > way this smells l

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

2017-03-01 Thread Christoph Hellwig
On Wed, Mar 01, 2017 at 12:46:34PM +0800, Xiong Zhou wrote: > Hi, > > It's reproduciable, not everytime though. Ext4 works fine. On ext4 fsstress won't run bulkstat because it doesn't exist. Either way this smells like a MM issue to me as there were not XFS changes in that area recently.