Re: livepatch/module: remove livepatch module notifier

2016-03-15 Thread Petr Mladek
On Mon 2016-03-14 13:50:09, Jessica Yu wrote: > +++ Petr Mladek [14/03/16 16:06 +0100]: > >On Fri 2016-03-11 15:03:48, Jessica Yu wrote: > >>+err: > >>+ /* > >>+* If a patch is unsuccessfully applied, return > >>+* error to the module loader. > >>+*/ > >>+ pr_warn("patch '%s' failed

Re: livepatch/module: remove livepatch module notifier

2016-03-14 Thread Jessica Yu
+++ Petr Mladek [14/03/16 16:06 +0100]: On Fri 2016-03-11 15:03:48, Jessica Yu wrote: Remove the livepatch module notifier in favor of directly enabling and disabling patches to modules in the module loader. Hard-coding the function calls ensures that ftrace_module_enable() is run before klp_mod

Re: livepatch/module: remove livepatch module notifier

2016-02-29 Thread Jessica Yu
+++ Rusty Russell [29/02/16 11:00 +1030]: Jiri Kosina writes: On Wed, 10 Feb 2016, Rusty Russell wrote: > Remove the livepatch module notifier in favor of directly enabling and > disabling patches to modules in the module loader. Hard-coding the > function calls ensures that ftrace_module_ena

Re: livepatch/module: remove livepatch module notifier

2016-02-16 Thread Jessica Yu
+++ Miroslav Benes [16/02/16 09:41 +0100]: On Mon, 15 Feb 2016, Jessica Yu wrote: +++ Jiri Kosina [16/02/16 00:42 +0100]: > On Mon, 15 Feb 2016, Josh Poimboeuf wrote: > > > So I think the commit causing the regression is 5156dca34a3e, which > > occurred in the 4.5 cycle, *not* in 4.4. > > Agree

Re: livepatch/module: remove livepatch module notifier

2016-02-16 Thread Miroslav Benes
On Mon, 15 Feb 2016, Jessica Yu wrote: > +++ Jiri Kosina [16/02/16 00:42 +0100]: > > On Mon, 15 Feb 2016, Josh Poimboeuf wrote: > > > > > So I think the commit causing the regression is 5156dca34a3e, which > > > occurred in the 4.5 cycle, *not* in 4.4. > > > > Agreed, by "4.4 regresion" I mean "

Re: livepatch/module: remove livepatch module notifier

2016-02-15 Thread Jessica Yu
+++ Jiri Kosina [16/02/16 00:42 +0100]: On Mon, 15 Feb 2016, Josh Poimboeuf wrote: So I think the commit causing the regression is 5156dca34a3e, which occurred in the 4.5 cycle, *not* in 4.4. Agreed, by "4.4 regresion" I mean "regression compared to 4.4"; i.e. regression that will become real

Re: livepatch/module: remove livepatch module notifier

2016-02-07 Thread Rusty Russell
Jessica Yu writes: > +++ Petr Mladek [04/02/16 15:39 +0100]: >>On Mon 2016-02-01 20:17:36, Jessica Yu wrote: > [ snipped since email is getting long ] >>> diff --git a/kernel/module.c b/kernel/module.c >>> index b05d466..71c77ed 100644 >>> --- a/kernel/module.c >>> +++ b/kernel/module.c >>> @@ -53

Re: livepatch/module: remove livepatch module notifier

2016-02-05 Thread Petr Mladek
On Fri 2016-02-05 10:15:56, Miroslav Benes wrote: > On Thu, 4 Feb 2016, Jessica Yu wrote: > > Argh, thank you for catching that. I think we could split up > > complete_formation() > > into two functions in order to make the error handling work. > > > > Does all this look ok? > > Hm, there is an

Re: livepatch/module: remove livepatch module notifier

2016-02-05 Thread Miroslav Benes
On Thu, 4 Feb 2016, Jessica Yu wrote: > +++ Petr Mladek [04/02/16 15:39 +0100]: > > On Mon 2016-02-01 20:17:36, Jessica Yu wrote: > [ snipped since email is getting long ] > > > diff --git a/kernel/module.c b/kernel/module.c > > > index b05d466..71c77ed 100644 > > > --- a/kernel/module.c > > > +++

Re: livepatch/module: remove livepatch module notifier

2016-02-04 Thread Jessica Yu
+++ Petr Mladek [04/02/16 15:39 +0100]: On Mon 2016-02-01 20:17:36, Jessica Yu wrote: [ snipped since email is getting long ] diff --git a/kernel/module.c b/kernel/module.c index b05d466..71c77ed 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -53,6 +53,7 @@ #include #include #includ