Re: linux-3.14 nfsd regression

2014-05-01 Thread J. Bruce Fields
On Thu, May 01, 2014 at 07:50:34AM -0400, Mark Lord wrote: > Still a regression in 3.14.2 now. > Anyone got plans to push this patch out to mainline, as well as +stable ? This is upstream as 082f31a2169bd639785e45bf252f3d5bce0303c6 "nfsd: revert v2 half of "nfsd: don't return high mode bits"", wit

Re: linux-3.14 nfsd regression

2014-05-01 Thread Mark Lord
On 14-04-04 09:58 AM, J. Bruce Fields wrote: > On Thu, Apr 03, 2014 at 07:21:46PM -0400, Jeff Layton wrote: >> So according to the RFC you have to encode both the mode bits and the >> ftype for v2. The type bits seem to be removed from the mode in NFSv3 >> though, so perhaps we should only be doing

Re: linux-3.14 nfsd regression

2014-04-04 Thread Jeff Layton
On Fri, 4 Apr 2014 09:58:43 -0400 "J. Bruce Fields" wrote: > On Thu, Apr 03, 2014 at 07:21:46PM -0400, Jeff Layton wrote: > > So according to the RFC you have to encode both the mode bits and the > > ftype for v2. The type bits seem to be removed from the mode in NFSv3 > > though, so perhaps we s

Re: linux-3.14 nfsd regression

2014-04-04 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 07:21:46PM -0400, Jeff Layton wrote: > So according to the RFC you have to encode both the mode bits and the > ftype for v2. The type bits seem to be removed from the mode in NFSv3 > though, so perhaps we should only be doing that masking in versions > above v2? Right, the

Re: linux-3.14 nfsd regression

2014-04-03 Thread Jeff Layton
On Thu, 3 Apr 2014 16:16:27 -0400 "J. Bruce Fields" wrote: > On Thu, Apr 03, 2014 at 02:55:04PM -0400, Jeff Layton wrote: > > On Thu, 03 Apr 2014 13:51:06 -0400 > > Mark Lord wrote: > > > > > On 14-04-03 01:16 PM, J. Bruce Fields wrote: > > > > On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lor

Re: linux-3.14 nfsd regression

2014-04-03 Thread Mark Lord
On 14-04-03 05:28 PM, J. Bruce Fields wrote: > On Thu, Apr 03, 2014 at 04:48:11PM -0400, Mark Lord wrote: >> On 14-04-03 03:30 PM, J. Bruce Fields wrote: >>> On Thu, Apr 03, 2014 at 01:51:06PM -0400, Mark Lord wrote: On 14-04-03 01:16 PM, J. Bruce Fields wrote: > On Thu, Apr 03, 2014 at 12

Re: linux-3.14 nfsd regression

2014-04-03 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 04:48:11PM -0400, Mark Lord wrote: > On 14-04-03 03:30 PM, J. Bruce Fields wrote: > > On Thu, Apr 03, 2014 at 01:51:06PM -0400, Mark Lord wrote: > >> On 14-04-03 01:16 PM, J. Bruce Fields wrote: > >>> On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lord wrote: > This com

Re: linux-3.14 nfsd regression

2014-04-03 Thread Mark Lord
On 14-04-03 03:30 PM, J. Bruce Fields wrote: > On Thu, Apr 03, 2014 at 01:51:06PM -0400, Mark Lord wrote: >> On 14-04-03 01:16 PM, J. Bruce Fields wrote: >>> On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lord wrote: This commit from linux-3.14 breaks our NFS-root clients here: https

Re: linux-3.14 nfsd regression

2014-04-03 Thread Mark Lord
On 14-04-03 04:15 PM, J. Bruce Fields wrote: > On Thu, Apr 03, 2014 at 01:51:06PM -0400, Mark Lord wrote: >> On 14-04-03 01:16 PM, J. Bruce Fields wrote: >>> The original behavior was in practice harmless and changing it broke >>> something, so I think we should definitely just revert this patch. >

Re: linux-3.14 nfsd regression

2014-04-03 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 01:51:06PM -0400, Mark Lord wrote: > On 14-04-03 01:16 PM, J. Bruce Fields wrote: > > The original behavior was in practice harmless and changing it broke > > something, so I think we should definitely just revert this patch. > > Yup. Who? I'll submit this soon. --b. Au

Re: linux-3.14 nfsd regression

2014-04-03 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 02:55:04PM -0400, Jeff Layton wrote: > On Thu, 03 Apr 2014 13:51:06 -0400 > Mark Lord wrote: > > > On 14-04-03 01:16 PM, J. Bruce Fields wrote: > > > On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lord wrote: > > >> This commit from linux-3.14 breaks our NFS-root clients h

Re: linux-3.14 nfsd regression

2014-04-03 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 03:30:24PM -0400, J. Bruce Fields wrote: > On Thu, Apr 03, 2014 at 01:51:06PM -0400, Mark Lord wrote: > > On 14-04-03 01:16 PM, J. Bruce Fields wrote: > > > On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lord wrote: > > >> This commit from linux-3.14 breaks our NFS-root clie

Re: linux-3.14 nfsd regression

2014-04-03 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 01:51:06PM -0400, Mark Lord wrote: > On 14-04-03 01:16 PM, J. Bruce Fields wrote: > > On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lord wrote: > >> This commit from linux-3.14 breaks our NFS-root clients here: > >> > >> https://git.kernel.org/cgit/linux/kernel/git/torvalds

Re: linux-3.14 nfsd regression

2014-04-03 Thread Jeff Layton
On Thu, 03 Apr 2014 13:51:06 -0400 Mark Lord wrote: > On 14-04-03 01:16 PM, J. Bruce Fields wrote: > > On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lord wrote: > >> This commit from linux-3.14 breaks our NFS-root clients here: > >> > >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linu

Re: linux-3.14 nfsd regression

2014-04-03 Thread Mark Lord
On 14-04-03 01:16 PM, J. Bruce Fields wrote: > On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lord wrote: >> This commit from linux-3.14 breaks our NFS-root clients here: >> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6e14b46b91fee8a049b0940333ce13a820beaaa5 >> >>

Re: linux-3.14 nfsd regression

2014-04-03 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lord wrote: > This commit from linux-3.14 breaks our NFS-root clients here: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6e14b46b91fee8a049b0940333ce13a820beaaa5 > > > - *p++ = htonl((u32) stat->mode); > + *p++ = ht

Re: linux-3.14 nfsd regression

2014-04-03 Thread Mark Lord
Mark Lord wrote: > On 14-04-03 12:33 PM, Mark Lord wrote: >> This commit from linux-3.14 breaks our NFS-root clients here: >> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6e14b46b91fee8a049b0940333ce13a820beaaa5 >> >> >> - *p++ = htonl((u32) stat->mode); >> + *p++ =

Re: linux-3.14 nfsd regression

2014-04-03 Thread Mark Lord
On 14-04-03 12:33 PM, Mark Lord wrote: > This commit from linux-3.14 breaks our NFS-root clients here: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6e14b46b91fee8a049b0940333ce13a820beaaa5 > > > - *p++ = htonl((u32) stat->mode); > + *p++ = htonl((u32) (stat->mod